Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findDOMNode throws inside Suspense with componentDidUpdate #15857

Closed
zombieJ opened this issue Jun 11, 2019 · 5 comments
Closed

findDOMNode throws inside Suspense with componentDidUpdate #15857

zombieJ opened this issue Jun 11, 2019 · 5 comments

Comments

@zombieJ
Copy link
Contributor

zombieJ commented Jun 11, 2019

It is a...

🐞 BUG

What is the current behavior?

屏幕快照 2019-06-11 上午11 32 42

Reproduce

https://codesandbox.io/s/antd-reproduction-template-7jmkr

  1. Quick click Page 1 button.
  2. Then, quick click Page 2 button.

What is the expected behavior?

findDOMNode should work in Suspense

Others

related issue: #14188

@zombieJ
Copy link
Contributor Author

zombieJ commented Jun 12, 2019

ping @jquense @gaearon @acdlite

@eps1lon
Copy link
Collaborator

eps1lon commented Jun 19, 2019

This is likely a duplicate of #14188 which is fixed on master but not released yet.

@xiaoshuangLi
Copy link

xiaoshuangLi commented Aug 26, 2019

@zombieJ. Hi, I upgrade to react@16.9.0 and react-dom@16.9.0, but still get this error.Does upgrading version work on you??

rc-tooltip@3.7.3
rc-trigger@2.6.5
rc-align@2.4.5

image

@gaearon
Copy link
Collaborator

gaearon commented Aug 26, 2019

The original example posted by @zombieJ doesn't reproduce in 16.9 anymore.
If you have a similar problem please file a new issue with reproducing code.

@gaearon gaearon closed this as completed Aug 26, 2019
@xiaoshuangLi
Copy link

@zombieJ. Hi, I upgrade to react@16.9.0 and react-dom@16.9.0, but still get this error.Does upgrading version work on you??

rc-tooltip@3.7.3
rc-trigger@2.6.5
rc-align@2.4.5

image

It's my fault, forget to change @hot-loader/react-dom@16.8.6, Sorry..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants