Skip to content

add support for nomodule attribute on the script tag #11858

Closed
@modosc

Description

@modosc

Do you want to request a feature or report a bug?

feature: add support for the nomodule attribute to the script tag.

What is the current behavior?

with <script nomodule src="foo.js" /> i get:

Warning: Received `true` for a non-boolean attribute `nomodule`.
If you want to write it to the DOM, pass a string instead: nomodule="true" or nomodule={value.toString()}.

and the attribute is removed.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template for React 16: https://jsfiddle.net/Luktwrdm/, template for React 15: https://jsfiddle.net/hmbg7e9w/).

https://jsfiddle.net/hzdkwne6/

What is the expected behavior?

the nomodule attribute should be respected

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

react 16.2.0
chrome
osx

not a regression, i don't think it's ever worked before.

if this isn't an intentional oversight i'll open a pr to add it, seems like it's just a change to https://github.com/facebook/react/blob/master/fixtures/attribute-behavior/src/attributes.js ?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions