Remove unstable_renderIntoContainer

[gaearon]

My hunch is we want to remove it before 16 because unstable_createPortal accomplishes the same thing. I remember unstable_renderIntoContainer adding a bunch of complexity that would be nice to get rid of before committing to support it for another release cycle.

[sebmarkbage]

It doesn't allow for an incremental upgrade path though. You have to upgrade all your calls at once. Even if those are in third parties. Since the portal API doesn't exist in 15. We used both at the same time so it's fair to assume others might need to. IMO we should keep it for a release and warn.

[gaearon]

We used both at the same time so it's fair to assume others might need to.

That’s fair, agree.

[aweary]

@gaearon so is the actionable item here adding a warning for unstable_renderSubtreeIntoContainer?

[gaearon]

Let's wait for popular libs to update to portal API first. Will take a few months.

[yesmeck]

We use unstable_renderIntoContainer to implement rc-dialog, one feature is that when a dialog is unmounting, instead of calling unmountComponentAtNode, we call unstable_renderIntoContainer again to trigger a animation, after animation finished we call unmountComponentAtNode to clear the portal, see this example (check "destroy on close"). But this feature seems can't archive when using ReactDOM.createPortal, because the portal is unmount by React itself.

[gaearon]

@yesmeck Can you please file a new issue to discuss this use case?

[jquense]

That is an interesting use of the callback, very clever :) I think in the new API we should be able to handle this case the same way as other react components? E.g something like the react-transition-group Transition component.

[yesmeck]

I'v create a new issue #10826