Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5077bcc925aa6d0ba2ca4041c875d35e24f6266
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 63391b656a8d0c500a7981d1c907c72da4c0339b
Choose a head ref
  • 5 commits
  • 18 files changed
  • 1 contributor

Commits on Dec 17, 2024

  1. Add Feature Flag

    @sebmarkbage
    sebmarkbage committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    4d38745 View commit details
    Browse the repository at this point in the history

  2. Schedule passive effects using the regular ensureRootIsScheduled flow 

    This treats workInProgressRoot work and rootWithPendingPassiveEffects the same way.

Basically as long as there's some work on the root, yield the current task.
Including passive effects.
    @sebmarkbage
    sebmarkbage committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    20441b6 View commit details
    Browse the repository at this point in the history

  3. Update test split into two tasks 

    The ReactDOMSelect has an overlapping act error but I don't know why that wasn't erroring before.

I also don't get why waitFor isn't enough for useSubscription.

Nor why ReactExpiration changes. What does the additionalLogsAfterAttemptingToYield helper do?
    @sebmarkbage
    sebmarkbage committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    b516ab7 View commit details
    Browse the repository at this point in the history

  4. Disable in RN for now

    @sebmarkbage
    sebmarkbage committed Dec 17, 2024
    Configuration menu
    Copy the full SHA
    9b7be25 View commit details
    Browse the repository at this point in the history

  5. Merge 9b7be25 into f5077bc

    @sebmarkbage
    sebmarkbage authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    63391b6 View commit details
    Browse the repository at this point in the history
Loading