Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c5a733e1e3ffa74bc6bbc769f1b13ecff9915763
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fec5dd3634c37b3744eebbfe399d49c02aefbf7d
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Jun 6, 2018

  1. Always use event capturing. Remove media events. 

    This commit changes event subscription such that all events are
attached with capturing. This prevents the need to eagerly attach
media event listeners to video, audio, and source tags, and simplifies
the event subscription process.

I think we can probably extend this to more event types; requiring
much more testing. Until that time, this commit lays the foundation
for that work by demonstrating that capturing is applicable in cases
where bubbling does not occur.
    @nhunzaker
    nhunzaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    1655f4f View commit details
    Browse the repository at this point in the history

  2. Remove bubbled listener from EventListener-www.js

    @nhunzaker
    nhunzaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    3b74469 View commit details
    Browse the repository at this point in the history

  3. Add test case to cover proper capture/bubble order

    @nhunzaker
    nhunzaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    fec5dd3 View commit details
    Browse the repository at this point in the history
Loading