Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 952aa74f8e45ed35ac6bf1de10ad5ed5410deac6
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be76c13fd64f8d1a8020bdaf5a2224a5c6a0aa95
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 6, 2024

  1. Update ReactDOMServerSuspense-test to not use legacy rendering APIs 

    Updates ReactDOMServerSuspense-test to not use legacy rendering APIs. Previously this test was relying on suspending in the legacy renderer to throw during server rendering as well as during client rendering. With the advent of concurrent roots on the client however this doesn't make sense and it only makes sense on the server when using legacy apis like renderToString.

I have removed the use of ReactDOMServerIntegrationTestUtils in this test suite and limited the tests to server tests using renderToString to keep as much parity with what was being tested before while dropping anything that no longer makes sense to assert on concurrent client roots
    @gnoff
    gnoff committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    be76c13 View commit details
    Browse the repository at this point in the history
Loading