Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8b2d3783e58d1acea53428a10d2035a8399060fe
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e79b5287e73365c6119f698273ce4cb47c78d5a2
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 18, 2020

  1. Consolidate commit phase hook functions 

    There were a few pairs of commit phase functions that were almost
identical except for one detail. I've refactored them a bit to
consolidate their implementations:

- Lifted error handling logic when mounting a fiber's passive hook
effects to surround the entire list, instead of surrounding each effect.
- Lifted profiler duration tracking to surround the entire list.

In both cases, this matches the corresponding code for the layout phase.

The naming is still a bit of a mess but I'm not too concerned because
my next step is to refactor each commit sub-phase (layout, mutation)
so that we can store values on the JS stack. So the existing function
boundaries are about to change, anyway.
    @acdlite
    acdlite committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    e79b528 View commit details
    Browse the repository at this point in the history
Loading