Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72ebc703ac8abacd44fdeb1e3d66eb28b75e5a5b
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f09c2bfc1aa766d4af1e7fda19d075838a85cefa
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Jun 18, 2022

  1. Aborting early should not infinitely suspend 

    Before this change we weren't calling onError nor onFatalError if you abort
before completing the shell.

This means that the render never completes and hangs.

Aborting early can happen before even creating the stream for AbortSignal,
before rendering starts in Node since there's an setImmediate atm, or
during rendering.
    @sebmarkbage
    sebmarkbage committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    f09c2bf View commit details
    Browse the repository at this point in the history
Loading