-
Notifications
You must be signed in to change notification settings - Fork 47.3k
Comparing changes
Open a pull request
base repository: facebook/react
base: 6e9805c9e1f624bf3da37c81d770c4466a4bb5c1
head repository: facebook/react
compare: 4244ffaee06e64d81852980f534f9e185e0ca92f
- 18 commits
- 63 files changed
- 3 contributors
Commits on Jan 11, 2021
-
Fix ESLint crash on empty react effect hook (#20385)
* Fix ESLint crash on empty react effect hook * Add layout effect to test * Improve wording in comment * Improve lint warning wording * Reword missing effect callback message
Configuration menu - View commit details
-
Copy full SHA for e8eff11 - Browse repository at this point
Copy the full SHA e8eff11View commit details
Commits on Jan 12, 2021
-
Build stable and experimental with same command (#20573)
The goal is to simplify our CI pipeline so that all configurations are built and tested in a single workflow. As a first step, this adds a new build script entry point that builds both the experimental and stable release channels into a single artifacts directory. The script works by wrapping the existing build script (which only builds a single release channel at a time), then post-processing the results to match the desired filesystem layout. A future version of the build script would output the files directly without post-processing. Because many parts of our infra depend on the existing layout of the build artifacts directory, I have left the old workflows untouched. We can incremental migrate to the new layout, then delete the old workflows after we've finished.
Configuration menu - View commit details
-
Copy full SHA for eb0fb38 - Browse repository at this point
Copy the full SHA eb0fb38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a6a41d - Browse repository at this point
Copy the full SHA 9a6a41dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b99ac3d - Browse repository at this point
Copy the full SHA b99ac3dView commit details
Commits on Jan 13, 2021
-
Update package.json versions as part of build step (#20579)
Fixes issue in the new build workflow where the experimental packages do not include "experimental" in the version string. This was because the previous approach relied on the RELEASE_CHANNEL environment variable, which we are no longer setting in the outer CI job, since we use the same job to build both channels. To solve, I moved the version post-processing into the build script itself. Only affects the new build workflow. Old workflow is unchanged. Longer term, I would like to remove version numbers from the source entirely, including the package.jsons. We should use a placeholder instead; that's mostly how it already works, since the release script swaps out the versions before we publish to stable.
Configuration menu - View commit details
-
Copy full SHA for e6ed2bc - Browse repository at this point
Copy the full SHA e6ed2bcView commit details -
Retry with fresh otp if publish fails (#20582)
Currently, if publishing a package fails, the script crashes, and the user must start it again from the beginning. Usually this happens because the one-time password has timed out. With this change, the user will be prompted for a fresh otp, and the script will resume publishing.
Configuration menu - View commit details
-
Copy full SHA for fc07b07 - Browse repository at this point
Copy the full SHA fc07b07View commit details
Commits on Jan 14, 2021
-
Deletion effects should fire parent -> child (#20584)
* Test: Deletion effects should fire parent -> child Regression in new effect implementation * Fix passive deletion effect ordering
Configuration menu - View commit details
-
Copy full SHA for a656ace - Browse repository at this point
Copy the full SHA a656aceView commit details -
Fix: Detach deleted fiber's alternate, too (#20587)
We need to call `detachFiberAfterEffects` on the fiber's alternate to clean it up. We're currently not, because the `alternate` field is cleared during `detachFiberMutation`. So I deferred detaching the `alternate` until the passive phase. Only the `return` pointer needs to be detached for semantic purposes. I don't think there's any good way to test this without using reflection. It's not even observable using out our "supported" reflection APIs (`findDOMNode`), or at least not that I can think of. Which is a good thing, in a way. It's not really a memory leak, either, because the only reference to the alternate fiber is from the parent's alternate. Which will be disconnected the next time the parent is updated or deleted. It's really only observable if you mess around with internals in ways you're not supposed to — I found it because a product test in www that uses Enzyme was doing just that. In lieu of a new unit test, I confirmed this patch fixes the broken product test.
Configuration menu - View commit details
-
Copy full SHA for 42e04b4 - Browse repository at this point
Copy the full SHA 42e04b4View commit details -
Migrate prepare-release-from-ci to new workflow (#20581)
* Migrate prepare-release-from-ci to new workflow I added a `--releaseChannel (-r)` argument to script. You must choose either "stable" or "experimental", because every build job now includes both channels. The prepare-release-from-npm script is unchanged since those releases are downloaded from npm, nt CI. (As a side note, I think we should start preparing semver releases using the prepare-release-from-ci script, too, and get rid of prepare-release-from-npm. I think that was a neat idea originally but because we already run `npm pack` before storing the artifacts in CI, there's really not much additional safety; the only safeguard it adds is the requirement that a "next" release must have already been published.) * Move validation to parse-params module
Configuration menu - View commit details
-
Copy full SHA for 98313aa - Browse repository at this point
Copy the full SHA 98313aaView commit details
Commits on Jan 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6132919 - Browse repository at this point
Copy the full SHA 6132919View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95feb0e - Browse repository at this point
Copy the full SHA 95feb0eView commit details -
DevTools: Replace legacy Suspense cache with unstable_getCacheForType
Brian Vaughn committedJan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 61663af - Browse repository at this point
Copy the full SHA 61663afView commit details -
Enable cache for EXPIREMENTAL test renderer builds
Brian Vaughn committedJan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 084a2b0 - Browse repository at this point
Copy the full SHA 084a2b0View commit details -
Removed duplicate inspected element from local state
Brian Vaughn committedJan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 13f2b53 - Browse repository at this point
Copy the full SHA 13f2b53View commit details -
Update backend/frontend API to be more compatible with typical Suspen…
…se cache usage
Brian Vaughn committedJan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 00763a0 - Browse repository at this point
Copy the full SHA 00763a0View commit details -
Brian Vaughn committed
Jan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 373e54e - Browse repository at this point
Copy the full SHA 373e54eView commit details -
Brian Vaughn committed
Jan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 9fd6735 - Browse repository at this point
Copy the full SHA 9fd6735View commit details -
Fixed last test but with an unsatisfying solution
Brian Vaughn committedJan 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 4244ffa - Browse repository at this point
Copy the full SHA 4244ffaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6e9805c9e1f624bf3da37c81d770c4466a4bb5c1...4244ffaee06e64d81852980f534f9e185e0ca92f