Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5d19e1c8d1a6c0b5cd7532d43b707191eaf105b7
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9dd6563770b74baae276f90e0d24b5e6938c63fc
Choose a head ref
  • 6 commits
  • 3 files changed
  • 1 contributor

Commits on Sep 23, 2024

  1. Handle owner and stack when resolving partially deduped elements 

    This is a follow-up from #30528 to not only handle props (the critical
change), but also the owner and stack of a referenced element.

Handling stacks here is rather academic because the Flight Server
currently does not deduplicate owner stacks. And if they are really
identical, we should probably just dedupe the whole element.
    @unstubbable
    unstubbable committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    68886e8 View commit details
    Browse the repository at this point in the history

  2. Add a unit test for deduped owner objects 

    Repro from vercel/next.js#69545
    @unstubbable
    unstubbable committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8fea0ca View commit details
    Browse the repository at this point in the history

  3. Remove debug stack dedupe handling (not needed)

    @unstubbable
    unstubbable committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3f9a7c3 View commit details
    Browse the repository at this point in the history

  4. Add expectation to verify react flight client change 

    Previously, the test only covered the change in the react flight server.
    @unstubbable
    unstubbable committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3a8b1ca View commit details
    Browse the repository at this point in the history

  5. Fix typo in comment

    @unstubbable
    unstubbable committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f4c2115 View commit details
    Browse the repository at this point in the history

  6. Merge f4c2115 into 5d19e1c

    @unstubbable
    unstubbable authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9dd6563 View commit details
    Browse the repository at this point in the history
Loading