Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5d19e1c8
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 778e1ed2
Choose a head ref
  • 12 commits
  • 37 files changed
  • 7 contributors

Commits on Sep 23, 2024

  1. [Fiber] Log the Render/Commit phases and the gaps in between (#31016)

    A slight behavior change here too is that I now mark the start of the
    commit phase before the BeforeMutationEffect phase. This affects
    `<Profiler>` too.
    
    The named sequences are as follows:
    
    Render -> Suspended or Throttled -> Commit -> Waiting for Paint ->
    Remaining Effects
    
    The Suspended phase is only logged if we delay the Commit due to CSS /
    images.
    
    The Throttled phase is only logged if we delay the commit due to the
    Suspense throttling timer.
    
    <img width="1246" alt="Screenshot 2024-09-20 at 9 14 23 PM"
    src="https://github.com/user-attachments/assets/8d01f444-bb85-472b-9b42-6157d92c81b4">
    
    I don't yet log render phases that don't complete. I think I also need
    to special case renders that or don't commit after being suspended.
    sebmarkbage authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4e9540e View commit details
    Browse the repository at this point in the history
  2. Fix missing trailing / in commit artifacts workflow

    The trailing / was being omitted, so instead of moving the cjs
    directory itself, it would move only its contents instead. This broke
    some internal path assumptions.
    
    Additionally, updates the step to create the react-dom directory prior
    to moving.
    
    ghstack-source-id: b6eedb0
    Pull Request resolved: #31026
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    79bcf6e View commit details
    Browse the repository at this point in the history
  3. Allow forcing a build in artifacts workflow dispatch

    Sometimes it is useful to bypass the revision check when we need to make
    changes to the runtime_commit_artifacts script. The `force` input can be
    passed via the GitHub UI for manual runs of the workflow.
    
    ghstack-source-id: cf9e32c
    Pull Request resolved: #31027
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5b19dc0 View commit details
    Browse the repository at this point in the history
  4. Fix runtime_commit_artifacts workflow

    I messed up the yml syntax and also realized that our script doesn't
    currently handle renames or deletes, so I fixed that
    
    ghstack-source-id: 7d481a9
    Pull Request resolved: #31028
    poteto committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4708fb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Resolve references to deduped owner objects (#30549)

    This is a follow-up from #30528 to not only handle props (the critical
    change), but also the owner ~and stack~ of a referenced element.
    
    ~Handling stacks here is rather academic because the Flight Server
    currently does not deduplicate owner stacks. And if they are really
    identical, we should probably just dedupe the whole element.~ EDIT:
    Removed from the PR.
    
    Handling owner objects on the other hand is an actual requirement as
    reported in vercel/next.js#69545. This problem
    only affects the stable release channel, as the absence of owner stacks
    allows for the specific kind of shared owner deduping as demonstrated in
    the unit test.
    unstubbable authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    04bd67a View commit details
    Browse the repository at this point in the history
  2. fix: consider alternate as a key for componentLogsEntry when inspecti…

    …ng raw fiber instance (#31009)
    
    Related - #30899.
    
    Looks like this was missed. We actually do this when we record errors
    and warnings before sending them via Bridge:
    
    https://github.com/facebook/react/blob/e4953922a99b5477c3bcf98cdaa2b13ac0a81f0d/packages/react-devtools-shared/src/backend/fiber/renderer.js#L2169-L2173
    
    So, what is happening in the end, errors or warnings are displayed in
    the Tree, but when user clicks on the component, nothing is shown,
    because `fiberToComponentLogsMap` has only `alternate` as a key.
    hoxyq authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fc4a33e View commit details
    Browse the repository at this point in the history
  3. refactor: data source for errors and warnings tracking is now in Store (

    #31010)
    
    Stacked on #31009.
    
    1. Instead of keeping `showInlineWarningsAndErrors` in `Settings`
    context (which was removed in
    #30610), `Store` will now have a
    boolean flag, which controls if the UI should be displaying information
    about errors and warnings.
    2. The errors and warnings counters in the Tree view are now counting
    only unique errors. This makes more sense, because it is part of the
    Elements Tree view, so ideally it should be showing number of components
    with errors and number of components of warnings. Consider this example:
    2.1. Warning for element `A` was emitted once and warning for element
    `B` was emitted twice.
    2.2. With previous implementation, we would show `3 ⚠️`, because in
    total there were 3 warnings in total. If user tries to iterate through
    these, it will only take 2 steps to do the full cycle, because there are
    only 2 elements with warnings (with one having same warning, which was
    emitted twice).
    2.3 With current implementation, we would show `2 ⚠️`. Inspecting the
    element with doubled warning will still show the warning counter (2)
    before the warning message.
    
    With these changes, the feature correctly works.
    https://fburl.com/a7fw92m4
    hoxyq authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a15bbe1 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. React DevTools 5.3.1 -> 6.0.0 (#31058)

    Full list of changes:
    * refactor: data source for errors and warnings tracking is now in Store
    ([hoxyq](https://github.com/hoxyq) in
    [#31010](#31010))
    * fix: consider alternate as a key for componentLogsEntry when
    inspecting raw fiber instance ([hoxyq](https://github.com/hoxyq) in
    [#31009](#31009))
    * Fix: profiling crashes #30661 #28838
    ([EdmondChuiHW](https://github.com/EdmondChuiHW) in
    [#31024](#31024))
    * chore: remove using local storage for persisting console settings on
    the frontend ([hoxyq](https://github.com/hoxyq) in
    [#31002](#31002))
    * feat: display message if user ended up opening hook script
    ([hoxyq](https://github.com/hoxyq) in
    [#31000](#31000))
    * feat: expose installHook with settings argument from
    react-devtools-core/backend ([hoxyq](https://github.com/hoxyq) in
    [#30987](#30987))
    * chore: remove settings manager from react-devtools-core
    ([hoxyq](https://github.com/hoxyq) in
    [#30986](#30986))
    * feat[react-devtools/extension]: use chrome.storage to persist settings
    across sessions ([hoxyq](https://github.com/hoxyq) in
    [#30636](#30636))
    * refactor[react-devtools]: propagate settings from global hook object
    to frontend ([hoxyq](https://github.com/hoxyq) in
    [#30610](#30610))
    * chore[react-devtools]: extract some utils into separate modules to
    unify implementations ([hoxyq](https://github.com/hoxyq) in
    [#30597](#30597))
    * refactor[react-devtools]: move console patching to global hook
    ([hoxyq](https://github.com/hoxyq) in
    [#30596](#30596))
    * refactor[react-devtools]: remove browserTheme from
    ConsolePatchSettings ([hoxyq](https://github.com/hoxyq) in
    [#30566](#30566))
    * feat[react-devtools]: add settings to global hook object
    ([hoxyq](https://github.com/hoxyq) in
    [#30564](#30564))
    * fix: add Error prefix to Error objects names
    ([hoxyq](https://github.com/hoxyq) in
    [#30969](#30969))
    * Add enableComponentPerformanceTrack Flag
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30960](#30960))
    * fix[rdt/fiber/renderer.js]: getCurrentFiber can be injected as null
    ([hoxyq](https://github.com/hoxyq) in
    [#30968](#30968))
    * disable `enableSiblingPrerendering` in experimental channel
    ([gnoff](https://github.com/gnoff) in
    [#30952](#30952))
    * refactor[react-devtools]: initialize renderer interface early
    ([hoxyq](https://github.com/hoxyq) in
    [#30946](#30946))
    * Start prerendering Suspense retries immediately
    ([acdlite](https://github.com/acdlite) in
    [#30934](#30934))
    * refactor[Agent/Store]: Store to send messages only after Agent is
    initialized ([hoxyq](https://github.com/hoxyq) in
    [#30945](#30945))
    * refactor[RendererInterface]: expose onErrorOrWarning and
    getComponentStack ([hoxyq](https://github.com/hoxyq) in
    [#30931](#30931))
    * Implement getComponentStack and onErrorOrWarning for replayed Flight
    logs ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30930](#30930))
    * Use Unicode Atom Symbol instead of Atom Emoji
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30832](#30832))
    * Improve Layering Between Console and Renderer
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30925](#30925))
    * Add Map for Server Component Logs
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30905](#30905))
    * Delete fiberToFiberInstanceMap
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30900](#30900))
    * Add Flight Renderer ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30906](#30906))
    * Refactor Error / Warning Count Tracking
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30899](#30899))
    * [flow] Upgrade Flow to 0.245.2
    ([SamChou19815](https://github.com/SamChou19815) in
    [#30919](#30919))
    * Separate RDT Fusebox into single-panel entry points
    ([huntie](https://github.com/huntie) in
    [#30708](#30708))
    * Build Updater List from the Commit instead of Map
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30897](#30897))
    * Simplify Context Change Tracking in Profiler
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30896](#30896))
    * Remove use of .alternate in root and recordProfilingDurations
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30895](#30895))
    * Handle reordered contexts in Profiler
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30887](#30887))
    * Refactor Forcing Fallback / Error of Suspense / Error Boundaries
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30870](#30870))
    * Avoid getFiberIDUnsafe in debug() Helper
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30878](#30878))
    * Include some Filtered Fiber Instances
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30865](#30865))
    * Track root instances in a root Map
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30875](#30875))
    * Track all public HostInstances in a Map
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30831](#30831))
    * Support VirtualInstances in findAllCurrentHostInstances
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30853](#30853))
    * Add Filtering of Environment Names
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30850](#30850))
    * Support secondary environment name when it changes
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30842](#30842))
    * Increase max payload for websocket in standalone app
    ([runeb](https://github.com/runeb) in
    [#30848](#30848))
    * Filter Server Components
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30839](#30839))
    * Track virtual instances on the tracked path for selections
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30802](#30802))
    * Remove displayName from inspected data
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30841](#30841))
    * chore[react-devtools/hook]: remove unused native values
    ([hoxyq](https://github.com/hoxyq) in
    [#30827](#30827))
    * chore[react-devtools/extensions]: remove unused storage permission
    ([hoxyq](https://github.com/hoxyq) in
    [#30826](#30826))
    * fix[react-devtools/extensions]: fixed tabs API calls and displaying
    restricted access popup ([hoxyq](https://github.com/hoxyq) in
    [#30825](#30825))
    * feat[react-devtools]: support Manifest v3 for Firefox extension
    ([hoxyq](https://github.com/hoxyq) in
    [#30824](#30824))
    * Reconcile Fibers Against Previous Children Instances
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30822](#30822))
    * Remove findCurrentFiberUsingSlowPathByFiberInstance
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30818](#30818))
    * Track Tree Base Duration of Virtual Instances
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30817](#30817))
    * Use Owner Stacks to Implement View Source of a Server Component
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30798](#30798))
    * Make function inspection instant
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30786](#30786))
    * Make Functions Clickable to Jump to Definition
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30769](#30769))
    * Support REACT_LEGACY_ELEMENT_TYPE for formatting JSX
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30779](#30779))
    * Find owners from the parent path that matches the Fiber or
    ReactComponentInfo ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30717](#30717))
    * [Flight/DevTools] Pass the Server Component's "key" as Part of the
    ReactComponentInfo ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30703](#30703))
    * Hide props section if it is null
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30696](#30696))
    * Support Server Components in Tree
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30684](#30684))
    * fix[react-devtools/InspectedElement]: fixed border stylings when some
    of the panels are not rendered ([hoxyq](https://github.com/hoxyq) in
    [#30676](#30676))
    * Compute new reordered child set from the instance tree
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30668](#30668))
    * Unmount instance by walking the instance tree instead of the fiber
    tree ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30665](#30665))
    * Further Refactoring of Unmounts
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30658](#30658))
    * Remove lodash.throttle ([sebmarkbage](https://github.com/sebmarkbage)
    in [#30657](#30657))
    * Unmount by walking previous nodes no longer in the new tree
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30644](#30644))
    * Build up DevTools Instance Shadow Tree
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30625](#30625))
    * chore[packages/react-devtools]: remove unused index.js
    ([hoxyq](https://github.com/hoxyq) in
    [#30579](#30579))
    * Track DOM nodes to Fiber map for HostHoistable Resources
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30590](#30590))
    * Rename mountFiberRecursively/updateFiberRecursively
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30586](#30586))
    * Allow Highlighting/Inspect HostSingletons/Hoistables and Resources
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30584](#30584))
    * chore[react-devtools]: add global for native and use it to fork
    backend implementation ([hoxyq](https://github.com/hoxyq) in
    [#30533](#30533))
    * Enable pointEvents while scrolling
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30560](#30560))
    * Make Element Inspection Feel Snappy
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30555](#30555))
    * Track the parent DevToolsInstance while mounting a tree
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30542](#30542))
    * Add DevToolsInstance to Store Stateful Information
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30517](#30517))
    * Implement "best renderer" by taking the inner most matched node
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30494](#30494))
    * Rename NativeElement to HostInstance in the Bridge
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30491](#30491))
    * Rename Fiber to Element in the Bridge Protocol and RendererInterface
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30490](#30490))
    * Stop filtering owner stacks
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30438](#30438))
    * [Fiber] Call life-cycles with a react-stack-bottom-frame stack frame
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30429](#30429))
    * [Flight] Prefix owner stacks added to the console.log with the current
    stack ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30427](#30427))
    * [BE] switch to hermes parser for prettier
    ([kassens](https://github.com/kassens) in
    [#30421](#30421))
    * Implement Owner Stacks ([sebmarkbage](https://github.com/sebmarkbage)
    in [#30417](#30417))
    * [BE] upgrade prettier to 3.3.3 ([kassens](https://github.com/kassens)
    in [#30420](#30420))
    * [ci] Add yarn_test_build job to gh actions
    * [Fizz] Refactor Component Stack Nodes
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30298](#30298))
    * Print component stacks as error objects to get source mapping
    ([sebmarkbage](https://github.com/sebmarkbage) in
    [#30289](#30289))
    * Upgrade flow to 0.235.0 ([kassens](https://github.com/kassens) in
    [#30118](#30118))
    * fix: path handling in react devtools
    ([Jack-Works](https://github.com/Jack-Works) in
    [#29199](#29199))
    hoxyq authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d2e9b9b View commit details
    Browse the repository at this point in the history
  2. Increase nested update limit to 100 (#31061)

    We're seeing the limit hit in some tests after enabling sibling
    prerendering. Let's bump the limit so we can run more tests and gather
    more signal on the changes. When we understand the scope of the problem
    we can determine whether we need to change how the updates are counted
    in prerenders and/or fix specific areas of product code.
    jackpope authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f9ebd85 View commit details
    Browse the repository at this point in the history
  3. Unify perform{Sync,Concurrent}WorkOnRoot implementation (#31029)

    Over time the behavior of these two paths has converged to be
    essentially the same. So this merges them back into one function. This
    should save some code size and also make it harder for the behavior to
    accidentally diverge. (For the same reason, rolling out this change
    might expose some areas where we had already accidentally diverged.)
    acdlite authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3c7667a View commit details
    Browse the repository at this point in the history
  4. Make prerendering always non-blocking (#31056)

    When a synchronous update suspends, and we prerender the siblings, the
    prerendering should be non-blocking so that we can immediately restart
    once the data arrives.
    
    This happens automatically when there's a Suspense boundary, because we
    immediately commit the boundary and then proceed to a Retry render,
    which are always concurrent. When there's not a Suspense boundary, there
    is no Retry, so we need to take care to switch from the synchronous work
    loop to the concurrent one, to enable time slicing.
    acdlite authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0f1856c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    778e1ed View commit details
    Browse the repository at this point in the history
Loading