Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3ce77d55a205065714fcf4b0533a4ac6d009992b
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7adb0b253287be4c4f0e4845be32331f8b21e3bb
Choose a head ref
  • 13 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 6, 2025

  1. Add missing flag check

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    8c2fa93 View commit details
    Browse the repository at this point in the history

  2. Use module scope to pass arguments to mutation and layout effects 

    In the same way we already do for passive effects.
    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    8216803 View commit details
    Browse the repository at this point in the history

  3. Use status field instead of root to check the status of the commit

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    4a93883 View commit details
    Browse the repository at this point in the history

  4. Drop the Passive since it's now includes other effects too

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    d7fa2c1 View commit details
    Browse the repository at this point in the history

  5. Pass root through the module scope as well

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    65337a2 View commit details
    Browse the repository at this point in the history

  6. Rename flushPassiveEffects to flushPendingEffects 

    This wrapper flushes any remaining effects.
    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    eb68734 View commit details
    Browse the repository at this point in the history

  7. Fix wasDelayedCommit in enableYieldingBeforePassive flag 

    When we flush from a task, we've yielded to paint.
This only matters for performance.measure.
    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    c24399a View commit details
    Browse the repository at this point in the history

  8. Defer work scheduler work if we're inside a pending commit

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    e8e7229 View commit details
    Browse the repository at this point in the history

  9. Check status inside each flush so it's safe to call them individually

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    d6e7180 View commit details
    Browse the repository at this point in the history

  10. Flush only passive in the callback

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    182d1aa View commit details
    Browse the repository at this point in the history

  11. Remove stale comment

    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    c89b6b3 View commit details
    Browse the repository at this point in the history

  12. Clear effects in case we throw from React 

    That way we don't get stuck.
    @sebmarkbage
    sebmarkbage committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    424f0dd View commit details
    Browse the repository at this point in the history

  13. Merge 424f0dd into 3ce77d5

    @sebmarkbage
    sebmarkbage authored Jan 6, 2025
    Configuration menu
    Copy the full SHA
    7adb0b2 View commit details
    Browse the repository at this point in the history
Loading