Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1528c5ccdf5c61a08adab31116156df6503e26ce
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bb38ccd1c954566ea4f0addb975480e7f832370a
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 6, 2023

  1. Move suspended render logic to ensureRootIsScheduled 

    When the work loop is suspended, we shouldn't schedule a new render task
until the promise has resolved. When I originally implemented this, I
wasn't sure where to put this logic — `ensureRootIsScheduled` is the
more natural place for it, but that's also a really hot path, so I chose
to do it elsewhere, and left a TODO to reconsider later.

Now it's later. I'm working on a refactor to move the
`ensureRootIsScheduled` call to always happen in a microtask, so that if
there are multiple updates/pings in a single event, they get batched
into a single operation. Which means I can put the logic in that
function where it belongs.
    @acdlite
    acdlite committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    bb38ccd View commit details
    Browse the repository at this point in the history
Loading