Skip to content

Commit ff47b9e

Browse files
committed
ci (eslint-e2e): exclude nested node_modules from cache
This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens.
1 parent 077a4b0 commit ff47b9e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/runtime_eslint_plugin_e2e.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ jobs:
4040
uses: actions/cache@v4
4141
id: node_modules
4242
with:
43-
path: "**/node_modules"
43+
path: "node_modules"
4444
key: runtime-eslint_e2e-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
4545
- name: Ensure clean build directory
4646
run: rm -rf build
47-
- run: yarn install --frozen-lockfile
47+
- run: yarn install
4848
- name: Build plugin
4949
working-directory: fixtures/eslint-v${{ matrix.eslint_major }}
5050
run: node build.mjs

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,9 @@ const rule = {
184184
// Get the current scope.
185185
const scope = scopeManager.acquire(node);
186186
if (!scope) {
187-
throw new Error('Unable to acquire scope for the current node.');
187+
throw new Error(
188+
'Unable to acquire scope for the current node. This is a bug in eslint-plugin-react-hooks, please file an issue.',
189+
);
188190
}
189191

190192
// Find all our "pure scopes". On every re-render of a component these

0 commit comments

Comments
 (0)