Skip to content

Commit ff1f53f

Browse files
sebmarkbagesebmarkbage
committed
Warn for useFormState on initial render (#30292)
This was missed in the mount dev dispatcher. It was only in the rerender dispatcher which means that it was only logged during the rerender. Since DevTools can hide logs during rerenders, this hid the warning in StrictMode. DiffTrain build for commit 274c980.
1 parent e99785f commit ff1f53f

File tree

14 files changed

+44
-41
lines changed

14 files changed

+44
-41
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-df783f9ea1-20240708
1+
19.0.0-native-fb-274c980c53-20240708

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b79bb3a4890e5e05b0b98d095f5ec6a9>>
10+
* @generated SignedSource<<406a88d1a4fab2a1a30035ac1866b4c5>>
1111
*/
1212

1313
"use strict";
@@ -13722,6 +13722,7 @@ __DEV__ &&
1372213722
HooksDispatcherOnMountInDEV.useFormState = function (action, initialState) {
1372313723
currentHookNameInDev = "useFormState";
1372413724
mountHookTypesDev();
13725+
warnOnUseFormStateInDev();
1372513726
return mountActionState(action, initialState);
1372613727
};
1372713728
HooksDispatcherOnMountInDEV.useActionState = function (
@@ -15079,14 +15080,14 @@ __DEV__ &&
1507915080
scheduleRoot: scheduleRoot,
1508015081
setRefreshHandler: setRefreshHandler,
1508115082
getCurrentFiber: getCurrentFiberForDevTools,
15082-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
15083+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1508315084
});
1508415085
})({
1508515086
findFiberByHostInstance: function () {
1508615087
throw Error("TestRenderer does not support findFiberByHostInstance()");
1508715088
},
1508815089
bundleType: 1,
15089-
version: "19.0.0-native-fb-df783f9ea1-20240708",
15090+
version: "19.0.0-native-fb-274c980c53-20240708",
1509015091
rendererPackageName: "react-test-renderer"
1509115092
});
1509215093
exports._Scheduler = Scheduler;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9dcd7685e1640c17fbdf82a52a452035>>
10+
* @generated SignedSource<<e5832359bed54301755c310c71ed4199>>
1111
*/
1212

1313
"use strict";
@@ -9384,7 +9384,7 @@ var devToolsConfig$jscomp$inline_1053 = {
93849384
throw Error("TestRenderer does not support findFiberByHostInstance()");
93859385
},
93869386
bundleType: 0,
9387-
version: "19.0.0-native-fb-df783f9ea1-20240708",
9387+
version: "19.0.0-native-fb-274c980c53-20240708",
93889388
rendererPackageName: "react-test-renderer"
93899389
};
93909390
var internals$jscomp$inline_1240 = {
@@ -9415,7 +9415,7 @@ var internals$jscomp$inline_1240 = {
94159415
scheduleRoot: null,
94169416
setRefreshHandler: null,
94179417
getCurrentFiber: null,
9418-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
9418+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
94199419
};
94209420
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94219421
var hook$jscomp$inline_1241 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<661fb6132400bc6cbf49596db0acc720>>
10+
* @generated SignedSource<<919306dbc91ada1359ea3c6b0b32c618>>
1111
*/
1212

1313
"use strict";
@@ -10004,7 +10004,7 @@ var devToolsConfig$jscomp$inline_1136 = {
1000410004
throw Error("TestRenderer does not support findFiberByHostInstance()");
1000510005
},
1000610006
bundleType: 0,
10007-
version: "19.0.0-native-fb-df783f9ea1-20240708",
10007+
version: "19.0.0-native-fb-274c980c53-20240708",
1000810008
rendererPackageName: "react-test-renderer"
1000910009
};
1001010010
(function (internals) {
@@ -10048,7 +10048,7 @@ var devToolsConfig$jscomp$inline_1136 = {
1004810048
scheduleRoot: null,
1004910049
setRefreshHandler: null,
1005010050
getCurrentFiber: null,
10051-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
10051+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1005210052
});
1005310053
exports._Scheduler = Scheduler;
1005410054
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<eee457cdc760bc83f6841edabd786565>>
10+
* @generated SignedSource<<3787381ad3f2eac13a1287257e1acce9>>
1111
*/
1212

1313
"use strict";
@@ -1748,7 +1748,7 @@ __DEV__ &&
17481748
exports.useTransition = function () {
17491749
return resolveDispatcher().useTransition();
17501750
};
1751-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
1751+
exports.version = "19.0.0-native-fb-274c980c53-20240708";
17521752
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17531753
"function" ===
17541754
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7c12730813cc8752d34681669dee99a2>>
10+
* @generated SignedSource<<35b776e96f5f1727760c923395a99766>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
607+
exports.version = "19.0.0-native-fb-274c980c53-20240708";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<157ac3b6e8ae340940bc85ec2c3806cc>>
10+
* @generated SignedSource<<1b02bac183a08adfa82d1581390cdd01>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
611+
exports.version = "19.0.0-native-fb-274c980c53-20240708";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
df783f9ea1b6f95e05f830602da1de5ffb325d30
1+
274c980c535bb34e17f5d97cc22ef4dd296ab413

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cb3e48516a63e1d432c10d2a36d40a98>>
10+
* @generated SignedSource<<8f233b6d522b2bcef18aa23caa2b608c>>
1111
*/
1212

1313
"use strict";
@@ -15432,6 +15432,7 @@ __DEV__ &&
1543215432
HooksDispatcherOnMountInDEV.useFormState = function (action, initialState) {
1543315433
currentHookNameInDev = "useFormState";
1543415434
mountHookTypesDev();
15435+
warnOnUseFormStateInDev();
1543515436
return mountActionState(action, initialState);
1543615437
};
1543715438
HooksDispatcherOnMountInDEV.useActionState = function (
@@ -16686,12 +16687,12 @@ __DEV__ &&
1668616687
scheduleRoot: scheduleRoot,
1668716688
setRefreshHandler: setRefreshHandler,
1668816689
getCurrentFiber: getCurrentFiberForDevTools,
16689-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
16690+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1669016691
});
1669116692
})({
1669216693
findFiberByHostInstance: getInstanceFromNode,
1669316694
bundleType: 1,
16694-
version: "19.0.0-native-fb-df783f9ea1-20240708",
16695+
version: "19.0.0-native-fb-274c980c53-20240708",
1669516696
rendererPackageName: "react-native-renderer",
1669616697
rendererConfig: {
1669716698
getInspectorDataForInstance: getInspectorDataForInstance,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bf8cd3f7673a3494d679c3432fe18b20>>
10+
* @generated SignedSource<<6f6cef3e69da66fa484d591f777702cb>>
1111
*/
1212

1313
"use strict";
@@ -10601,7 +10601,7 @@ var roots = new Map(),
1060110601
devToolsConfig$jscomp$inline_1136 = {
1060210602
findFiberByHostInstance: getInstanceFromNode,
1060310603
bundleType: 0,
10604-
version: "19.0.0-native-fb-df783f9ea1-20240708",
10604+
version: "19.0.0-native-fb-274c980c53-20240708",
1060510605
rendererPackageName: "react-native-renderer",
1060610606
rendererConfig: {
1060710607
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10644,7 +10644,7 @@ var internals$jscomp$inline_1362 = {
1064410644
scheduleRoot: null,
1064510645
setRefreshHandler: null,
1064610646
getCurrentFiber: null,
10647-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
10647+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1064810648
};
1064910649
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1065010650
var hook$jscomp$inline_1363 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7a2d2c38e9e972f0fdb209afc217198b>>
10+
* @generated SignedSource<<08e9aaca9ad2b99e51f08d8dc61d33e4>>
1111
*/
1212

1313
"use strict";
@@ -11307,7 +11307,7 @@ var roots = new Map(),
1130711307
devToolsConfig$jscomp$inline_1217 = {
1130811308
findFiberByHostInstance: getInstanceFromNode,
1130911309
bundleType: 0,
11310-
version: "19.0.0-native-fb-df783f9ea1-20240708",
11310+
version: "19.0.0-native-fb-274c980c53-20240708",
1131111311
rendererPackageName: "react-native-renderer",
1131211312
rendererConfig: {
1131311313
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11363,7 +11363,7 @@ var roots = new Map(),
1136311363
scheduleRoot: null,
1136411364
setRefreshHandler: null,
1136511365
getCurrentFiber: null,
11366-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
11366+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1136711367
});
1136811368
exports.createPortal = function (children, containerTag) {
1136911369
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<10ecfca0d7c38d9b16345cadd1a04f79>>
10+
* @generated SignedSource<<969999f0d202ee723f8948c461929937>>
1111
*/
1212

1313
"use strict";
@@ -15664,6 +15664,7 @@ __DEV__ &&
1566415664
HooksDispatcherOnMountInDEV.useFormState = function (action, initialState) {
1566515665
currentHookNameInDev = "useFormState";
1566615666
mountHookTypesDev();
15667+
warnOnUseFormStateInDev();
1566715668
return mountActionState(action, initialState);
1566815669
};
1566915670
HooksDispatcherOnMountInDEV.useActionState = function (
@@ -16874,11 +16875,11 @@ __DEV__ &&
1687416875
var emptyObject = {};
1687516876
Object.freeze(emptyObject);
1687616877
var isomorphicReactPackageVersion = React.version;
16877-
if ("19.0.0-native-fb-df783f9ea1-20240708" !== isomorphicReactPackageVersion)
16878+
if ("19.0.0-native-fb-274c980c53-20240708" !== isomorphicReactPackageVersion)
1687816879
throw Error(
1687916880
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1688016881
(isomorphicReactPackageVersion +
16881-
"\n - react-native-renderer: 19.0.0-native-fb-df783f9ea1-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
16882+
"\n - react-native-renderer: 19.0.0-native-fb-274c980c53-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
1688216883
);
1688316884
if (
1688416885
"function" !==
@@ -16926,12 +16927,12 @@ __DEV__ &&
1692616927
scheduleRoot: scheduleRoot,
1692716928
setRefreshHandler: setRefreshHandler,
1692816929
getCurrentFiber: getCurrentFiberForDevTools,
16929-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
16930+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1693016931
});
1693116932
})({
1693216933
findFiberByHostInstance: getInstanceFromTag,
1693316934
bundleType: 1,
16934-
version: "19.0.0-native-fb-df783f9ea1-20240708",
16935+
version: "19.0.0-native-fb-274c980c53-20240708",
1693516936
rendererPackageName: "react-native-renderer",
1693616937
rendererConfig: {
1693716938
getInspectorDataForInstance: getInspectorDataForInstance,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<20445ebee951182a5c4c0efc7124a273>>
10+
* @generated SignedSource<<22f86bde09af5f4baa1bc50a71e3ea2b>>
1111
*/
1212

1313
"use strict";
@@ -10755,11 +10755,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1075510755
traverseOwnerTreeUp(hierarchy, instance);
1075610756
}
1075710757
var isomorphicReactPackageVersion = React.version;
10758-
if ("19.0.0-native-fb-df783f9ea1-20240708" !== isomorphicReactPackageVersion)
10758+
if ("19.0.0-native-fb-274c980c53-20240708" !== isomorphicReactPackageVersion)
1075910759
throw Error(
1076010760
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1076110761
(isomorphicReactPackageVersion +
10762-
"\n - react-native-renderer: 19.0.0-native-fb-df783f9ea1-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
10762+
"\n - react-native-renderer: 19.0.0-native-fb-274c980c53-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
1076310763
);
1076410764
if (
1076510765
"function" !==
@@ -10809,7 +10809,7 @@ var roots = new Map(),
1080910809
devToolsConfig$jscomp$inline_1210 = {
1081010810
findFiberByHostInstance: getInstanceFromTag,
1081110811
bundleType: 0,
10812-
version: "19.0.0-native-fb-df783f9ea1-20240708",
10812+
version: "19.0.0-native-fb-274c980c53-20240708",
1081310813
rendererPackageName: "react-native-renderer",
1081410814
rendererConfig: {
1081510815
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10852,7 +10852,7 @@ var internals$jscomp$inline_1457 = {
1085210852
scheduleRoot: null,
1085310853
setRefreshHandler: null,
1085410854
getCurrentFiber: null,
10855-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
10855+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1085610856
};
1085710857
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1085810858
var hook$jscomp$inline_1458 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<72eed3f790662c68e40b18ee2fe345ad>>
10+
* @generated SignedSource<<6194cf6db9b6afa369f5cfa3ca37b088>>
1111
*/
1212

1313
"use strict";
@@ -11462,11 +11462,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1146211462
traverseOwnerTreeUp(hierarchy, instance);
1146311463
}
1146411464
var isomorphicReactPackageVersion = React.version;
11465-
if ("19.0.0-native-fb-df783f9ea1-20240708" !== isomorphicReactPackageVersion)
11465+
if ("19.0.0-native-fb-274c980c53-20240708" !== isomorphicReactPackageVersion)
1146611466
throw Error(
1146711467
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1146811468
(isomorphicReactPackageVersion +
11469-
"\n - react-native-renderer: 19.0.0-native-fb-df783f9ea1-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
11469+
"\n - react-native-renderer: 19.0.0-native-fb-274c980c53-20240708\nLearn more: https://react.dev/warnings/version-mismatch")
1147011470
);
1147111471
if (
1147211472
"function" !==
@@ -11516,7 +11516,7 @@ var roots = new Map(),
1151611516
devToolsConfig$jscomp$inline_1291 = {
1151711517
findFiberByHostInstance: getInstanceFromTag,
1151811518
bundleType: 0,
11519-
version: "19.0.0-native-fb-df783f9ea1-20240708",
11519+
version: "19.0.0-native-fb-274c980c53-20240708",
1152011520
rendererPackageName: "react-native-renderer",
1152111521
rendererConfig: {
1152211522
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11572,7 +11572,7 @@ var roots = new Map(),
1157211572
scheduleRoot: null,
1157311573
setRefreshHandler: null,
1157411574
getCurrentFiber: null,
11575-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
11575+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1157611576
});
1157711577
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1157811578
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)