Skip to content

Commit fc1026b

Browse files
committed
Refactor DOM special cases per tags including controlled fields (#26501)
I use a shared helper when setting properties into a helper whether it's initial or update. I moved the special cases per tag to commit phase so we can check it only once. This also effectively inlines getHostProps which can be done in a single check per prop key. The diffProperties operation is simplified to mostly just generating a plain diff of all properties, generating an update payload. This might generate a few more entries that are now ignored in the commit phase. that previously would've been ignored earlier. We could skip this and just do the whole diff in the commit phase by always scheduling a commit phase update. I tested the attribute table (one change documented below) and a few select DOM fixtures. DiffTrain build for [85de6fd](85de6fd)
1 parent 4b35aaf commit fc1026b

15 files changed

+6251
-6883
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f62cb39ee58e5918806218de2be8d2833023e7fc
1+
85de6fde515148babd36eae2b7384ad8e62b732a

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-0ec8c3f1";
30+
var ReactVersion = "18.3.0-www-modern-3ed4a7e4";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-31f56934";
72+
var ReactVersion = "18.3.0-www-classic-aa994cf1";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9699,7 +9699,7 @@ var slice = Array.prototype.slice,
96999699
return null;
97009700
},
97019701
bundleType: 0,
9702-
version: "18.3.0-www-modern-c4381c45",
9702+
version: "18.3.0-www-modern-0ad65545",
97039703
rendererPackageName: "react-art"
97049704
};
97059705
var internals$jscomp$inline_1304 = {
@@ -9730,7 +9730,7 @@ var internals$jscomp$inline_1304 = {
97309730
scheduleRoot: null,
97319731
setRefreshHandler: null,
97329732
getCurrentFiber: null,
9733-
reconcilerVersion: "18.3.0-www-modern-c4381c45"
9733+
reconcilerVersion: "18.3.0-www-modern-0ad65545"
97349734
};
97359735
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97369736
var hook$jscomp$inline_1305 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)