Skip to content

Commit f06f79c

Browse files
sebmarkbagesebmarkbage
committed
[Flight] Run recreated Errors within a fake native stack (#29717)
Stacked on #29740. Before: <img width="719" alt="Screenshot 2024-06-02 at 11 51 20 AM" src="https://github.com/facebook/react/assets/63648/8f79fa82-2474-4583-894e-a2329e9a6304"> After (updated with my patches to Chrome): <img width="813" alt="Screenshot 2024-06-06 at 5 16 20 PM" src="https://github.com/facebook/react/assets/63648/bcc4f52f-e0ac-4708-ac2b-9629acdff705"> Sources panel after: <img width="1188" alt="Screenshot 2024-06-06 at 5 14 21 PM" src="https://github.com/facebook/react/assets/63648/2c673fac-d32d-42e4-8fac-bb63704e4b7f"> The fake eval file is now under "React" and the real file is now under `file://` DiffTrain build for commit cc1ec60.
1 parent 7c73d3e commit f06f79c

14 files changed

+36
-36
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-142b2a8230-20240607
1+
19.0.0-native-fb-cc1ec60d0d-20240607

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8b1fd15e1bf09fd2986c3fdf914707a0>>
10+
* @generated SignedSource<<73d3d872d5ec820534e20881438276c5>>
1111
*/
1212

1313
'use strict';
@@ -23580,7 +23580,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2358023580
return root;
2358123581
}
2358223582

23583-
var ReactVersion = '19.0.0-native-fb-142b2a8230-20240607';
23583+
var ReactVersion = '19.0.0-native-fb-cc1ec60d0d-20240607';
2358423584

2358523585
/*
2358623586
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<454316ce408cb68e928ca4f164a5bbcb>>
10+
* @generated SignedSource<<2ee45c517d12a4c36071ff0dca7e3e87>>
1111
*/
1212

1313
"use strict";
@@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = {
93369336
throw Error("TestRenderer does not support findFiberByHostInstance()");
93379337
},
93389338
bundleType: 0,
9339-
version: "19.0.0-native-fb-142b2a8230-20240607",
9339+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
93409340
rendererPackageName: "react-test-renderer"
93419341
};
93429342
var internals$jscomp$inline_1235 = {
@@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = {
93679367
scheduleRoot: null,
93689368
setRefreshHandler: null,
93699369
getCurrentFiber: null,
9370-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
9370+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
93719371
};
93729372
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93739373
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<00191e59f7d279cc424a9635c6f735a7>>
10+
* @generated SignedSource<<007b712351767303bab24785170659ec>>
1111
*/
1212

1313
"use strict";
@@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = {
99589958
throw Error("TestRenderer does not support findFiberByHostInstance()");
99599959
},
99609960
bundleType: 0,
9961-
version: "19.0.0-native-fb-142b2a8230-20240607",
9961+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
99629962
rendererPackageName: "react-test-renderer"
99639963
};
99649964
(function (internals) {
@@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = {
1000210002
scheduleRoot: null,
1000310003
setRefreshHandler: null,
1000410004
getCurrentFiber: null,
10005-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
10005+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
1000610006
});
1000710007
exports._Scheduler = Scheduler;
1000810008
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0934aa1ce0150f81ac0d23dbddd663bf>>
10+
* @generated SignedSource<<b8a6edc6c00f6bbe88d722c07c74a2d7>>
1111
*/
1212

1313
'use strict';
@@ -24,7 +24,7 @@ if (
2424
}
2525
var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
2626

27-
var ReactVersion = '19.0.0-native-fb-142b2a8230-20240607';
27+
var ReactVersion = '19.0.0-native-fb-cc1ec60d0d-20240607';
2828

2929
// Re-export dynamic flags from the internal module.
3030
var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9407f168da9e215f25f30e914d5ed66a>>
10+
* @generated SignedSource<<3cc0ff186039e0f5da3045599370e02a>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-142b2a8230-20240607";
607+
exports.version = "19.0.0-native-fb-cc1ec60d0d-20240607";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<831ae6e52d4fac67944410a576d795e3>>
10+
* @generated SignedSource<<c4e5d256661097b6af0e294b7aa65266>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-142b2a8230-20240607";
611+
exports.version = "19.0.0-native-fb-cc1ec60d0d-20240607";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
142b2a8230130ddf3de8a9c8e7799a291f4d1a97
1+
cc1ec60d0de3be60948fc152b2377a42504f551a

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c93398e25374dd9f0c7f66dd5647ba32>>
10+
* @generated SignedSource<<4e711972bd5fdf545f6ac8b1d5518fb2>>
1111
*/
1212

1313
'use strict';
@@ -26316,7 +26316,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2631626316
return root;
2631726317
}
2631826318

26319-
var ReactVersion = '19.0.0-native-fb-142b2a8230-20240607';
26319+
var ReactVersion = '19.0.0-native-fb-cc1ec60d0d-20240607';
2632026320

2632126321
/*
2632226322
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f511b922f568815dfa14b8f93bbb9e21>>
10+
* @generated SignedSource<<35b3b804177b78853a3c05691fad522f>>
1111
*/
1212

1313
"use strict";
@@ -10591,7 +10591,7 @@ var roots = new Map(),
1059110591
devToolsConfig$jscomp$inline_1125 = {
1059210592
findFiberByHostInstance: getInstanceFromNode,
1059310593
bundleType: 0,
10594-
version: "19.0.0-native-fb-142b2a8230-20240607",
10594+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
1059510595
rendererPackageName: "react-native-renderer",
1059610596
rendererConfig: {
1059710597
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = {
1063410634
scheduleRoot: null,
1063510635
setRefreshHandler: null,
1063610636
getCurrentFiber: null,
10637-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
10637+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
1063810638
};
1063910639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1064010640
var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<dd5d6429cb3bbe005ebd21aa04109dec>>
10+
* @generated SignedSource<<8cb5717a1f1a26e80db828ef1e88ed40>>
1111
*/
1212

1313
"use strict";
@@ -11297,7 +11297,7 @@ var roots = new Map(),
1129711297
devToolsConfig$jscomp$inline_1206 = {
1129811298
findFiberByHostInstance: getInstanceFromNode,
1129911299
bundleType: 0,
11300-
version: "19.0.0-native-fb-142b2a8230-20240607",
11300+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
1130111301
rendererPackageName: "react-native-renderer",
1130211302
rendererConfig: {
1130311303
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11353,7 +11353,7 @@ var roots = new Map(),
1135311353
scheduleRoot: null,
1135411354
setRefreshHandler: null,
1135511355
getCurrentFiber: null,
11356-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
11356+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
1135711357
});
1135811358
exports.createPortal = function (children, containerTag) {
1135911359
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6713bbf2284634bb2a4559ea690c92cf>>
10+
* @generated SignedSource<<bdd194a35bbfadeb614fc8e50badda04>>
1111
*/
1212

1313
'use strict';
@@ -26671,7 +26671,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2667126671
return root;
2667226672
}
2667326673

26674-
var ReactVersion = '19.0.0-native-fb-142b2a8230-20240607';
26674+
var ReactVersion = '19.0.0-native-fb-cc1ec60d0d-20240607';
2667526675

2667626676
/*
2667726677
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<210f89dd57082f645a96ecdd2c4cac62>>
10+
* @generated SignedSource<<0cad6bce0e190be31b9407282a4afb68>>
1111
*/
1212

1313
"use strict";
@@ -10734,11 +10734,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1073410734
traverseOwnerTreeUp(hierarchy, instance);
1073510735
}
1073610736
var isomorphicReactPackageVersion = React.version;
10737-
if ("19.0.0-native-fb-142b2a8230-20240607" !== isomorphicReactPackageVersion)
10737+
if ("19.0.0-native-fb-cc1ec60d0d-20240607" !== isomorphicReactPackageVersion)
1073810738
throw Error(
1073910739
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1074010740
(isomorphicReactPackageVersion +
10741-
"\n - react-native-renderer: 19.0.0-native-fb-142b2a8230-20240607\nLearn more: https://react.dev/warnings/version-mismatch")
10741+
"\n - react-native-renderer: 19.0.0-native-fb-cc1ec60d0d-20240607\nLearn more: https://react.dev/warnings/version-mismatch")
1074210742
);
1074310743
if (
1074410744
"function" !==
@@ -10788,7 +10788,7 @@ var roots = new Map(),
1078810788
devToolsConfig$jscomp$inline_1193 = {
1078910789
findFiberByHostInstance: getInstanceFromTag,
1079010790
bundleType: 0,
10791-
version: "19.0.0-native-fb-142b2a8230-20240607",
10791+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
1079210792
rendererPackageName: "react-native-renderer",
1079310793
rendererConfig: {
1079410794
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10831,7 +10831,7 @@ var internals$jscomp$inline_1440 = {
1083110831
scheduleRoot: null,
1083210832
setRefreshHandler: null,
1083310833
getCurrentFiber: null,
10834-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
10834+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
1083510835
};
1083610836
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1083710837
var hook$jscomp$inline_1441 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<281dda5fc5ac1a270478d3e1af593eef>>
10+
* @generated SignedSource<<d28d8884bab6add8a5a55dc8ac403700>>
1111
*/
1212

1313
"use strict";
@@ -11441,11 +11441,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1144111441
traverseOwnerTreeUp(hierarchy, instance);
1144211442
}
1144311443
var isomorphicReactPackageVersion = React.version;
11444-
if ("19.0.0-native-fb-142b2a8230-20240607" !== isomorphicReactPackageVersion)
11444+
if ("19.0.0-native-fb-cc1ec60d0d-20240607" !== isomorphicReactPackageVersion)
1144511445
throw Error(
1144611446
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1144711447
(isomorphicReactPackageVersion +
11448-
"\n - react-native-renderer: 19.0.0-native-fb-142b2a8230-20240607\nLearn more: https://react.dev/warnings/version-mismatch")
11448+
"\n - react-native-renderer: 19.0.0-native-fb-cc1ec60d0d-20240607\nLearn more: https://react.dev/warnings/version-mismatch")
1144911449
);
1145011450
if (
1145111451
"function" !==
@@ -11495,7 +11495,7 @@ var roots = new Map(),
1149511495
devToolsConfig$jscomp$inline_1274 = {
1149611496
findFiberByHostInstance: getInstanceFromTag,
1149711497
bundleType: 0,
11498-
version: "19.0.0-native-fb-142b2a8230-20240607",
11498+
version: "19.0.0-native-fb-cc1ec60d0d-20240607",
1149911499
rendererPackageName: "react-native-renderer",
1150011500
rendererConfig: {
1150111501
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11551,7 +11551,7 @@ var roots = new Map(),
1155111551
scheduleRoot: null,
1155211552
setRefreshHandler: null,
1155311553
getCurrentFiber: null,
11554-
reconcilerVersion: "19.0.0-native-fb-142b2a8230-20240607"
11554+
reconcilerVersion: "19.0.0-native-fb-cc1ec60d0d-20240607"
1155511555
});
1155611556
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1155711557
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)