Skip to content

Commit ed97c69

Browse files
committed
Remove some unused methods
When Float was first implemented the HostDispatcher was set and unset during each render. Now that we support dispatching globally the host extensions that did this Dispatcher shuffling is now a noop. Since these methods exist in all HostConfigs and they noop everywhere now we shoudl just remove them.
1 parent 1d0c328 commit ed97c69

File tree

9 files changed

+0
-53
lines changed

9 files changed

+0
-53
lines changed

packages/react-art/src/ReactARTHostConfig.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -475,11 +475,3 @@ export function suspendInstance(type, props) {}
475475
export function waitForCommitToBeReady() {
476476
return null;
477477
}
478-
// eslint-disable-next-line no-undef
479-
export function prepareRendererToRender(container: Container): void {
480-
// noop
481-
}
482-
483-
export function resetRendererAfterRender(): void {
484-
// noop
485-
}

packages/react-dom-bindings/src/client/ReactDOMHostConfig.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1931,16 +1931,6 @@ export function prepareToCommitHoistables() {
19311931
tagCaches = null;
19321932
}
19331933

1934-
// It is valid to preload even when we aren't actively rendering. For cases where Float functions are
1935-
// called when there is no rendering we track the last used document. It is not safe to insert
1936-
// arbitrary resources into the lastCurrentDocument b/c it may not actually be the document
1937-
// that the resource is meant to apply too (for example stylesheets or scripts). This is only
1938-
// appropriate for resources that don't really have a strict tie to the document itself for example
1939-
// preloads
1940-
export function prepareRendererToRender(rootContainer: Container) {}
1941-
1942-
export function resetRendererAfterRender() {}
1943-
19441934
// global collections of Resources
19451935
const preloadPropsMap: Map<string, PreloadProps> = new Map();
19461936
const preconnectsSet: Set<string> = new Set();

packages/react-native-renderer/src/ReactFabricHostConfig.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -466,11 +466,3 @@ export function suspendInstance(type: Type, props: Props): void {}
466466
export function waitForCommitToBeReady(): null {
467467
return null;
468468
}
469-
470-
export function prepareRendererToRender(container: Container): void {
471-
// noop
472-
}
473-
474-
export function resetRendererAfterRender() {
475-
// noop
476-
}

packages/react-native-renderer/src/ReactNativeHostConfig.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -538,11 +538,3 @@ export function suspendInstance(type: Type, props: Props): void {}
538538
export function waitForCommitToBeReady(): null {
539539
return null;
540540
}
541-
542-
export function prepareRendererToRender(container: Container): void {
543-
// noop
544-
}
545-
546-
export function resetRendererAfterRender(): void {
547-
// noop
548-
}

packages/react-noop-renderer/src/createReactNoop.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -630,9 +630,6 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
630630
},
631631

632632
waitForCommitToBeReady,
633-
634-
prepareRendererToRender() {},
635-
resetRendererAfterRender() {},
636633
};
637634

638635
const hostConfig = useMutation

packages/react-reconciler/src/ReactFiberWorkLoop.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ import {
7272
afterActiveInstanceBlur,
7373
getCurrentEventPriority,
7474
errorHydratingContainer,
75-
prepareRendererToRender,
76-
resetRendererAfterRender,
7775
startSuspendingCommit,
7876
waitForCommitToBeReady,
7977
preloadInstance,
@@ -1850,7 +1848,6 @@ export function shouldRemainOnPreviousScreen(): boolean {
18501848
}
18511849

18521850
function pushDispatcher(container: any) {
1853-
prepareRendererToRender(container);
18541851
const prevDispatcher = ReactCurrentDispatcher.current;
18551852
ReactCurrentDispatcher.current = ContextOnlyDispatcher;
18561853
if (prevDispatcher === null) {
@@ -1864,7 +1861,6 @@ function pushDispatcher(container: any) {
18641861
}
18651862

18661863
function popDispatcher(prevDispatcher: any) {
1867-
resetRendererAfterRender();
18681864
ReactCurrentDispatcher.current = prevDispatcher;
18691865
}
18701866

packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.internal.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ describe('ReactFiberHostContext', () => {
8282
waitForCommitToBeReady() {
8383
return null;
8484
},
85-
prepareRendererToRender: function () {},
86-
resetRendererAfterRender: function () {},
8785
supportsMutation: true,
8886
});
8987

packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ export const preloadInstance = $$$hostConfig.preloadInstance;
7373
export const startSuspendingCommit = $$$hostConfig.startSuspendingCommit;
7474
export const suspendInstance = $$$hostConfig.suspendInstance;
7575
export const waitForCommitToBeReady = $$$hostConfig.waitForCommitToBeReady;
76-
export const prepareRendererToRender = $$$hostConfig.prepareRendererToRender;
77-
export const resetRendererAfterRender = $$$hostConfig.resetRendererAfterRender;
7876

7977
// -------------------
8078
// Microtasks

packages/react-test-renderer/src/ReactTestHostConfig.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -340,11 +340,3 @@ export function suspendInstance(type: Type, props: Props): void {}
340340
export function waitForCommitToBeReady(): null {
341341
return null;
342342
}
343-
344-
export function prepareRendererToRender(container: Container): void {
345-
// noop
346-
}
347-
348-
export function resetRendererAfterRender(): void {
349-
// noop
350-
}

0 commit comments

Comments
 (0)