Skip to content

Commit ea13a6d

Browse files
sebmarkbagesebmarkbage
committed
Gate createEventHandle / useFocus on www
These are enabled in both www variants but not OSS experimental.
1 parent 4bdd49c commit ea13a6d

File tree

6 files changed

+76
-76
lines changed

6 files changed

+76
-76
lines changed

‎packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,7 +1912,7 @@ describe('ReactDOMServerPartialHydration', () => {
19121912
document.body.removeChild(container);
19131913
});
19141914

1915-
// @gate experimental
1915+
// @gate www
19161916
it('does not invoke an event on a hydrated event handle until it commits', async () => {
19171917
const setClick = ReactDOM.unstable_createEventHandle('click');
19181918
let suspend = false;
@@ -2077,7 +2077,7 @@ describe('ReactDOMServerPartialHydration', () => {
20772077
document.body.removeChild(container);
20782078
});
20792079

2080-
// @gate experimental
2080+
// @gate www
20812081
it('invokes discrete events on nested suspense boundaries in a root (createEventHandle)', async () => {
20822082
let suspend = false;
20832083
let isServerRendering = true;

‎packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
369369
document.body.removeChild(container);
370370
});
371371

372-
// @gate experimental
372+
// @gate www
373373
it('hydrates the target boundary synchronously during a click (createEventHandle)', async () => {
374374
const setClick = ReactDOM.unstable_createEventHandle('click');
375375
let isServerRendering = true;
@@ -438,7 +438,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
438438
document.body.removeChild(container);
439439
});
440440

441-
// @gate experimental
441+
// @gate www
442442
it('hydrates at higher pri if sync did not work first time (createEventHandle)', async () => {
443443
let suspend = false;
444444
let isServerRendering = true;
@@ -526,7 +526,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
526526
document.body.removeChild(container);
527527
});
528528

529-
// @gate experimental
529+
// @gate www
530530
it('hydrates at higher pri for secondary discrete events (createEventHandle)', async () => {
531531
const setClick = ReactDOM.unstable_createEventHandle('click');
532532
let suspend = false;

‎packages/react-dom/src/events/__tests__/DOMPluginEventSystem-test.internal.js

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,7 +1257,7 @@ describe('DOMPluginEventSystem', () => {
12571257
act = ReactTestUtils.unstable_concurrentAct;
12581258
});
12591259

1260-
// @gate experimental
1260+
// @gate www
12611261
it('can render correctly with the ReactDOMServer', () => {
12621262
const clickEvent = jest.fn();
12631263
const setClick = ReactDOM.unstable_createEventHandle('click');
@@ -1275,7 +1275,7 @@ describe('DOMPluginEventSystem', () => {
12751275
expect(output).toBe(`<div>Hello world</div>`);
12761276
});
12771277

1278-
// @gate experimental
1278+
// @gate www
12791279
it('can render correctly with the ReactDOMServer hydration', () => {
12801280
const clickEvent = jest.fn();
12811281
const spanRef = React.createRef();
@@ -1301,7 +1301,7 @@ describe('DOMPluginEventSystem', () => {
13011301
expect(clickEvent).toHaveBeenCalledTimes(1);
13021302
});
13031303

1304-
// @gate experimental
1304+
// @gate www
13051305
it('should correctly work for a basic "click" listener', () => {
13061306
let log = [];
13071307
const clickEvent = jest.fn(event => {
@@ -1409,7 +1409,7 @@ describe('DOMPluginEventSystem', () => {
14091409
expect(clickEvent2).toBeCalledTimes(1);
14101410
});
14111411

1412-
// @gate experimental
1412+
// @gate www
14131413
it('should correctly work for setting and clearing a basic "click" listener', () => {
14141414
const clickEvent = jest.fn();
14151415
const divRef = React.createRef();
@@ -1450,7 +1450,7 @@ describe('DOMPluginEventSystem', () => {
14501450
expect(clickEvent).toBeCalledTimes(0);
14511451
});
14521452

1453-
// @gate experimental
1453+
// @gate www
14541454
it('should handle the target being a text node', () => {
14551455
const clickEvent = jest.fn();
14561456
const buttonRef = React.createRef();
@@ -1472,7 +1472,7 @@ describe('DOMPluginEventSystem', () => {
14721472
expect(clickEvent).toBeCalledTimes(1);
14731473
});
14741474

1475-
// @gate experimental
1475+
// @gate www
14761476
it('handle propagation of click events', () => {
14771477
const buttonRef = React.createRef();
14781478
const divRef = React.createRef();
@@ -1541,7 +1541,7 @@ describe('DOMPluginEventSystem', () => {
15411541
expect(log[3]).toEqual(['bubble', buttonElement]);
15421542
});
15431543

1544-
// @gate experimental
1544+
// @gate www
15451545
it('handle propagation of click events mixed with onClick events', () => {
15461546
const buttonRef = React.createRef();
15471547
const divRef = React.createRef();
@@ -1601,7 +1601,7 @@ describe('DOMPluginEventSystem', () => {
16011601
expect(log[5]).toEqual(['bubble', buttonElement]);
16021602
});
16031603

1604-
// @gate experimental
1604+
// @gate www
16051605
it('should correctly work for a basic "click" listener on the outer target', () => {
16061606
const log = [];
16071607
const clickEvent = jest.fn(event => {
@@ -1666,7 +1666,7 @@ describe('DOMPluginEventSystem', () => {
16661666
expect(clickEvent).toBeCalledTimes(2);
16671667
});
16681668

1669-
// @gate experimental
1669+
// @gate www
16701670
it('should correctly handle many nested target listeners', () => {
16711671
const buttonRef = React.createRef();
16721672
const targetListener1 = jest.fn();
@@ -1769,7 +1769,7 @@ describe('DOMPluginEventSystem', () => {
17691769
expect(targetListener4).toHaveBeenCalledTimes(2);
17701770
});
17711771

1772-
// @gate experimental
1772+
// @gate www
17731773
it('should correctly handle stopPropagation correctly for target events', () => {
17741774
const buttonRef = React.createRef();
17751775
const divRef = React.createRef();
@@ -1807,7 +1807,7 @@ describe('DOMPluginEventSystem', () => {
18071807
expect(clickEvent).toHaveBeenCalledTimes(0);
18081808
});
18091809

1810-
// @gate experimental
1810+
// @gate www
18111811
it('should correctly handle stopPropagation correctly for many target events', () => {
18121812
const buttonRef = React.createRef();
18131813
const targetListener1 = jest.fn(e => e.stopPropagation());
@@ -1860,7 +1860,7 @@ describe('DOMPluginEventSystem', () => {
18601860
expect(targetListener4).toHaveBeenCalledTimes(1);
18611861
});
18621862

1863-
// @gate experimental
1863+
// @gate www
18641864
it('should correctly handle stopPropagation for mixed capture/bubbling target listeners', () => {
18651865
const buttonRef = React.createRef();
18661866
const targetListener1 = jest.fn(e => e.stopPropagation());
@@ -1917,7 +1917,7 @@ describe('DOMPluginEventSystem', () => {
19171917
expect(targetListener4).toHaveBeenCalledTimes(0);
19181918
});
19191919

1920-
// @gate experimental
1920+
// @gate www
19211921
it('should work with concurrent mode updates', async () => {
19221922
const log = [];
19231923
const ref = React.createRef();
@@ -1970,7 +1970,7 @@ describe('DOMPluginEventSystem', () => {
19701970
expect(log).toEqual([{counter: 1}]);
19711971
});
19721972

1973-
// @gate experimental
1973+
// @gate www
19741974
it('should correctly work for a basic "click" window listener', () => {
19751975
const log = [];
19761976
const clickEvent = jest.fn(event => {
@@ -2021,7 +2021,7 @@ describe('DOMPluginEventSystem', () => {
20212021
expect(clickEvent).toBeCalledTimes(2);
20222022
});
20232023

2024-
// @gate experimental
2024+
// @gate www
20252025
it('handle propagation of click events on the window', () => {
20262026
const buttonRef = React.createRef();
20272027
const divRef = React.createRef();
@@ -2101,7 +2101,7 @@ describe('DOMPluginEventSystem', () => {
21012101
expect(log[5]).toEqual(['bubble', window]);
21022102
});
21032103

2104-
// @gate experimental
2104+
// @gate www
21052105
it('should correctly handle stopPropagation for mixed listeners', () => {
21062106
const buttonRef = React.createRef();
21072107
const rootListener1 = jest.fn(e => e.stopPropagation());
@@ -2152,7 +2152,7 @@ describe('DOMPluginEventSystem', () => {
21522152
expect(rootListener2).toHaveBeenCalledTimes(0);
21532153
});
21542154

2155-
// @gate experimental
2155+
// @gate www
21562156
it('should correctly handle stopPropagation for delegated listeners', () => {
21572157
const buttonRef = React.createRef();
21582158
const rootListener1 = jest.fn(e => e.stopPropagation());
@@ -2198,7 +2198,7 @@ describe('DOMPluginEventSystem', () => {
21982198
expect(rootListener4).toHaveBeenCalledTimes(0);
21992199
});
22002200

2201-
// @gate experimental
2201+
// @gate www
22022202
it('handle propagation of click events on the window and document', () => {
22032203
const buttonRef = React.createRef();
22042204
const divRef = React.createRef();
@@ -2311,7 +2311,7 @@ describe('DOMPluginEventSystem', () => {
23112311
}
23122312
});
23132313

2314-
// @gate experimental
2314+
// @gate www
23152315
it('does not support custom user events', () => {
23162316
// With eager listeners, supporting custom events via this API doesn't make sense
23172317
// because we can't know a full list of them ahead of time. Let's check we throw
@@ -2323,7 +2323,7 @@ describe('DOMPluginEventSystem', () => {
23232323
);
23242324
});
23252325

2326-
// @gate experimental
2326+
// @gate www
23272327
it('beforeblur and afterblur are called after a focused element is unmounted', () => {
23282328
const log = [];
23292329
// We have to persist here because we want to read relatedTarget later.
@@ -2382,7 +2382,7 @@ describe('DOMPluginEventSystem', () => {
23822382
expect(log).toEqual(['beforeblur', 'afterblur']);
23832383
});
23842384

2385-
// @gate experimental
2385+
// @gate www
23862386
it('beforeblur and afterblur are called after a nested focused element is unmounted', () => {
23872387
const log = [];
23882388
// We have to persist here because we want to read relatedTarget later.
@@ -2445,7 +2445,7 @@ describe('DOMPluginEventSystem', () => {
24452445
expect(log).toEqual(['beforeblur', 'afterblur']);
24462446
});
24472447

2448-
// @gate experimental
2448+
// @gate www
24492449
it('beforeblur should skip handlers from a deleted subtree after the focused element is unmounted', () => {
24502450
const onBeforeBlur = jest.fn();
24512451
const innerRef = React.createRef();
@@ -2499,7 +2499,7 @@ describe('DOMPluginEventSystem', () => {
24992499
expect(onBeforeBlur).toHaveBeenCalledTimes(1);
25002500
});
25012501

2502-
// @gate experimental
2502+
// @gate www
25032503
it('beforeblur and afterblur are called after a focused element is suspended', () => {
25042504
const log = [];
25052505
// We have to persist here because we want to read relatedTarget later.
@@ -2585,7 +2585,7 @@ describe('DOMPluginEventSystem', () => {
25852585
document.body.removeChild(container2);
25862586
});
25872587

2588-
// @gate experimental
2588+
// @gate www
25892589
it('beforeblur should skip handlers from a deleted subtree after the focused element is suspended', () => {
25902590
const onBeforeBlur = jest.fn();
25912591
const innerRef = React.createRef();
@@ -2666,7 +2666,7 @@ describe('DOMPluginEventSystem', () => {
26662666
document.body.removeChild(container2);
26672667
});
26682668

2669-
// @gate experimental
2669+
// @gate www
26702670
it('regression: does not fire beforeblur/afterblur if target is already hidden', () => {
26712671
const Suspense = React.Suspense;
26722672
let suspend = false;
@@ -2728,7 +2728,7 @@ describe('DOMPluginEventSystem', () => {
27282728
document.body.removeChild(container2);
27292729
});
27302730

2731-
// @gate experimental
2731+
// @gate www
27322732
it('handle propagation of click events between disjointed comment roots', () => {
27332733
const buttonRef = React.createRef();
27342734
const divRef = React.createRef();
@@ -2799,7 +2799,7 @@ describe('DOMPluginEventSystem', () => {
27992799
expect(log[5]).toEqual(['bubble', buttonElement]);
28002800
});
28012801

2802-
// @gate experimental
2802+
// @gate www
28032803
it('propagates known createEventHandle events through portals without inner listeners', () => {
28042804
const buttonRef = React.createRef();
28052805
const divRef = React.createRef();
@@ -2870,7 +2870,7 @@ describe('DOMPluginEventSystem', () => {
28702870
ReactDOMServer = require('react-dom/server');
28712871
});
28722872

2873-
// @gate experimental
2873+
// @gate www
28742874
it('handle propagation of click events on a scope', () => {
28752875
const buttonRef = React.createRef();
28762876
const log = [];
@@ -2926,7 +2926,7 @@ describe('DOMPluginEventSystem', () => {
29262926
]);
29272927
});
29282928

2929-
// @gate experimental
2929+
// @gate www
29302930
it('handle mixed propagation of click events on a scope', () => {
29312931
const buttonRef = React.createRef();
29322932
const divRef = React.createRef();
@@ -3017,7 +3017,7 @@ describe('DOMPluginEventSystem', () => {
30173017
]);
30183018
});
30193019

3020-
// @gate experimental
3020+
// @gate www
30213021
it('should not handle the target being a dangling text node within a scope', () => {
30223022
const clickEvent = jest.fn();
30233023
const buttonRef = React.createRef();
@@ -3048,7 +3048,7 @@ describe('DOMPluginEventSystem', () => {
30483048
expect(clickEvent).toBeCalledTimes(0);
30493049
});
30503050

3051-
// @gate experimental
3051+
// @gate www
30523052
it('handle stopPropagation (inner) correctly between scopes', () => {
30533053
const buttonRef = React.createRef();
30543054
const outerOnClick = jest.fn();
@@ -3090,7 +3090,7 @@ describe('DOMPluginEventSystem', () => {
30903090
expect(outerOnClick).toHaveBeenCalledTimes(0);
30913091
});
30923092

3093-
// @gate experimental
3093+
// @gate www
30943094
it('handle stopPropagation (outer) correctly between scopes', () => {
30953095
const buttonRef = React.createRef();
30963096
const outerOnClick = jest.fn(e => e.stopPropagation());
@@ -3132,7 +3132,7 @@ describe('DOMPluginEventSystem', () => {
31323132
expect(outerOnClick).toHaveBeenCalledTimes(1);
31333133
});
31343134

3135-
// @gate experimental
3135+
// @gate www
31363136
it('handle stopPropagation (inner and outer) correctly between scopes', () => {
31373137
const buttonRef = React.createRef();
31383138
const onClick = jest.fn(e => e.stopPropagation());
@@ -3172,7 +3172,7 @@ describe('DOMPluginEventSystem', () => {
31723172
expect(onClick).toHaveBeenCalledTimes(1);
31733173
});
31743174

3175-
// @gate experimental
3175+
// @gate www
31763176
it('should be able to register handlers for events affected by the intervention', () => {
31773177
const rootContainer = document.createElement('div');
31783178
container.appendChild(rootContainer);

0 commit comments

Comments
 (0)