You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat[devtools]: symbolicate source for inspected element (#28471)
Stacked on #28351, please review
only the last commit.
Top-level description of the approach:
1. Once user selects an element from the tree, frontend asks backend to
return the inspected element, this is where we simulate an error
happening in `render` function of the component and then we parse the
error stack. As an improvement, we should probably migrate from custom
implementation of error stack parser to `error-stack-parser` from npm.
2. When frontend receives the inspected element and this object is being
propagated, we create a Promise for symbolicated source, which is then
passed down to all components, which are using `source`.
3. These components use `use` hook for this promise and are wrapped in
Suspense.
Caching:
1. For browser extension, we cache Promises based on requested resource
+ key + column, also added use of
`chrome.devtools.inspectedWindow.getResource` API.
2. For standalone case (RN), we cache based on requested resource url,
we cache the content of it.
DiffTrain build for commit e528728.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -25733,7 +25733,7 @@ if (__DEV__) {
25733
25733
return root;
25734
25734
}
25735
25735
25736
-
var ReactVersion = "18.3.0-canary-61bd00498-20240305";
25736
+
var ReactVersion = "18.3.0-canary-e5287287a-20240305";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9173,7 +9173,7 @@ var devToolsConfig$jscomp$inline_1014 = {
9173
9173
throwError("TestRenderer does not support findFiberByHostInstance()");
9174
9174
},
9175
9175
bundleType: 0,
9176
-
version: "18.3.0-canary-61bd00498-20240305",
9176
+
version: "18.3.0-canary-e5287287a-20240305",
9177
9177
rendererPackageName: "react-test-renderer"
9178
9178
};
9179
9179
varinternals$jscomp$inline_1195={
@@ -9204,7 +9204,7 @@ var internals$jscomp$inline_1195 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9601,7 +9601,7 @@ var devToolsConfig$jscomp$inline_1056 = {
9601
9601
throwError("TestRenderer does not support findFiberByHostInstance()");
9602
9602
},
9603
9603
bundleType: 0,
9604
-
version: "18.3.0-canary-61bd00498-20240305",
9604
+
version: "18.3.0-canary-e5287287a-20240305",
9605
9605
rendererPackageName: "react-test-renderer"
9606
9606
};
9607
9607
varinternals$jscomp$inline_1236={
@@ -9632,7 +9632,7 @@ var internals$jscomp$inline_1236 = {
0 commit comments