You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Fizz] Do not reinsert stylesheets after initial insert (#27586)
The loading state tracking for suspensey CSS is too complicated. Prior
to this change it had a state it could enter into where a stylesheet was
already in the DOM but the loading state did not know it was inserted
causing a later transition to try to insert it again.
This fix is to add proper tracking of insertions on the codepaths that
were missing it. It also modifies the logic of when to suspend based on
whether the stylesheet has already been inserted or not.
This is not 100% correct semantics however because a prior commit could
have inserted a stylesheet and a later transition should ideally be able
to wait on that load before committing. I haven't attempted to fix this
yet however because the loading state tracking is too complicated as it
is and requires a more thorough refactor. Additionally it's not
particularly valuable to delay a transition on a loading stylesheet when
a previous commit also relied on that stylesheet but didn't wait for it
b/c it was sync. I will follow up with an improvement PR later
fixes: #27585
DiffTrain build for commit a998552.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -24887,7 +24887,7 @@ function createFiberRoot(
24887
24887
return root;
24888
24888
}
24889
24889
24890
-
var ReactVersion = "18.3.0-canary-51ffd3564-20231025";
24890
+
var ReactVersion = "18.3.0-canary-a9985529f-20231025";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9025,7 +9025,7 @@ var devToolsConfig$jscomp$inline_1032 = {
9025
9025
throwError("TestRenderer does not support findFiberByHostInstance()");
9026
9026
},
9027
9027
bundleType: 0,
9028
-
version: "18.3.0-canary-51ffd3564-20231025",
9028
+
version: "18.3.0-canary-a9985529f-20231025",
9029
9029
rendererPackageName: "react-test-renderer"
9030
9030
};
9031
9031
varinternals$jscomp$inline_1225={
@@ -9056,7 +9056,7 @@ var internals$jscomp$inline_1225 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9451,7 +9451,7 @@ var devToolsConfig$jscomp$inline_1074 = {
9451
9451
throwError("TestRenderer does not support findFiberByHostInstance()");
9452
9452
},
9453
9453
bundleType: 0,
9454
-
version: "18.3.0-canary-51ffd3564-20231025",
9454
+
version: "18.3.0-canary-a9985529f-20231025",
9455
9455
rendererPackageName: "react-test-renderer"
9456
9456
};
9457
9457
varinternals$jscomp$inline_1266={
@@ -9482,7 +9482,7 @@ var internals$jscomp$inline_1266 = {
0 commit comments