fix: Don't consider Hooks as Components

facebook · Oct 1, 2022 · e002fc7 · e002fc7
1 parent 7cd66c3
commit e002fc7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleNoNestedComponents-test.js b/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleNoNestedComponents-test.js
@@ -846,6 +846,17 @@ const tests = {
         }))
       `,
     },
+    {
+      code: normalizeIndent`
+        function useCustomHook() {
+          const useNestedHook = () => {
+            React.useRef();
+          }
+          useNestedHook();
+          useNestedHook();
+        }
+      `,
+    },
   ],
   invalid: [
     {

diff --git a/packages/eslint-plugin-react-hooks/src/NoNestedComponents.js b/packages/eslint-plugin-react-hooks/src/NoNestedComponents.js
@@ -102,7 +102,7 @@ function isInsideComponentOrHook(node) {
 function isComponent(node) {
   const functionName = getFunctionName(node);
   if (functionName) {
-    if (isComponentName(functionName) || isHook(functionName)) {
+    if (isComponentName(functionName)) {
       return true;
     }
   }