From dee1aac77f71e887c44bb79ecfe9c7a34ab3e74c Mon Sep 17 00:00:00 2001 From: Ricky Date: Tue, 27 Feb 2024 16:33:14 -0500 Subject: [PATCH] Turn on disableJavaScriptURLs for experimental (#28462) This is on everywhere, ready to turn on in the next major. --- .../src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js | 2 -- packages/shared/ReactFeatureFlags.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.www.js | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js index 808396610c48d..73d511985527c 100644 --- a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js @@ -195,8 +195,6 @@ describe('ReactDOMServerIntegration - Untrusted URLs - disableJavaScriptURLs', ( function initModules() { jest.resetModules(); - const ReactFeatureFlags = require('shared/ReactFeatureFlags'); - ReactFeatureFlags.disableJavaScriptURLs = true; React = require('react'); ReactDOMClient = require('react-dom/client'); diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index d33403b1f73e7..2d48410460b87 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -145,7 +145,7 @@ export const disableLegacyContext = false; // Not ready to break experimental yet. // Disable javascript: URL strings in href for XSS protection. -export const disableJavaScriptURLs = false; +export const disableJavaScriptURLs = __NEXT_MAJOR__; // Not ready to break experimental yet. // Modern behaviour aligns more with what components diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js index 880a8d24d18c2..e82f84389e544 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.js @@ -28,7 +28,7 @@ export const enableFormActions = true; // Doesn't affect Test Renderer export const enableBinaryFlight = true; export const enableTaint = true; export const enablePostpone = false; -export const disableJavaScriptURLs = false; +export const disableJavaScriptURLs = true; export const disableCommentsAsDOMContainers = true; export const disableInputAttributeSyncing = false; export const disableIEWorkarounds = true; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js index ef9031b734a6f..375d9c6c7fa48 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js @@ -28,7 +28,7 @@ export const enableFormActions = true; // Doesn't affect Test Renderer export const enableBinaryFlight = true; export const enableTaint = true; export const enablePostpone = false; -export const disableJavaScriptURLs = false; +export const disableJavaScriptURLs = true; export const disableCommentsAsDOMContainers = true; export const disableInputAttributeSyncing = false; export const disableIEWorkarounds = true;