Skip to content

Commit ded6104

Browse files
committed
Revert "test-persistent should skip files without noop"
Seb objected to adding shelljs as a dep and I'm too lazy to worry about Windows support so whatever I'll just revert this.
1 parent b69a2d7 commit ded6104

File tree

3 files changed

+2
-55
lines changed

3 files changed

+2
-55
lines changed

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"packages/*"
55
],
66
"devDependencies": {
7-
"@mattiasbuelens/web-streams-polyfill": "0.1.0",
87
"art": "^0.10.1",
98
"babel-cli": "^6.6.5",
109
"babel-code-frame": "^6.26.0",
@@ -81,11 +80,11 @@
8180
"rollup-plugin-replace": "^2.0.0",
8281
"rollup-plugin-strip-banner": "^0.2.0",
8382
"semver": "^5.5.0",
84-
"shelljs": "^0.8.3",
8583
"targz": "^1.0.1",
8684
"through2": "^2.0.0",
8785
"tmp": "~0.0.28",
88-
"typescript": "~1.8.10"
86+
"typescript": "~1.8.10",
87+
"@mattiasbuelens/web-streams-polyfill": "0.1.0"
8988
},
9089
"devEngines": {
9190
"node": "8.x || 9.x || 10.x || 11.x"

scripts/jest/config.source-persistent.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,9 @@
11
'use strict';
22

3-
const path = require('path');
4-
const {find, grep} = require('shelljs');
53
const baseConfig = require('./config.base');
64

7-
// Search for all the test files that reference react-noop-renderer
8-
const packagesDir = path.join(process.cwd(), 'packages');
9-
const testRegex = new RegExp(baseConfig.testRegex);
10-
const testFiles = find('packages').filter(filename => testRegex.test(filename));
11-
const testMatchFilesThatReferenceNoop = grep(
12-
'-l',
13-
'react-noop-renderer',
14-
testFiles
15-
)
16-
.split('\n')
17-
.map(filename => `**/${path.relative(packagesDir, filename)}`);
18-
195
module.exports = Object.assign({}, baseConfig, {
20-
// Override base regex so that we only match the files we found above.
21-
testRegex: null,
22-
testMatch: testMatchFilesThatReferenceNoop,
236
modulePathIgnorePatterns: [
24-
...baseConfig.modulePathIgnorePatterns,
25-
// These files only work in mutation mode
267
'ReactIncrementalPerf',
278
'ReactIncrementalUpdatesMinimalism',
289
'ReactIncrementalTriangle',

yarn.lock

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -2228,18 +2228,6 @@ glob@^6.0.4:
22282228
once "^1.3.0"
22292229
path-is-absolute "^1.0.0"
22302230

2231-
glob@^7.0.0:
2232-
version "7.1.3"
2233-
resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.3.tgz#3960832d3f1574108342dafd3a67b332c0969df1"
2234-
integrity sha512-vcfuiIxogLV4DlGBHIUOwI0IbrJ8HWPc4MU7HzviGeNho/UJDfi6B5p3sHeWIQ0KGIU0Jpxi5ZHxemQfLkkAwQ==
2235-
dependencies:
2236-
fs.realpath "^1.0.0"
2237-
inflight "^1.0.4"
2238-
inherits "2"
2239-
minimatch "^3.0.4"
2240-
once "^1.3.0"
2241-
path-is-absolute "^1.0.0"
2242-
22432231
glob@^7.0.3, glob@^7.0.5, glob@^7.1.1, glob@^7.1.2:
22442232
version "7.1.2"
22452233
resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.2.tgz#c19c9df9a028702d678612384a6552404c636d15"
@@ -2538,11 +2526,6 @@ inquirer@^3.0.6:
25382526
strip-ansi "^4.0.0"
25392527
through "^2.3.6"
25402528

2541-
interpret@^1.0.0:
2542-
version "1.2.0"
2543-
resolved "https://registry.yarnpkg.com/interpret/-/interpret-1.2.0.tgz#d5061a6224be58e8083985f5014d844359576296"
2544-
integrity sha512-mT34yGKMNceBQUoVn7iCDKDntA7SC6gycMAWzGx1z/CMCTV7b2AAtXlo3nRyHZ1FelRkQbQjprHSYGwzLtkVbw==
2545-
25462529
invariant@^2.2.2:
25472530
version "2.2.4"
25482531
resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.4.tgz#610f3c92c9359ce1db616e538008d23ff35158e6"
@@ -4196,13 +4179,6 @@ realpath-native@^1.0.0:
41964179
dependencies:
41974180
util.promisify "^1.0.0"
41984181

4199-
rechoir@^0.6.2:
4200-
version "0.6.2"
4201-
resolved "https://registry.yarnpkg.com/rechoir/-/rechoir-0.6.2.tgz#85204b54dba82d5742e28c96756ef43af50e3384"
4202-
integrity sha1-hSBLVNuoLVdC4oyWdW70OvUOM4Q=
4203-
dependencies:
4204-
resolve "^1.1.6"
4205-
42064182
regenerator-runtime@^0.10.5:
42074183
version "0.10.5"
42084184
resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.10.5.tgz#336c3efc1220adcedda2c9fab67b5a7955a33658"
@@ -4573,15 +4549,6 @@ shebang-regex@^1.0.0:
45734549
version "1.0.0"
45744550
resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3"
45754551

4576-
shelljs@^0.8.3:
4577-
version "0.8.3"
4578-
resolved "https://registry.yarnpkg.com/shelljs/-/shelljs-0.8.3.tgz#a7f3319520ebf09ee81275b2368adb286659b097"
4579-
integrity sha512-fc0BKlAWiLpwZljmOvAOTE/gXawtCoNrP5oaY7KIaQbbyHeQVg01pSEuEGvGh3HEdBU4baCD7wQBwADmM/7f7A==
4580-
dependencies:
4581-
glob "^7.0.0"
4582-
interpret "^1.0.0"
4583-
rechoir "^0.6.2"
4584-
45854552
shellwords@^0.1.1:
45864553
version "0.1.1"
45874554
resolved "https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b"

0 commit comments

Comments
 (0)