Skip to content

Commit dd9117e

Browse files
authored
[Flight] Source Map Actions in Reference Node Loader Transforms (#30755)
Follow up to #30741. This is just for the reference Webpack implementation. If there is a source map associated with a Node ESM loader, we generate new source map entries for every `registerServerReference` call. To avoid messing too much with it, this doesn't rewrite the original mappings. It just reads them while finding each of the exports in the original mappings. We need to read all since whatever we append at the end is relative. Then we just generate new appended entries at the end. For the location I picked the location of the local name identifier. Since that's the name of the function and that gives us a source map name index. It means it jumps to the name rather than the beginning of the function declaration. It could be made more clever like finding a local function definition if it is reexported. We could also point to the line/column of the function declaration rather than the identifier but point to the name index of the identifier name. Now jumping to definition works in the fixture. <img width="574" alt="Screenshot 2024-08-20 at 2 49 07 PM" src="https://github.com/user-attachments/assets/7710f0e6-2cee-4aad-8d4c-ae985f8289eb"> Unfortunately this technique doesn't seem to work in Firefox nor Safari. They don't apply the source map for jumping to the definition.
1 parent dc32c7f commit dd9117e

File tree

6 files changed

+1780
-808
lines changed

6 files changed

+1780
-808
lines changed

fixtures/flight/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"react-dev-utils": "^12.0.1",
5050
"react-dom": "experimental",
5151
"react-refresh": "^0.11.0",
52+
"react-server-dom-webpack": "experimental",
5253
"resolve": "^1.20.0",
5354
"resolve-url-loader": "^4.0.0",
5455
"sass-loader": "^12.3.0",

fixtures/flight/yarn.lock

Lines changed: 1411 additions & 755 deletions
Large diffs are not rendered by default.

packages/react-server-dom-webpack/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@
106106
},
107107
"dependencies": {
108108
"acorn-loose": "^8.3.0",
109-
"neo-async": "^2.6.1"
109+
"neo-async": "^2.6.1",
110+
"webpack-sources": "^3.2.0"
110111
}
111112
}

0 commit comments

Comments
 (0)