Skip to content

Commit db9e5c9

Browse files
author
Brian Vaughn
committed
Updated all GitHub links to point to React repo
1 parent a6aba5a commit db9e5c9

File tree

11 files changed

+20
-15
lines changed

11 files changed

+20
-15
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#### Improved performance
1818
The legacy DevTools extension used to add significant performance overhead, making it unusable for some larger React applications. That overhead has been effectively eliminated in version 4.
1919

20-
[Learn more](https://github.com/bvaughn/react-devtools-experimental/blob/master/OVERVIEW.md) about the performance optimizations that made this possible.
20+
[Learn more](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md) about the performance optimizations that made this possible.
2121

2222
#### Component stacks
2323

@@ -43,7 +43,7 @@ Filter preferences are remembered between sessions.
4343

4444
#### No more in-line props
4545

46-
Components in the tree no longer show in-line props. This was done to [make DevTools faster](https://github.com/bvaughn/react-devtools-experimental/blob/master/OVERVIEW.md) and to make it easier to browse larger component trees.
46+
Components in the tree no longer show in-line props. This was done to [make DevTools faster](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md) and to make it easier to browse larger component trees.
4747

4848
You can view a component's props, state, and hooks by selecting it:
4949

OVERVIEW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ Even when dealing with a single component, serializing deeply nested properties
229229

230230
Hooks present a unique challenge for the DevTools because of the concept of _custom_ hooks. (A custom hook is essentially any function that calls at least one of the built-in hooks. By convention custom hooks also have names that begin with "use".)
231231

232-
So how does DevTools identify custom functions called from within third party components? It does this by temporarily overriding React's built-in hooks and shallow rendering the component in question. Whenever one of the (overridden) built-in hooks are called, it parses the call stack to spot potential custom hooks (functions between the component itself and the built-in hook). This approach enables it to build a tree structure describing all of the calls to both the built-in _and_ custom hooks, along with the values passed to those hooks. (If you're interested in learning more about this, [here is the source code](https://github.com/bvaughn/react-devtools-experimental/blob/master/src/backend/ReactDebugHooks.js).)
232+
So how does DevTools identify custom functions called from within third party components? It does this by temporarily overriding React's built-in hooks and shallow rendering the component in question. Whenever one of the (overridden) built-in hooks are called, it parses the call stack to spot potential custom hooks (functions between the component itself and the built-in hook). This approach enables it to build a tree structure describing all of the calls to both the built-in _and_ custom hooks, along with the values passed to those hooks. (If you're interested in learning more about this, [here is the source code](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js).)
233233

234234
> **Note**: DevTools obtains hooks info by re-rendering a component.
235235
> Breakpoints will be invoked during this additional (shallow) render,

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ yarn build:extension:firefox # builds at "shells/browser/firefox/build"
2020

2121
# Support
2222

23-
As this extension is in a beta period, it is not officially supported. However if you find a bug, we'd appreciate you reporting it as a [GitHub issue](https://github.com/bvaughn/react-devtools-experimental/issues/new) with repro instructions.
23+
As this extension is in a beta period, it is not officially supported. However if you find a bug, we'd appreciate you reporting it as a [GitHub issue](https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools) with repro instructions.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"build:extension:firefox:dev": "cross-env NODE_ENV=development node ./shells/browser/firefox/build",
4747
"build:standalone": "cd packages/react-devtools-core && yarn run build",
4848
"deploy": "yarn run deploy:demo && yarn run deploy:chrome && yarn run deploy:firefox",
49-
"deploy:demo": "yarn run build:demo && cd shells/dev/ && now deploy && now alias react-devtools-experimental",
49+
"deploy:demo": "yarn run build:inline && yarn run build:demo && cd shells/dev/ && now deploy && now alias react-devtools-experimental",
5050
"deploy:chrome": "node ./shells/browser/chrome/deploy",
5151
"deploy:firefox": "node ./shells/browser/firefox/deploy",
5252
"linc": "lint-staged",

packages/react-devtools-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"license": "MIT",
66
"main": "./dist/backend.js",
77
"repository": {
8-
"url": "https://github.com/bvaughn/react-devtools-experimental.git",
8+
"url": "https://github.com/facebook/react.git",
99
"type": "git"
1010
},
1111
"files": [

packages/react-devtools-inline/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"license": "MIT",
66
"main": "./dist/backend.js",
77
"repository": {
8-
"url": "https://github.com/bvaughn/react-devtools-experimental.git",
8+
"url": "https://github.com/facebook/react.git",
99
"type": "git"
1010
},
1111
"files": [

packages/react-devtools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "Use react-devtools outside of the browser",
55
"license": "MIT",
66
"repository": {
7-
"url": "https://github.com/bvaughn/react-devtools-experimental.git",
7+
"url": "https://github.com/facebook/react.git",
88
"type": "git"
99
},
1010
"bin": {

shells/browser/shared/deploy.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@ <h1>
1818

1919
<h3>
2020
Created on <strong>%date%</strong> from
21-
<a href="http://github.com/bvaughn/react-devtools-experimental/commit/%commit%"><code>%commit%</code></a>
21+
<a href="http://github.com/facebook/react/commit/%commit%"><code>%commit%</code></a>
2222
</h3>
2323

2424
<p>
25-
This is a preview build of an <a href="https://github.com/bvaughn/react-devtools-experimental">unreleased DevTools extension</a>.
26-
It has no developer support.
25+
This is a preview build of the <a href="https://github.com/facebook/react">React DevTools extension</a>.
2726
</p>
2827

2928
<h2>Installation instructions</h2>
@@ -34,7 +33,7 @@ <h2>Installation instructions</h2>
3433

3534
<h2>Bug reports</h2>
3635
<p>
37-
Please report bugs as <a href="https://github.com/bvaughn/react-devtools-experimental/issues/new?labels=bug">GitHub issues</a>.
36+
Please report bugs as <a href="https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools">GitHub issues</a>.
3837
Please include all of the info required to reproduce the bug (e.g. links, code, instructions).
3938
</p>
4039

shells/utils.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ function getGitCommit() {
99
}
1010

1111
function getGitHubURL() {
12-
// TODO potentially replace this with an fb.me URL (assuming it can forward the query params)
12+
// HACK We are in the middle of migrating;
13+
// For now, forcefully direct people to the new repository-
14+
// even though we may be deploying from the old repo.
15+
return 'https://github.com/facebook/react';
16+
17+
/* TODO potentially replace this with an fb.me URL (assuming it can forward the query params)
1318
const url = execSync('git remote get-url origin')
1419
.toString()
1520
.trim();
@@ -22,6 +27,7 @@ function getGitHubURL() {
2227
.replace('git@', 'https://')
2328
.replace('.git', '');
2429
}
30+
*/
2531
}
2632

2733
function getVersionString() {

src/constants.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY =
2626
export const PROFILER_EXPORT_VERSION = 4;
2727

2828
export const CHANGE_LOG_URL =
29-
'https://github.com/bvaughn/react-devtools-experimental/blob/master/CHANGELOG.md';
29+
'https://github.com/facebook/react/blob/master/packages/react-devtools/CHANGELOG.md';
3030

3131
// HACK
3232
//

0 commit comments

Comments
 (0)