Skip to content

Commit d75b439

Browse files
sebmarkbagesebmarkbage
committed
Include Component Props in Performance Track (#33655)
Similar to how we can include a Promise resolved value we can include Component Props. For now I left out props for Client Components for perf unless they error. I'll try it for Client Components in general in a separate PR. <img width="730" alt="Screenshot 2025-06-26 at 5 54 29 PM" src="https://github.com/user-attachments/assets/f0c86911-2899-4b5f-b45f-5326bdbc630f" /> <img width="762" alt="Screenshot 2025-06-26 at 5 54 12 PM" src="https://github.com/user-attachments/assets/97540d19-5950-4346-99e6-066af086040e" /> DiffTrain build for [d2a288f](d2a288f)
1 parent 54d04be commit d75b439

24 files changed

+708
-96
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-9b2a545b-20250625
1+
19.2.0-native-fb-d2a288fe-20250627

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7394847dfb7bbfabb08d4e5bae119e8e>>
10+
* @generated SignedSource<<dfcc6591110013fb80e4e831bedce59a>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
407+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<46bb020febbefb5857caf0a4a28f6e6c>>
10+
* @generated SignedSource<<f52423f41942ed63f49af88f43f2507b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
206+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<46bb020febbefb5857caf0a4a28f6e6c>>
10+
* @generated SignedSource<<f52423f41942ed63f49af88f43f2507b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
206+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 161 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6c1a8b9a30fef259200b63e7b175baf0>>
10+
* @generated SignedSource<<e355cf9905136d20848cebe371abcfc9>>
1111
*/
1212

1313
/*
@@ -3862,6 +3862,147 @@ __DEV__ &&
38623862
topLevelEventsToReactNames.set(domEventName, reactName);
38633863
registerTwoPhaseEvent(reactName, [domEventName]);
38643864
}
3865+
function getArrayKind(array) {
3866+
for (var kind = EMPTY_ARRAY, i = 0; i < array.length; i++) {
3867+
var value = array[i];
3868+
if ("object" === typeof value && null !== value)
3869+
if (
3870+
isArrayImpl(value) &&
3871+
2 === value.length &&
3872+
"string" === typeof value[0]
3873+
) {
3874+
if (kind !== EMPTY_ARRAY && kind !== ENTRIES_ARRAY)
3875+
return COMPLEX_ARRAY;
3876+
kind = ENTRIES_ARRAY;
3877+
} else return COMPLEX_ARRAY;
3878+
else {
3879+
if (
3880+
"function" === typeof value ||
3881+
("string" === typeof value && 50 < value.length) ||
3882+
(kind !== EMPTY_ARRAY && kind !== PRIMITIVE_ARRAY)
3883+
)
3884+
return COMPLEX_ARRAY;
3885+
kind = PRIMITIVE_ARRAY;
3886+
}
3887+
}
3888+
return kind;
3889+
}
3890+
function addObjectToProperties(object, properties, indent) {
3891+
for (var key in object)
3892+
hasOwnProperty.call(object, key) &&
3893+
"_" !== key[0] &&
3894+
addValueToProperties(key, object[key], properties, indent);
3895+
}
3896+
function addValueToProperties(propertyName, value, properties, indent) {
3897+
switch (typeof value) {
3898+
case "object":
3899+
if (null === value) {
3900+
value = "null";
3901+
break;
3902+
} else {
3903+
if (value.$$typeof === REACT_ELEMENT_TYPE) {
3904+
var typeName = getComponentNameFromType(value.type) || "\u2026",
3905+
key = value.key;
3906+
value = value.props;
3907+
var propsKeys = Object.keys(value),
3908+
propsLength = propsKeys.length;
3909+
if (null == key && 0 === propsLength) {
3910+
value = "<" + typeName + " />";
3911+
break;
3912+
}
3913+
if (
3914+
3 > indent ||
3915+
(1 === propsLength &&
3916+
"children" === propsKeys[0] &&
3917+
null == key)
3918+
) {
3919+
value = "<" + typeName + " \u2026 />";
3920+
break;
3921+
}
3922+
properties.push([
3923+
"\u00a0\u00a0".repeat(indent) + propertyName,
3924+
"<" + typeName
3925+
]);
3926+
null !== key &&
3927+
addValueToProperties("key", key, properties, indent + 1);
3928+
propertyName = !1;
3929+
for (var propKey in value)
3930+
"children" === propKey
3931+
? null != value.children &&
3932+
(!isArrayImpl(value.children) ||
3933+
0 < value.children.length) &&
3934+
(propertyName = !0)
3935+
: hasOwnProperty.call(value, propKey) &&
3936+
"_" !== propKey[0] &&
3937+
addValueToProperties(
3938+
propKey,
3939+
value[propKey],
3940+
properties,
3941+
indent + 1
3942+
);
3943+
properties.push([
3944+
"",
3945+
propertyName ? ">\u2026</" + typeName + ">" : "/>"
3946+
]);
3947+
return;
3948+
}
3949+
typeName = Object.prototype.toString.call(value);
3950+
typeName = typeName.slice(8, typeName.length - 1);
3951+
if ("Array" === typeName)
3952+
if (
3953+
((propKey = getArrayKind(value)),
3954+
propKey === PRIMITIVE_ARRAY || propKey === EMPTY_ARRAY)
3955+
) {
3956+
value = JSON.stringify(value);
3957+
break;
3958+
} else if (propKey === ENTRIES_ARRAY) {
3959+
properties.push([
3960+
"\u00a0\u00a0".repeat(indent) + propertyName,
3961+
""
3962+
]);
3963+
for (
3964+
propertyName = 0;
3965+
propertyName < value.length;
3966+
propertyName++
3967+
)
3968+
(typeName = value[propertyName]),
3969+
addValueToProperties(
3970+
typeName[0],
3971+
typeName[1],
3972+
properties,
3973+
indent + 1
3974+
);
3975+
return;
3976+
}
3977+
"Object" === typeName &&
3978+
(propKey = Object.getPrototypeOf(value)) &&
3979+
"function" === typeof propKey.constructor &&
3980+
(typeName = propKey.constructor.name);
3981+
properties.push([
3982+
"\u00a0\u00a0".repeat(indent) + propertyName,
3983+
"Object" === typeName ? (3 > indent ? "" : "\u2026") : typeName
3984+
]);
3985+
3 > indent && addObjectToProperties(value, properties, indent + 1);
3986+
return;
3987+
}
3988+
case "function":
3989+
value = "" === value.name ? "() => {}" : value.name + "() {}";
3990+
break;
3991+
case "string":
3992+
value =
3993+
value === OMITTED_PROP_ERROR ? "\u2026" : JSON.stringify(value);
3994+
break;
3995+
case "undefined":
3996+
value = "undefined";
3997+
break;
3998+
case "boolean":
3999+
value = value ? "true" : "false";
4000+
break;
4001+
default:
4002+
value = String(value);
4003+
}
4004+
properties.push(["\u00a0\u00a0".repeat(indent) + propertyName, value]);
4005+
}
38654006
function setCurrentTrackFromLanes(lanes) {
38664007
currentTrack =
38674008
lanes & 127
@@ -3970,6 +4111,10 @@ __DEV__ &&
39704111
: String(capturedValue)
39714112
]);
39724113
}
4114+
null !== fiber.key &&
4115+
addValueToProperties("key", fiber.key, properties, 0);
4116+
null !== fiber.memoizedProps &&
4117+
addObjectToProperties(fiber.memoizedProps, properties, 0);
39734118
null == debugTask && (debugTask = fiber._debugTask);
39744119
fiber = {
39754120
start: startTime,
@@ -4023,6 +4168,10 @@ __DEV__ &&
40234168
: String(error)
40244169
]);
40254170
}
4171+
null !== fiber.key &&
4172+
addValueToProperties("key", fiber.key, selfTime, 0);
4173+
null !== fiber.memoizedProps &&
4174+
addObjectToProperties(fiber.memoizedProps, selfTime, 0);
40264175
startTime = {
40274176
start: startTime,
40284177
end: endTime,
@@ -26070,6 +26219,12 @@ __DEV__ &&
2607026219
}
2607126220
console.error(error);
2607226221
},
26222+
OMITTED_PROP_ERROR =
26223+
"This object has been omitted by React in the console log to avoid sending too much data from the server. Try logging smaller or more specific objects.",
26224+
EMPTY_ARRAY = 0,
26225+
COMPLEX_ARRAY = 1,
26226+
PRIMITIVE_ARRAY = 2,
26227+
ENTRIES_ARRAY = 3,
2607326228
supportsUserTiming =
2607426229
"undefined" !== typeof console &&
2607526230
"function" === typeof console.timeStamp,
@@ -28651,11 +28806,11 @@ __DEV__ &&
2865128806
};
2865228807
(function () {
2865328808
var isomorphicReactPackageVersion = React.version;
28654-
if ("19.2.0-native-fb-9b2a545b-20250625" !== isomorphicReactPackageVersion)
28809+
if ("19.2.0-native-fb-d2a288fe-20250627" !== isomorphicReactPackageVersion)
2865528810
throw Error(
2865628811
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2865728812
(isomorphicReactPackageVersion +
28658-
"\n - react-dom: 19.2.0-native-fb-9b2a545b-20250625\nLearn more: https://react.dev/warnings/version-mismatch")
28813+
"\n - react-dom: 19.2.0-native-fb-d2a288fe-20250627\nLearn more: https://react.dev/warnings/version-mismatch")
2865928814
);
2866028815
})();
2866128816
("function" === typeof Map &&
@@ -28692,10 +28847,10 @@ __DEV__ &&
2869228847
!(function () {
2869328848
var internals = {
2869428849
bundleType: 1,
28695-
version: "19.2.0-native-fb-9b2a545b-20250625",
28850+
version: "19.2.0-native-fb-d2a288fe-20250627",
2869628851
rendererPackageName: "react-dom",
2869728852
currentDispatcherRef: ReactSharedInternals,
28698-
reconcilerVersion: "19.2.0-native-fb-9b2a545b-20250625"
28853+
reconcilerVersion: "19.2.0-native-fb-d2a288fe-20250627"
2869928854
};
2870028855
internals.overrideHookState = overrideHookState;
2870128856
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -28833,5 +28988,5 @@ __DEV__ &&
2883328988
listenToAllSupportedEvents(container);
2883428989
return new ReactDOMHydrationRoot(initialChildren);
2883528990
};
28836-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
28991+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";
2883728992
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<db4f84395e63c6f6c9bb77172c324ba2>>
10+
* @generated SignedSource<<e0b48ecf6a671f7b735d65f0789ae200>>
1111
*/
1212

1313
/*
@@ -17121,14 +17121,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1712117121
};
1712217122
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1712317123
if (
17124-
"19.2.0-native-fb-9b2a545b-20250625" !==
17124+
"19.2.0-native-fb-d2a288fe-20250627" !==
1712517125
isomorphicReactPackageVersion$jscomp$inline_2023
1712617126
)
1712717127
throw Error(
1712817128
formatProdErrorMessage(
1712917129
527,
1713017130
isomorphicReactPackageVersion$jscomp$inline_2023,
17131-
"19.2.0-native-fb-9b2a545b-20250625"
17131+
"19.2.0-native-fb-d2a288fe-20250627"
1713217132
)
1713317133
);
1713417134
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17150,10 +17150,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1715017150
};
1715117151
var internals$jscomp$inline_2542 = {
1715217152
bundleType: 0,
17153-
version: "19.2.0-native-fb-9b2a545b-20250625",
17153+
version: "19.2.0-native-fb-d2a288fe-20250627",
1715417154
rendererPackageName: "react-dom",
1715517155
currentDispatcherRef: ReactSharedInternals,
17156-
reconcilerVersion: "19.2.0-native-fb-9b2a545b-20250625"
17156+
reconcilerVersion: "19.2.0-native-fb-d2a288fe-20250627"
1715717157
};
1715817158
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1715917159
var hook$jscomp$inline_2543 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17251,4 +17251,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1725117251
listenToAllSupportedEvents(container);
1725217252
return new ReactDOMHydrationRoot(initialChildren);
1725317253
};
17254-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
17254+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0b0d2df6091656622e20f207eb80bdb3>>
10+
* @generated SignedSource<<efa93f01693dac89c31bcf46d19db1a4>>
1111
*/
1212

1313
/*
@@ -19053,14 +19053,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1905319053
};
1905419054
var isomorphicReactPackageVersion$jscomp$inline_2261 = React.version;
1905519055
if (
19056-
"19.2.0-native-fb-9b2a545b-20250625" !==
19056+
"19.2.0-native-fb-d2a288fe-20250627" !==
1905719057
isomorphicReactPackageVersion$jscomp$inline_2261
1905819058
)
1905919059
throw Error(
1906019060
formatProdErrorMessage(
1906119061
527,
1906219062
isomorphicReactPackageVersion$jscomp$inline_2261,
19063-
"19.2.0-native-fb-9b2a545b-20250625"
19063+
"19.2.0-native-fb-d2a288fe-20250627"
1906419064
)
1906519065
);
1906619066
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19082,10 +19082,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1908219082
};
1908319083
var internals$jscomp$inline_2268 = {
1908419084
bundleType: 0,
19085-
version: "19.2.0-native-fb-9b2a545b-20250625",
19085+
version: "19.2.0-native-fb-d2a288fe-20250627",
1908619086
rendererPackageName: "react-dom",
1908719087
currentDispatcherRef: ReactSharedInternals,
19088-
reconcilerVersion: "19.2.0-native-fb-9b2a545b-20250625",
19088+
reconcilerVersion: "19.2.0-native-fb-d2a288fe-20250627",
1908919089
getLaneLabelMap: function () {
1909019090
for (
1909119091
var map = new Map(), lane = 1, index$331 = 0;
@@ -19198,4 +19198,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1919819198
listenToAllSupportedEvents(container);
1919919199
return new ReactDOMHydrationRoot(initialChildren);
1920019200
};
19201-
exports.version = "19.2.0-native-fb-9b2a545b-20250625";
19201+
exports.version = "19.2.0-native-fb-d2a288fe-20250627";

0 commit comments

Comments
 (0)