Use the start time of the transition or the previous fallback as the basis for timeouts

If some has already elapsed we should wait less.

Author: sebmarkbage

packages/react-art/src/ReactFiberConfigART.js

@@ -615,7 +615,7 @@ export function suspendInstance(instance, type, props) {}
 
 export function suspendOnActiveViewTransition(container) {}
 
-export function waitForCommitToBeReady() {
+export function waitForCommitToBeReady(timeoutOffset) {
   return null;
 }
 

packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js

@@ -6067,7 +6067,9 @@ export function suspendOnActiveViewTransition(rootContainer: Container): void {
   activeViewTransition.finished.then(ping, ping);
 }
 
-export function waitForCommitToBeReady(): null | ((() => void) => () => void) {
+export function waitForCommitToBeReady(
+  timeoutOffset: number,
+): null | ((() => void) => () => void) {
   if (suspendedState === null) {
     throw new Error(
       'Internal React Error: suspendedState null when it was expected to exists. Please report this as a React bug.',
@@ -6102,7 +6104,7 @@ export function waitForCommitToBeReady(): null | ((() => void) => () => void) {
           state.unsuspend = null;
           unsuspend();
         }
-      }, 60000); // one minute
+      }, 60000 + timeoutOffset); // one minute
 
       state.unsuspend = commit;
 

packages/react-native-renderer/src/ReactFiberConfigFabric.js

@@ -612,7 +612,7 @@ export function suspendInstance(
 
 export function suspendOnActiveViewTransition(container: Container): void {}
 
-export function waitForCommitToBeReady(): null {
+export function waitForCommitToBeReady(timeoutOffset: number): null {
   return null;
 }
 

packages/react-native-renderer/src/ReactFiberConfigNative.js

@@ -788,7 +788,7 @@ export function suspendInstance(
 
 export function suspendOnActiveViewTransition(container: Container): void {}
 
-export function waitForCommitToBeReady(): null {
+export function waitForCommitToBeReady(timeoutOffset: number): null {
   return null;
 }
 

packages/react-noop-renderer/src/createReactNoop.js

@@ -361,9 +361,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     }
   }
 
-  function waitForCommitToBeReady():
-    | ((commit: () => mixed) => () => void)
-    | null {
+  function waitForCommitToBeReady(
+    timeoutOffset: number,
+  ): ((commit: () => mixed) => () => void) | null {
     const subscription = suspenseyCommitSubscription;
     if (subscription !== null) {
       suspenseyCommitSubscription = null;

packages/react-reconciler/src/ReactFiberWorkLoop.js

@@ -1505,10 +1505,18 @@ function commitRootWhenReady(
         suspendOnActiveViewTransition(root.containerInfo);
       }
     }
+    // For timeouts we use the previous fallback commit for retries and
+    // the start time of the transition for transitions. This offset
+    // represents the time already passed.
+    const timeoutOffset = includesOnlyRetries(lanes)
+      ? globalMostRecentFallbackTime - now()
+      : includesOnlyTransitions(lanes)
+        ? globalMostRecentTransitionTime - now()
+        : 0;
     // At the end, ask the renderer if it's ready to commit, or if we should
     // suspend. If it's not ready, it will return a callback to subscribe to
     // a ready event.
-    const schedulePendingCommit = waitForCommitToBeReady();
+    const schedulePendingCommit = waitForCommitToBeReady(timeoutOffset);
     if (schedulePendingCommit !== null) {
       // NOTE: waitForCommitToBeReady returns a subscribe function so that we
       // only allocate a function if the commit isn't ready yet. The other

packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.internal.js

@@ -109,7 +109,7 @@ describe('ReactFiberHostContext', () => {
       startSuspendingCommit() {},
       suspendInstance(instance, type, props) {},
       suspendOnActiveViewTransition(container) {},
-      waitForCommitToBeReady() {
+      waitForCommitToBeReady(timeoutOffset: number) {
         return null;
       },
       supportsMutation: true,

packages/react-test-renderer/src/ReactFiberConfigTestHost.js

@@ -571,7 +571,7 @@ export function suspendInstance(
 
 export function suspendOnActiveViewTransition(container: Container): void {}
 
-export function waitForCommitToBeReady(): null {
+export function waitForCommitToBeReady(timeoutOffset: number): null {
   return null;
 }