Skip to content

Commit d172311

Browse files
committed
Put .server.js at the end of bundle filenames
1 parent 1a24223 commit d172311

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-webpack-writer.browser.server.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-webpack-writer.browser.production.min.server.js');
55
} else {
6-
module.exports = require('./cjs/react-server-dom-webpack-writer.browser.server.development.js');
6+
module.exports = require('./cjs/react-server-dom-webpack-writer.browser.development.server.js');
77
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-server-dom-webpack-writer.node.server.production.min.js');
4+
module.exports = require('./cjs/react-server-dom-webpack-writer.node.production.min.server.js');
55
} else {
6-
module.exports = require('./cjs/react-server-dom-webpack-writer.node.server.development.js');
6+
module.exports = require('./cjs/react-server-dom-webpack-writer.node.development.server.js');
77
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
if (process.env.NODE_ENV === 'production') {
4-
module.exports = require('./cjs/react-unstable-index.server.production.min.js');
4+
module.exports = require('./cjs/react-unstable-index.production.min.server.js');
55
} else {
6-
module.exports = require('./cjs/react-unstable-index.server.development.js');
6+
module.exports = require('./cjs/react-unstable-index.development.server.js');
77
}

scripts/rollup/bundles.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,7 @@ deepFreeze(bundles);
834834
deepFreeze(bundleTypes);
835835
deepFreeze(moduleTypes);
836836

837-
function getFilename(bundle, bundleType) {
837+
function getOriginalFilename(bundle, bundleType) {
838838
let name = bundle.entry;
839839
const globalName = bundle.global;
840840
// we do this to replace / to -, for react-dom/server
@@ -871,6 +871,18 @@ function getFilename(bundle, bundleType) {
871871
}
872872
}
873873

874+
function getFilename(bundle, bundleType) {
875+
const originalFilename = getOriginalFilename(bundle, bundleType);
876+
if (originalFilename.indexOf('.server.') !== -1) {
877+
// Ensure .server.js is the final suffix.
878+
// This is important for the Server tooling convention.
879+
return originalFilename
880+
.replace('.server.', '.')
881+
.replace('.js', '.server.js');
882+
}
883+
return originalFilename;
884+
}
885+
874886
module.exports = {
875887
bundleTypes,
876888
moduleTypes,

0 commit comments

Comments
 (0)