Skip to content

Commit ccc3d6f

Browse files
committed
[compiler:babel] Don't read config files when not running as part of
user's pipeline When the user app has a babel.config file that is missing the compiler, strange things happen as babel does some strange merging of options from the user's config and in various callsites like in our eslint rule and healthcheck script. To minimize odd behavior, we default to not reading the user's babel.config Fixes #29135 ghstack-source-id: d6fdc43 Pull Request resolved: #29211
1 parent 2e15dae commit ccc3d6f

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

compiler/packages/babel-plugin-react-compiler/src/Babel/RunReactCompilerBabelPlugin.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ export function runBabelPluginReactCompiler(
3636
"babel-plugin-fbt-runtime",
3737
],
3838
sourceType: "module",
39+
configFile: false,
40+
babelrc: false,
3941
});
4042
invariant(
4143
result?.code != null,

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ const rule: Rule.RuleModule = {
143143
[BabelPluginReactCompiler, options],
144144
],
145145
sourceType: "module",
146+
configFile: false,
147+
babelrc: false,
146148
});
147149
} catch (err) {
148150
if (isReactCompilerError(err) && Array.isArray(err.details)) {

compiler/packages/react-compiler-healthcheck/src/checks/reactCompiler.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ function runBabelPluginReactCompiler(
8585
retainLines: true,
8686
plugins: [[BabelPluginReactCompiler, options]],
8787
sourceType: "module",
88+
configFile: false,
89+
babelrc: false,
8890
});
8991
if (result?.code == null) {
9092
throw new Error(

compiler/packages/snap/src/compiler.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,8 @@ export async function transformFixtureInput(
333333
sourceType: "module",
334334
ast: includeEvaluator,
335335
cloneInputAst: includeEvaluator,
336+
configFile: false,
337+
babelrc: false,
336338
});
337339
invariant(
338340
forgetResult?.code != null,
@@ -355,6 +357,8 @@ export async function transformFixtureInput(
355357
const result = transformFromAstSync(forgetResult.ast, forgetOutput, {
356358
presets,
357359
filename: virtualFilepath,
360+
configFile: false,
361+
babelrc: false,
358362
});
359363
if (result?.code == null) {
360364
return {
@@ -379,6 +383,8 @@ export async function transformFixtureInput(
379383
const result = transformFromAstSync(inputAst, input, {
380384
presets,
381385
filename: virtualFilepath,
386+
configFile: false,
387+
babelrc: false,
382388
});
383389

384390
if (result?.code == null) {

0 commit comments

Comments
 (0)