Skip to content

Commit c8acb01

Browse files
mondaychenmondaychen
committed
(patch)[DevTools] bug fix: backend injection logic not working for undocked devtools window (#26665)
bugfix for #26492 This bug would cause users unable to use the devtools (component tree empty). The else-if logic is broken when user switch to undocked devtools mode (separate window) because `sender.tab` would exist in that case. <img width="314" alt="image" src="https://user-images.githubusercontent.com/1001890/232930094-05a74445-9189-4d50-baf1-a0360b29ef7e.png"> Tested on Chrome with a local build DiffTrain build for commit 96fd2fb.
1 parent ef915c1 commit c8acb01

File tree

13 files changed

+19
-19
lines changed

13 files changed

+19
-19
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23745,7 +23745,7 @@ function createFiberRoot(
2374523745
return root;
2374623746
}
2374723747

23748-
var ReactVersion = "18.3.0-next-d8089f2cf-20230418";
23748+
var ReactVersion = "18.3.0-next-96fd2fb72-20230418";
2374923749

2375023750
// Might add PROFILE later.
2375123751

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8587,7 +8587,7 @@ var devToolsConfig$jscomp$inline_1023 = {
85878587
throw Error("TestRenderer does not support findFiberByHostInstance()");
85888588
},
85898589
bundleType: 0,
8590-
version: "18.3.0-next-d8089f2cf-20230418",
8590+
version: "18.3.0-next-96fd2fb72-20230418",
85918591
rendererPackageName: "react-test-renderer"
85928592
};
85938593
var internals$jscomp$inline_1206 = {
@@ -8618,7 +8618,7 @@ var internals$jscomp$inline_1206 = {
86188618
scheduleRoot: null,
86198619
setRefreshHandler: null,
86208620
getCurrentFiber: null,
8621-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
8621+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
86228622
};
86238623
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86248624
var hook$jscomp$inline_1207 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9013,7 +9013,7 @@ var devToolsConfig$jscomp$inline_1065 = {
90139013
throw Error("TestRenderer does not support findFiberByHostInstance()");
90149014
},
90159015
bundleType: 0,
9016-
version: "18.3.0-next-d8089f2cf-20230418",
9016+
version: "18.3.0-next-96fd2fb72-20230418",
90179017
rendererPackageName: "react-test-renderer"
90189018
};
90199019
var internals$jscomp$inline_1247 = {
@@ -9044,7 +9044,7 @@ var internals$jscomp$inline_1247 = {
90449044
scheduleRoot: null,
90459045
setRefreshHandler: null,
90469046
getCurrentFiber: null,
9047-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
9047+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
90489048
};
90499049
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90509050
var hook$jscomp$inline_1248 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-d8089f2cf-20230418";
30+
var ReactVersion = "18.3.0-next-96fd2fb72-20230418";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-d8089f2cf-20230418";
642+
exports.version = "18.3.0-next-96fd2fb72-20230418";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-d8089f2cf-20230418";
645+
exports.version = "18.3.0-next-96fd2fb72-20230418";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d8089f2cf27a17872a13805fce415b74fd3b107e
1+
96fd2fb726130d2980e6d450f5d9e468f922b8b9

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27052,7 +27052,7 @@ function createFiberRoot(
2705227052
return root;
2705327053
}
2705427054

27055-
var ReactVersion = "18.3.0-next-d8089f2cf-20230418";
27055+
var ReactVersion = "18.3.0-next-96fd2fb72-20230418";
2705627056

2705727057
function createPortal$1(
2705827058
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9456,7 +9456,7 @@ var roots = new Map(),
94569456
devToolsConfig$jscomp$inline_1047 = {
94579457
findFiberByHostInstance: getInstanceFromNode,
94589458
bundleType: 0,
9459-
version: "18.3.0-next-d8089f2cf-20230418",
9459+
version: "18.3.0-next-96fd2fb72-20230418",
94609460
rendererPackageName: "react-native-renderer",
94619461
rendererConfig: {
94629462
getInspectorDataForViewTag: function () {
@@ -9498,7 +9498,7 @@ var internals$jscomp$inline_1276 = {
94989498
scheduleRoot: null,
94999499
setRefreshHandler: null,
95009500
getCurrentFiber: null,
9501-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
9501+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
95029502
};
95039503
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95049504
var hook$jscomp$inline_1277 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10165,7 +10165,7 @@ var roots = new Map(),
1016510165
devToolsConfig$jscomp$inline_1125 = {
1016610166
findFiberByHostInstance: getInstanceFromNode,
1016710167
bundleType: 0,
10168-
version: "18.3.0-next-d8089f2cf-20230418",
10168+
version: "18.3.0-next-96fd2fb72-20230418",
1016910169
rendererPackageName: "react-native-renderer",
1017010170
rendererConfig: {
1017110171
getInspectorDataForViewTag: function () {
@@ -10220,7 +10220,7 @@ var roots = new Map(),
1022010220
scheduleRoot: null,
1022110221
setRefreshHandler: null,
1022210222
getCurrentFiber: null,
10223-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
10223+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
1022410224
});
1022510225
exports.createPortal = function (children, containerTag) {
1022610226
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27565,7 +27565,7 @@ function createFiberRoot(
2756527565
return root;
2756627566
}
2756727567

27568-
var ReactVersion = "18.3.0-next-d8089f2cf-20230418";
27568+
var ReactVersion = "18.3.0-next-96fd2fb72-20230418";
2756927569

2757027570
function createPortal$1(
2757127571
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9715,7 +9715,7 @@ var roots = new Map(),
97159715
devToolsConfig$jscomp$inline_1102 = {
97169716
findFiberByHostInstance: getInstanceFromTag,
97179717
bundleType: 0,
9718-
version: "18.3.0-next-d8089f2cf-20230418",
9718+
version: "18.3.0-next-96fd2fb72-20230418",
97199719
rendererPackageName: "react-native-renderer",
97209720
rendererConfig: {
97219721
getInspectorDataForViewTag: function () {
@@ -9757,7 +9757,7 @@ var internals$jscomp$inline_1345 = {
97579757
scheduleRoot: null,
97589758
setRefreshHandler: null,
97599759
getCurrentFiber: null,
9760-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
9760+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
97619761
};
97629762
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97639763
var hook$jscomp$inline_1346 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10424,7 +10424,7 @@ var roots = new Map(),
1042410424
devToolsConfig$jscomp$inline_1180 = {
1042510425
findFiberByHostInstance: getInstanceFromTag,
1042610426
bundleType: 0,
10427-
version: "18.3.0-next-d8089f2cf-20230418",
10427+
version: "18.3.0-next-96fd2fb72-20230418",
1042810428
rendererPackageName: "react-native-renderer",
1042910429
rendererConfig: {
1043010430
getInspectorDataForViewTag: function () {
@@ -10479,7 +10479,7 @@ var roots = new Map(),
1047910479
scheduleRoot: null,
1048010480
setRefreshHandler: null,
1048110481
getCurrentFiber: null,
10482-
reconcilerVersion: "18.3.0-next-d8089f2cf-20230418"
10482+
reconcilerVersion: "18.3.0-next-96fd2fb72-20230418"
1048310483
});
1048410484
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1048510485
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)