Nits

facebook · Jan 17, 2019 · c7d8ebc · c7d8ebc
1 parent 62e1048
commit c7d8ebc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/react-dom/src/server/ReactPartialRendererHooks.js b/packages/react-dom/src/server/ReactPartialRendererHooks.js
@@ -93,7 +93,7 @@ function areHookInputsEqual(
       );
     }
   }
-  for (let i = 0; i < nextDeps.length; i++) {
+  for (let i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
     if (is(nextDeps[i], prevDeps[i])) {
       continue;
     }

diff --git a/packages/react-reconciler/src/ReactFiberHooks.js b/packages/react-reconciler/src/ReactFiberHooks.js
@@ -161,7 +161,7 @@ function areHookInputsEqual(
       );
     }
   }
-  for (let i = 0; i < nextDeps.length; i++) {
+  for (let i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
     if (is(nextDeps[i], prevDeps[i])) {
       continue;
     }

diff --git a/packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js b/packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js
@@ -453,7 +453,6 @@ describe('ReactHooks', () => {
         'Previous: [A, B]\n' +
         'Incoming: [A]\n',
     ]);
-    expect(ReactTestRenderer).toHaveYielded(['Did commit: A, B']);
   });
 
   it('warns if switching from dependencies to no dependencies', () => {