Remove DOM injection for HAS_NUMERIC_VALUE flag

Author: gaearon

src/renderers/dom/shared/DOMProperty.js

@@ -100,7 +100,6 @@ var DOMPropertyInjection = {
 
       var propertyInfo = {
         hasBooleanValue: checkMask(propConfig, Injection.HAS_BOOLEAN_VALUE),
-        hasNumericValue: checkMask(propConfig, Injection.HAS_NUMERIC_VALUE),
         hasOverloadedBooleanValue: checkMask(
           propConfig,
           Injection.HAS_OVERLOADED_BOOLEAN_VALUE,
@@ -111,9 +110,7 @@ var DOMPropertyInjection = {
         ),
       };
       invariant(
-        propertyInfo.hasBooleanValue +
-          propertyInfo.hasNumericValue +
-          propertyInfo.hasOverloadedBooleanValue <=
+        propertyInfo.hasBooleanValue + propertyInfo.hasOverloadedBooleanValue <=
           1,
         'DOMProperty: Value can be one of boolean, overloaded boolean, or ' +
           'numeric value, but not a combination: %s',
@@ -286,9 +283,6 @@ var DOMProperty = {
    *
    * hasBooleanValue:
    *   Whether the property should be removed when set to a falsey value.
-   * hasNumericValue:
-   *   Whether the property must be numeric or parse as a numeric and should be
-   *   removed when set to a falsey value.
    * hasOverloadedBooleanValue:
    *   Whether the property can be used as a flag as well as with a value.
    *   Removed when strictly equal to false; present without a value when
@@ -368,30 +362,32 @@ var DOMProperty = {
       : null;
   },
 
-  // Whether the property must be positive numeric or parse as a positive
-  // numeric and should be removed when set to a falsey value.
-  isExpectingPositiveValue(propName) {
-    switch (propName) {
+  shouldIgnoreValue(name, value) {
+    if (value == null) {
+      return true;
+    }
+    switch (name) {
+      // Numeric properties.
+      case 'rowSpan':
+      case 'start':
+        return isNaN(value);
+      // Positive numeric properties.
       case 'cols':
       case 'rows':
       case 'size':
       case 'span':
-        return true;
+        return isNaN(value) || value < 1;
       default:
+        var propertyInfo = DOMProperty.getPropertyInfo(name);
+        if (propertyInfo.hasBooleanValue && !value) {
+          return true;
+        }
+        if (propertyInfo.hasOverloadedBooleanValue && value === false) {
+          return true;
+        }
         return false;
     }
-  },
-
-  shouldIgnoreValue(name, value) {
-    var propertyInfo = DOMProperty.getPropertyInfo(name);
-    return (
-      value == null ||
-      (propertyInfo.hasBooleanValue && !value) ||
-      (propertyInfo.hasNumericValue &&
-        (isNaN(value) ||
-          (DOMProperty.isExpectingPositiveValue(name) && value < 1))) ||
-      (propertyInfo.hasOverloadedBooleanValue && value === false)
-    );
+    return false;
   },
 
   shouldUseProperty(propName) {

src/renderers/dom/shared/HTMLDOMPropertyConfig.js

@@ -14,7 +14,6 @@
 var DOMProperty = require('DOMProperty');
 
 var HAS_BOOLEAN_VALUE = DOMProperty.injection.HAS_BOOLEAN_VALUE;
-var HAS_NUMERIC_VALUE = DOMProperty.injection.HAS_NUMERIC_VALUE;
 var HAS_OVERLOADED_BOOLEAN_VALUE =
   DOMProperty.injection.HAS_OVERLOADED_BOOLEAN_VALUE;
 var HAS_STRING_BOOLEAN_VALUE = DOMProperty.injection.HAS_STRING_BOOLEAN_VALUE;
@@ -35,7 +34,7 @@ var HTMLDOMPropertyConfig = {
     autoPlay: HAS_BOOLEAN_VALUE,
     capture: HAS_BOOLEAN_VALUE,
     checked: HAS_BOOLEAN_VALUE,
-    cols: HAS_NUMERIC_VALUE,
+    cols: 0,
     contentEditable: HAS_STRING_BOOLEAN_VALUE,
     controls: HAS_BOOLEAN_VALUE,
     default: HAS_BOOLEAN_VALUE,
@@ -54,15 +53,15 @@ var HTMLDOMPropertyConfig = {
     readOnly: HAS_BOOLEAN_VALUE,
     required: HAS_BOOLEAN_VALUE,
     reversed: HAS_BOOLEAN_VALUE,
-    rows: HAS_NUMERIC_VALUE,
-    rowSpan: HAS_NUMERIC_VALUE,
+    rows: 0,
+    rowSpan: 0,
     scoped: HAS_BOOLEAN_VALUE,
     seamless: HAS_BOOLEAN_VALUE,
     selected: HAS_BOOLEAN_VALUE,
-    size: HAS_NUMERIC_VALUE,
-    start: HAS_NUMERIC_VALUE,
+    size: 0,
+    start: 0,
     // support for projecting regular DOM Elements via V1 named slots ( shadow dom )
-    span: HAS_NUMERIC_VALUE,
+    span: 0,
     spellCheck: HAS_STRING_BOOLEAN_VALUE,
     // Style must be explicitly set in the attribute list. React components
     // expect a style object