Skip to content

Commit c56b0ed

Browse files
acdliteacdlite
committed
Prerender during same pass if blocked anyway (#30879)
If something suspends in the shell — i.e. we won't replace the suspended content with a fallback — we might as well prerender the siblings during the current render pass, instead of spawning a separate prerender pass. This is implemented by setting the "is prerendering" flag to true whenever we suspend in the shell. But only if we haven't already skipped over some siblings, because if so, then we need to schedule a separate prerender pass regardless. DiffTrain build for commit 66cf2cf.
1 parent 12971be commit c56b0ed

File tree

14 files changed

+62
-44
lines changed

14 files changed

+62
-44
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-e210d081-20240909
1+
19.0.0-native-fb-66cf2cfc-20240910

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6c3c44625d18e331ccc65c0c55888c8e>>
10+
* @generated SignedSource<<f2439c3bc71acb4262fec800dc93b6a8>>
1111
*/
1212

1313
"use strict";
@@ -15057,11 +15057,11 @@ __DEV__ &&
1505715057
(function () {
1505815058
var internals = {
1505915059
bundleType: 1,
15060-
version: "19.0.0-native-fb-e210d081-20240909",
15060+
version: "19.0.0-native-fb-66cf2cfc-20240910",
1506115061
rendererPackageName: "react-test-renderer",
1506215062
currentDispatcherRef: ReactSharedInternals,
1506315063
findFiberByHostInstance: getInstanceFromNode,
15064-
reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
15064+
reconcilerVersion: "19.0.0-native-fb-66cf2cfc-20240910"
1506515065
};
1506615066
internals.overrideHookState = overrideHookState;
1506715067
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -15206,5 +15206,5 @@ __DEV__ &&
1520615206
flushSyncWorkAcrossRoots_impl(0, !0));
1520715207
}
1520815208
};
15209-
exports.version = "19.0.0-native-fb-e210d081-20240909";
15209+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";
1521015210
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9735780e41887579bc9fb1037b24f3b7>>
10+
* @generated SignedSource<<25b7bb8120d9f7b06b97ec9ca396e314>>
1111
*/
1212

1313
"use strict";
@@ -9445,14 +9445,14 @@ function wrapFiber(fiber) {
94459445
}
94469446
var internals$jscomp$inline_1264 = {
94479447
bundleType: 0,
9448-
version: "19.0.0-native-fb-e210d081-20240909",
9448+
version: "19.0.0-native-fb-66cf2cfc-20240910",
94499449
rendererPackageName: "react-test-renderer",
94509450
currentDispatcherRef: ReactSharedInternals,
94519451
findFiberByHostInstance: function (mockNode) {
94529452
mockNode = nodeToInstanceMap.get(mockNode);
94539453
return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
94549454
},
9455-
reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
9455+
reconcilerVersion: "19.0.0-native-fb-66cf2cfc-20240910"
94569456
};
94579457
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94589458
var hook$jscomp$inline_1265 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -9588,4 +9588,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
95889588
flushSyncWorkAcrossRoots_impl(0, !0));
95899589
}
95909590
};
9591-
exports.version = "19.0.0-native-fb-e210d081-20240909";
9591+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ec7b9fb6d11cd3c4624086736a6b7f10>>
10+
* @generated SignedSource<<0de508771b94d6332922c2450b77ad5f>>
1111
*/
1212

1313
"use strict";
@@ -10033,14 +10033,14 @@ function wrapFiber(fiber) {
1003310033
}
1003410034
var internals$jscomp$inline_1139 = {
1003510035
bundleType: 0,
10036-
version: "19.0.0-native-fb-e210d081-20240909",
10036+
version: "19.0.0-native-fb-66cf2cfc-20240910",
1003710037
rendererPackageName: "react-test-renderer",
1003810038
currentDispatcherRef: ReactSharedInternals,
1003910039
findFiberByHostInstance: function (mockNode) {
1004010040
mockNode = nodeToInstanceMap.get(mockNode);
1004110041
return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
1004210042
},
10043-
reconcilerVersion: "19.0.0-native-fb-e210d081-20240909",
10043+
reconcilerVersion: "19.0.0-native-fb-66cf2cfc-20240910",
1004410044
getLaneLabelMap: function () {
1004510045
for (
1004610046
var map = new Map(), lane = 1, index$138 = 0;
@@ -10191,4 +10191,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
1019110191
flushSyncWorkAcrossRoots_impl(0, !0));
1019210192
}
1019310193
};
10194-
exports.version = "19.0.0-native-fb-e210d081-20240909";
10194+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f1d66600931075ca6b105473c9d7b292>>
10+
* @generated SignedSource<<456e029de5fd9f4d0bf68eedd05f7c81>>
1111
*/
1212

1313
"use strict";
@@ -1705,7 +1705,7 @@ __DEV__ &&
17051705
exports.useTransition = function () {
17061706
return resolveDispatcher().useTransition();
17071707
};
1708-
exports.version = "19.0.0-native-fb-e210d081-20240909";
1708+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";
17091709
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17101710
"function" ===
17111711
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<10fca30bfb462f65321542a3f2a854e0>>
10+
* @generated SignedSource<<6d67ec9150a2cc4a4aa7a542b1fcfee9>>
1111
*/
1212

1313
"use strict";
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
580580
exports.useTransition = function () {
581581
return ReactSharedInternals.H.useTransition();
582582
};
583-
exports.version = "19.0.0-native-fb-e210d081-20240909";
583+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<379a1b6951d50e45a36c5de64d4bbc79>>
10+
* @generated SignedSource<<ef3afbee8ae541f05853831879ec8483>>
1111
*/
1212

1313
"use strict";
@@ -584,7 +584,7 @@ exports.useSyncExternalStore = function (
584584
exports.useTransition = function () {
585585
return ReactSharedInternals.H.useTransition();
586586
};
587-
exports.version = "19.0.0-native-fb-e210d081-20240909";
587+
exports.version = "19.0.0-native-fb-66cf2cfc-20240910";
588588
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
589589
"function" ===
590590
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e210d08180a63f42079b91acaa7f6af15eef6d32
1+
66cf2cfc8a8c4b09d2b783fd7302ae6b24150935

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<47a16a847b1cb448c953dd32e6ff6ac5>>
10+
* @generated SignedSource<<a1eb9c1fbcfc31ccea21e968a916b7d1>>
1111
*/
1212

1313
"use strict";
@@ -12265,6 +12265,9 @@ __DEV__ &&
1226512265
}
1226612266
function renderDidSuspendDelayIfPossible() {
1226712267
workInProgressRootExitStatus = RootSuspendedWithDelay;
12268+
workInProgressRootDidSkipSuspendedSiblings ||
12269+
0 !== (workInProgressRootRenderLanes & 60) ||
12270+
(workInProgressRootIsPrerendering = !0);
1226812271
(0 === (workInProgressRootSkippedLanes & 134217727) &&
1226912272
0 === (workInProgressRootInterleavedUpdatedLanes & 134217727)) ||
1227012273
null === workInProgressRoot ||
@@ -17030,11 +17033,11 @@ __DEV__ &&
1703017033
(function () {
1703117034
var internals = {
1703217035
bundleType: 1,
17033-
version: "19.0.0-native-fb-e210d081-20240909",
17036+
version: "19.0.0-native-fb-66cf2cfc-20240910",
1703417037
rendererPackageName: "react-native-renderer",
1703517038
currentDispatcherRef: ReactSharedInternals,
1703617039
findFiberByHostInstance: getInstanceFromNode,
17037-
reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
17040+
reconcilerVersion: "19.0.0-native-fb-66cf2cfc-20240910"
1703817041
};
1703917042
null !== extraDevToolsConfig &&
1704017043
(internals.rendererConfig = extraDevToolsConfig);

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f8a2977a268036ae8166fcdb6e3a75c4>>
10+
* @generated SignedSource<<0957f41cf0c05a8013a5c3aef90921b1>>
1111
*/
1212

1313
"use strict";
@@ -9641,6 +9641,9 @@ function pushAsyncDispatcher() {
96419641
}
96429642
function renderDidSuspendDelayIfPossible() {
96439643
workInProgressRootExitStatus = 4;
9644+
workInProgressRootDidSkipSuspendedSiblings ||
9645+
0 !== (workInProgressRootRenderLanes & 60) ||
9646+
(workInProgressRootIsPrerendering = !0);
96449647
(0 === (workInProgressRootSkippedLanes & 134217727) &&
96459648
0 === (workInProgressRootInterleavedUpdatedLanes & 134217727)) ||
96469649
null === workInProgressRoot ||
@@ -10975,11 +10978,11 @@ batchedUpdatesImpl = function (fn, a) {
1097510978
var roots = new Map(),
1097610979
internals$jscomp$inline_1162 = {
1097710980
bundleType: 0,
10978-
version: "19.0.0-native-fb-e210d081-20240909",
10981+
version: "19.0.0-native-fb-66cf2cfc-20240910",
1097910982
rendererPackageName: "react-native-renderer",
1098010983
currentDispatcherRef: ReactSharedInternals,
1098110984
findFiberByHostInstance: getInstanceFromNode,
10982-
reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
10985+
reconcilerVersion: "19.0.0-native-fb-66cf2cfc-20240910"
1098310986
};
1098410987
null !== extraDevToolsConfig &&
1098510988
(internals$jscomp$inline_1162.rendererConfig = extraDevToolsConfig);

0 commit comments

Comments
 (0)