remove null to 0 transformation

facebook · Apr 2, 2020 · c4e3619 · c4e3619
1 parent ee40b3f
commit c4e3619
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/react-dom/src/events/SyntheticKeyboardEvent.js b/packages/react-dom/src/events/SyntheticKeyboardEvent.js
@@ -16,12 +16,7 @@ import getEventModifierState from './getEventModifierState';
  */
 const SyntheticKeyboardEvent = SyntheticUIEvent.extend({
   key: getEventKey,
-  code: function(event) {
-    if (event.type === 'keydown' || event.type === 'keyup') {
-      return event.code;
-    }
-    return 0;
-  },
+  code: null,
   location: null,
   ctrlKey: null,
   shiftKey: null,

diff --git a/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js
@@ -453,7 +453,7 @@ describe('SyntheticKeyboardEvent', () => {
     });
 
     describe('code', () => {
-      it('returns code on `keydown`, `keyup` and 0 on `keypress`', () => {
+      it('returns code on `keydown`, `keyup` and null on `keypress`', () => {
         let codeDown = null;
         let codeUp = null;
         let codePress = null;
@@ -487,14 +487,14 @@ describe('SyntheticKeyboardEvent', () => {
         );
         node.dispatchEvent(
           new KeyboardEvent('keypress', {
-            charCode: 81,
+            code: 'KeyQ',
             bubbles: true,
             cancelable: true,
           }),
         );
         expect(codeDown).toBe('KeyQ');
         expect(codeUp).toBe('KeyQ');
-        expect(codePress).toBe(0);
+        expect(codePress).toBe(null);
       });
     });
   });