fix[ci]: fixed jest configuration not to skip too many devtools tests

Author: hoxyq

packages/react-devtools-shared/src/__tests__/profilingCache-test.js

@@ -938,7 +938,8 @@ describe('ProfilingCache', () => {
     }
   });
 
-  // @reactVersion = 17.0
+  // @reactVersion >= 17
+  // @reactVersion < 18
   it('should handle unexpectedly shallow suspense trees', () => {
     // This test only runs in v17 because it's a regression test for legacy
     // Suspense behavior, and the implementation details changed in v18.
@@ -967,7 +968,15 @@ describe('ProfilingCache', () => {
           "passiveEffectDuration": null,
           "priorityLevel": "Normal",
           "timestamp": 0,
-          "updaters": null,
+          "updaters": [
+            {
+              "displayName": "render()",
+              "hocDisplayNames": null,
+              "id": 1,
+              "key": null,
+              "type": 11,
+            },
+          ],
         },
       ]
     `);

packages/react-devtools-shared/src/__tests__/transform-react-version-pragma-test.js

@@ -137,14 +137,4 @@ describe('transform-react-version-pragma', () => {
     expect(shouldPass).toBe(true);
     expect(isFocused).toBe(true);
   });
-
-  test('ignore test if no reactVersion', () => {
-    expect(shouldPass).toBe(false);
-    expect(shouldIgnore).toBe(true);
-  });
-
-  test.only('ignore focused test if no reactVersion', () => {
-    expect(shouldPass).toBe(false);
-    expect(shouldIgnore).toBe(true);
-  });
 });

packages/shared/ReactVersion.js

@@ -13,4 +13,4 @@
 // TODO: This module is used both by the release scripts and to expose a version
 // at runtime. We should instead inject the version number as part of the build
 // process, and use the ReactVersions.js module as the single source of truth.
-export default '18.2.0';
+export default '18.3.0';

scripts/babel/transform-react-version-pragma.js

@@ -5,6 +5,7 @@
 const getComments = require('./getComments');
 
 const GATE_VERSION_STR = '@reactVersion ';
+const REACT_VERSION_ENV = process.env.REACT_VERSION;
 
 function transform(babel) {
   const {types: t} = babel;
@@ -75,7 +76,7 @@ function transform(babel) {
                       ? '_test_react_version_focus'
                       : '_test_react_version';
                   expression.arguments = [condition, ...expression.arguments];
-                } else {
+                } else if (REACT_VERSION_ENV) {
                   callee.name = '_test_ignore_for_react_version';
                 }
               }
@@ -96,7 +97,7 @@ function transform(babel) {
                     t.identifier('_test_react_version_focus'),
                     [condition, ...expression.arguments]
                   );
-                } else {
+                } else if (REACT_VERSION_ENV) {
                   statement.expression = t.callExpression(
                     t.identifier('_test_ignore_for_react_version'),
                     expression.arguments

scripts/jest/jest-cli.js

@@ -16,8 +16,6 @@ const devToolsConfig = './scripts/jest/config.build-devtools.js';
 const persistentConfig = './scripts/jest/config.source-persistent.js';
 const buildConfig = './scripts/jest/config.build.js';
 
-const {ReactVersion} = require('../../ReactVersions');
-
 const argv = yargs
   .parserConfiguration({
     // Important: This option tells yargs to move all other options not
@@ -181,13 +179,9 @@ function validateOptions() {
       success = false;
     }
 
-    if (argv.reactVersion) {
-      if (!semver.validRange(argv.reactVersion)) {
-        success = false;
-        logError('please specify a valid version range for --reactVersion');
-      }
-    } else {
-      argv.reactVersion = ReactVersion;
+    if (argv.reactVersion && !semver.validRange(argv.reactVersion)) {
+      success = false;
+      logError('please specify a valid version range for --reactVersion');
     }
   } else {
     if (argv.compactConsole) {

scripts/jest/preprocessor.js

@@ -86,12 +86,7 @@ module.exports = {
       const plugins = (isTestFile ? testOnlyPlugins : sourceOnlyPlugins).concat(
         babelOptions.plugins
       );
-      if (
-        isTestFile &&
-        isInDevToolsPackages &&
-        (process.env.REACT_VERSION ||
-          filePath.match(/\/transform-react-version-pragma-test/))
-      ) {
+      if (isTestFile && isInDevToolsPackages) {
         plugins.push(pathToTransformReactVersionPragma);
       }
       let sourceAst = hermesParser.parse(src, {babel: true});