Reduces the size of ReactDOMSharedIntenrals object representation to …

…save on bundle size
facebook · Apr 5, 2024 · bd85e05 · bd85e05
1 parent b1c3da8
commit bd85e05
Show file tree

Hide file tree

Showing 10 changed files with 111 additions and 104 deletions.
diff --git a/packages/react-dom-bindings/src/client/ReactDOMUpdatePriority.js b/packages/react-dom-bindings/src/client/ReactDOMUpdatePriority.js
@@ -25,15 +25,15 @@ export function setCurrentUpdatePriority(
   // is much longer. I hope this is consistent enough to rely on across builds
   IntentionallyUnusedArgument?: empty,
 ): void {
-  ReactDOMSharedInternals.up = newPriority;
+  ReactDOMSharedInternals.p /* currentUpdatePriority */ = newPriority;
 }
 
 export function getCurrentUpdatePriority(): EventPriority {
-  return ReactDOMSharedInternals.up;
+  return ReactDOMSharedInternals.p; /* currentUpdatePriority */
 }
 
 export function resolveUpdatePriority(): EventPriority {
-  const updatePriority = ReactDOMSharedInternals.up;
+  const updatePriority = ReactDOMSharedInternals.p; /* currentUpdatePriority */
   if (updatePriority !== NoEventPriority) {
     return updatePriority;
   }

diff --git a/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js b/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
@@ -102,8 +102,6 @@ import {validateLinkPropsForStyleResource} from '../shared/ReactDOMResourceValid
 import escapeSelectorAttributeValueInsideDoubleQuotes from './escapeSelectorAttributeValueInsideDoubleQuotes';
 
 import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals';
-const ReactDOMCurrentDispatcher =
-  ReactDOMSharedInternals.ReactDOMCurrentDispatcher;
 
 export type Type = string;
 export type Props = {
@@ -1922,8 +1920,9 @@ function getDocumentFromRoot(root: HoistableRoot): Document {
   return root.ownerDocument || root;
 }
 
-const previousDispatcher = ReactDOMCurrentDispatcher.current;
-ReactDOMCurrentDispatcher.current = {
+const previousDispatcher =
+  ReactDOMSharedInternals.d; /* ReactDOMCurrentDispatcher */
+ReactDOMSharedInternals.d /* ReactDOMCurrentDispatcher */ = {
   prefetchDNS,
   preconnect,
   preload,

diff --git a/packages/react-dom-bindings/src/server/ReactDOMFlightServerHostDispatcher.js b/packages/react-dom-bindings/src/server/ReactDOMFlightServerHostDispatcher.js
@@ -23,11 +23,10 @@ import {
 } from 'react-server/src/ReactFlightServer';
 
 import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals';
-const ReactDOMCurrentDispatcher =
-  ReactDOMSharedInternals.ReactDOMCurrentDispatcher;
 
-const previousDispatcher = ReactDOMCurrentDispatcher.current;
-ReactDOMCurrentDispatcher.current = {
+const previousDispatcher =
+  ReactDOMSharedInternals.d; /* ReactDOMCurrentDispatcher */
+ReactDOMSharedInternals.d /* ReactDOMCurrentDispatcher */ = {
   prefetchDNS,
   preconnect,
   preload,

diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
@@ -83,11 +83,10 @@ import {getValueDescriptorExpectingObjectForWarning} from '../shared/ReactDOMRes
 import {NotPending} from '../shared/ReactDOMFormActions';
 
 import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals';
-const ReactDOMCurrentDispatcher =
-  ReactDOMSharedInternals.ReactDOMCurrentDispatcher;
 
-const previousDispatcher = ReactDOMCurrentDispatcher.current;
-ReactDOMCurrentDispatcher.current = {
+const previousDispatcher =
+  ReactDOMSharedInternals.d; /* ReactDOMCurrentDispatcher */
+ReactDOMSharedInternals.d /* ReactDOMCurrentDispatcher */ = {
   prefetchDNS,
   preconnect,
   preload,

diff --git a/packages/react-dom-bindings/src/shared/ReactFlightClientConfigDOM.js b/packages/react-dom-bindings/src/shared/ReactFlightClientConfigDOM.js
@@ -13,16 +13,14 @@
 import type {HintCode, HintModel} from '../server/ReactFlightServerConfigDOM';
 
 import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals';
-const ReactDOMCurrentDispatcher =
-  ReactDOMSharedInternals.ReactDOMCurrentDispatcher;
 
 import {getCrossOriginString} from './crossOriginStrings';
 
 export function dispatchHint<Code: HintCode>(
   code: Code,
   model: HintModel<Code>,
 ): void {
-  const dispatcher = ReactDOMCurrentDispatcher.current;
+  const dispatcher = ReactDOMSharedInternals.d; /* ReactDOMCurrentDispatcher */
   switch (code) {
     case 'D': {
       const refined = refineModel(code, model);
@@ -117,19 +115,21 @@ export function preinitModuleForSSR(
   nonce: ?string,
   crossOrigin: ?string,
 ) {
-  ReactDOMCurrentDispatcher.current.preinitModuleScript(href, {
-    crossOrigin: getCrossOriginString(crossOrigin),
-    nonce,
-  });
+  ReactDOMSharedInternals.d /* ReactDOMCurrentDispatcher */
+    .preinitModuleScript(href, {
+      crossOrigin: getCrossOriginString(crossOrigin),
+      nonce,
+    });
 }
 
 export function preinitScriptForSSR(
   href: string,
   nonce: ?string,
   crossOrigin: ?string,
 ) {
-  ReactDOMCurrentDispatcher.current.preinitScript(href, {
-    crossOrigin: getCrossOriginString(crossOrigin),
-    nonce,
-  });
+  ReactDOMSharedInternals.d /* ReactDOMCurrentDispatcher */
+    .preinitScript(href, {
+      crossOrigin: getCrossOriginString(crossOrigin),
+      nonce,
+    });
 }
diff --git a/packages/react-dom/client.js b/packages/react-dom/client.js
@@ -27,13 +27,13 @@ export function createRoot(
   options?: CreateRootOptions,
 ): RootType {
   if (__DEV__) {
-    Internals.usingClientEntryPoint = true;
+    Internals.c /* usingClientEntryPoint */ = true;
   }
   try {
     return createRootImpl(container, options);
   } finally {
     if (__DEV__) {
-      Internals.usingClientEntryPoint = false;
+      Internals.c /* usingClientEntryPoint */ = false;
     }
   }
 }
@@ -44,13 +44,13 @@ export function hydrateRoot(
   options?: HydrateRootOptions,
 ): RootType {
   if (__DEV__) {
-    Internals.usingClientEntryPoint = true;
+    Internals.c /* usingClientEntryPoint */ = true;
   }
   try {
     return hydrateRootImpl(container, children, options);
   } finally {
     if (__DEV__) {
-      Internals.usingClientEntryPoint = false;
+      Internals.c /* usingClientEntryPoint */ = false;
     }
   }
 }
diff --git a/packages/react-dom/src/ReactDOMSharedInternals.js b/packages/react-dom/src/ReactDOMSharedInternals.js
@@ -13,17 +13,15 @@ import type {HostDispatcher} from './shared/ReactDOMTypes';
 import {NoEventPriority} from 'react-reconciler/src/ReactEventPriorities';
 
 type InternalsType = {
-  usingClientEntryPoint: boolean,
-  Events: [any, any, any, any, any, any],
-  ReactDOMCurrentDispatcher: {
-    current: HostDispatcher,
-  },
+  c /* usingClientEntryPoint */: boolean,
+  E /* Events */: [any, any, any, any, any, any],
+  d /* ReactDOMCurrentDispatcher */: HostDispatcher,
   findDOMNode:
     | null
     | ((
         componentOrElement: React$Component<any, any>,
       ) => null | Element | Text),
-  up /* currentUpdatePriority */: EventPriority,
+  p /* currentUpdatePriority */: EventPriority,
 };
 
 function noop() {}
@@ -39,13 +37,11 @@ const DefaultDispatcher: HostDispatcher = {
 };
 
 const Internals: InternalsType = {
-  usingClientEntryPoint: false,
-  Events: (null: any),
-  ReactDOMCurrentDispatcher: {
-    current: DefaultDispatcher,
-  },
+  c /* usingClientEntryPoint */: false,
+  E /* Events */: (null: any),
+  d /* ReactDOMCurrentDispatcher */: DefaultDispatcher,
   findDOMNode: null,
-  up /* currentUpdatePriority */: NoEventPriority,
+  p /* currentUpdatePriority */: NoEventPriority,
 };
 
 export default Internals;
diff --git a/packages/react-dom/src/client/ReactDOM.js b/packages/react-dom/src/client/ReactDOM.js
@@ -95,7 +95,7 @@ function createRoot(
   options?: CreateRootOptions,
 ): RootType {
   if (__DEV__) {
-    if (!Internals.usingClientEntryPoint && !__UMD__) {
+    if (!Internals.c /* usingClientEntryPoint */ && !__UMD__) {
       console.error(
         'You are importing createRoot from "react-dom" which is not supported. ' +
           'You should instead import it from "react-dom/client".',
@@ -111,7 +111,7 @@ function hydrateRoot(
   options?: HydrateRootOptions,
 ): RootType {
   if (__DEV__) {
-    if (!Internals.usingClientEntryPoint && !__UMD__) {
+    if (!Internals.c /* usingClientEntryPoint */ && !__UMD__) {
       console.error(
         'You are importing hydrateRoot from "react-dom" which is not supported. ' +
           'You should instead import it from "react-dom/client".',
@@ -173,7 +173,7 @@ export {
 
 // Keep in sync with ReactTestUtils.js.
 // This is an array for better minification.
-Internals.Events = [
+Internals.E /* Events */ = [
   getInstanceFromNode,
   getNodeFromInstance,
   getFiberCurrentPropsFromNode,