Skip to content

Commit bd47c8a

Browse files
committed
Fix disableStrictPassiveEffect not working under Suspense (#26989)
In #26914 I added an extra logic to turn off double useEffect if there is an `Offscreen` tag. But `Suspense` uses `Offscreen` tag internally and that turns off `disableStrictPassiveEffect` for everything. DiffTrain build for commit 70e998a.
1 parent b3ec754 commit bd47c8a

File tree

9 files changed

+14
-29
lines changed

9 files changed

+14
-29
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8b35d681c01d550a6b69db76a1733d08>>
10+
* @generated SignedSource<<78e16f0583c5e93e8b989135cc106bd4>>
1111
*/
1212

1313
'use strict';
@@ -23769,11 +23769,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2376923769
return fiber;
2377023770
}
2377123771
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
23772-
{
23773-
// StrictMode in Offscreen should always run double passive effects
23774-
mode &= ~NoStrictPassiveEffectsMode;
23775-
}
23776-
2377723772
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2377823773
fiber.elementType = REACT_OFFSCREEN_TYPE;
2377923774
fiber.lanes = lanes;
@@ -23934,7 +23929,7 @@ function createFiberRoot(
2393423929
return root;
2393523930
}
2393623931

23937-
var ReactVersion = "18.3.0-canary-c8deb5db6-20230622";
23932+
var ReactVersion = "18.3.0-canary-70e998a10-20230622";
2393823933

2393923934
// Might add PROFILE later.
2394023935

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8617,7 +8617,7 @@ var devToolsConfig$jscomp$inline_1031 = {
86178617
throw Error("TestRenderer does not support findFiberByHostInstance()");
86188618
},
86198619
bundleType: 0,
8620-
version: "18.3.0-canary-c8deb5db6-20230622",
8620+
version: "18.3.0-canary-70e998a10-20230622",
86218621
rendererPackageName: "react-test-renderer"
86228622
};
86238623
var internals$jscomp$inline_1230 = {
@@ -8648,7 +8648,7 @@ var internals$jscomp$inline_1230 = {
86488648
scheduleRoot: null,
86498649
setRefreshHandler: null,
86508650
getCurrentFiber: null,
8651-
reconcilerVersion: "18.3.0-canary-c8deb5db6-20230622"
8651+
reconcilerVersion: "18.3.0-canary-70e998a10-20230622"
86528652
};
86538653
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86548654
var hook$jscomp$inline_1231 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9043,7 +9043,7 @@ var devToolsConfig$jscomp$inline_1073 = {
90439043
throw Error("TestRenderer does not support findFiberByHostInstance()");
90449044
},
90459045
bundleType: 0,
9046-
version: "18.3.0-canary-c8deb5db6-20230622",
9046+
version: "18.3.0-canary-70e998a10-20230622",
90479047
rendererPackageName: "react-test-renderer"
90489048
};
90499049
var internals$jscomp$inline_1271 = {
@@ -9074,7 +9074,7 @@ var internals$jscomp$inline_1271 = {
90749074
scheduleRoot: null,
90759075
setRefreshHandler: null,
90769076
getCurrentFiber: null,
9077-
reconcilerVersion: "18.3.0-canary-c8deb5db6-20230622"
9077+
reconcilerVersion: "18.3.0-canary-70e998a10-20230622"
90789078
};
90799079
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90809080
var hook$jscomp$inline_1272 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-c8deb5db6-20230622";
30+
var ReactVersion = "18.3.0-canary-70e998a10-20230622";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,4 +642,4 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-canary-c8deb5db6-20230622";
645+
exports.version = "18.3.0-canary-70e998a10-20230622";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
);
646646
};
647647
exports.useTransition = useTransition;
648-
exports.version = "18.3.0-canary-c8deb5db6-20230622";
648+
exports.version = "18.3.0-canary-70e998a10-20230622";
649649

650650
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
651651
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
c8deb5db660f3f6eeca30d29b4bd48d9e82b3792
1+
70e998a1064cc1e8e8f9103e0c00d37fbbcf71c1

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<514b18ed9abf66bd67c35f8d3892be26>>
10+
* @generated SignedSource<<a02015addfe15f9f3c0a64ed2df2baae>>
1111
*/
1212

1313
'use strict';
@@ -27025,11 +27025,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2702527025
return fiber;
2702627026
}
2702727027
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
27028-
{
27029-
// StrictMode in Offscreen should always run double passive effects
27030-
mode &= ~NoStrictPassiveEffectsMode;
27031-
}
27032-
2703327028
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2703427029
fiber.elementType = REACT_OFFSCREEN_TYPE;
2703527030
fiber.lanes = lanes;
@@ -27249,7 +27244,7 @@ function createFiberRoot(
2724927244
return root;
2725027245
}
2725127246

27252-
var ReactVersion = "18.3.0-canary-8ff97f72";
27247+
var ReactVersion = "18.3.0-canary-6ea864da";
2725327248

2725427249
function createPortal$1(
2725527250
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<14c435eed21e626d0548f1265b3a2ab8>>
10+
* @generated SignedSource<<8f036c0125a599ffea1d8d0e0001b6d9>>
1111
*/
1212

1313
'use strict';
@@ -27539,11 +27539,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2753927539
return fiber;
2754027540
}
2754127541
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
27542-
{
27543-
// StrictMode in Offscreen should always run double passive effects
27544-
mode &= ~NoStrictPassiveEffectsMode;
27545-
}
27546-
2754727542
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2754827543
fiber.elementType = REACT_OFFSCREEN_TYPE;
2754927544
fiber.lanes = lanes;
@@ -27763,7 +27758,7 @@ function createFiberRoot(
2776327758
return root;
2776427759
}
2776527760

27766-
var ReactVersion = "18.3.0-canary-a48d7fee";
27761+
var ReactVersion = "18.3.0-canary-e9a186c1";
2776727762

2776827763
function createPortal$1(
2776927764
children,

0 commit comments

Comments
 (0)