Skip to content

Commit b610fec

Browse files
authored
fix comments: expiration time -> lanes (#21551)
1 parent 23c8095 commit b610fec

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

packages/react-reconciler/src/ReactFiberWorkLoop.new.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export function requestUpdateLane(fiber: Fiber): Lane {
389389
workInProgressRootRenderLanes !== NoLanes
390390
) {
391391
// This is a render phase update. These are not officially supported. The
392-
// old behavior is to give this the same "thread" (expiration time) as
392+
// old behavior is to give this the same "thread" (lanes) as
393393
// whatever is currently rendering. So if you call `setState` on a component
394394
// that happens later in the same render, it will flush. Ideally, we want to
395395
// remove the special case and treat them as if they came from an
@@ -756,7 +756,7 @@ function performConcurrentWorkOnRoot(root, didTimeout) {
756756
}
757757
}
758758

759-
// Determine the next expiration time to work on, using the fields stored
759+
// Determine the next lanes to work on, using the fields stored
760760
// on the root.
761761
let lanes = getNextLanes(
762762
root,
@@ -1629,7 +1629,7 @@ function completeUnitOfWork(unitOfWork: Fiber): void {
16291629
// capture values if possible.
16301630
const next = unwindWork(completedWork, subtreeRenderLanes);
16311631

1632-
// Because this fiber did not complete, don't reset its expiration time.
1632+
// Because this fiber did not complete, don't reset its lanes.
16331633

16341634
if (next !== null) {
16351635
// If completing this work spawned new work, do that next. We'll come
@@ -2308,7 +2308,7 @@ function retryTimedOutBoundary(boundaryFiber: Fiber, retryLane: Lane) {
23082308
// The boundary fiber (a Suspense component or SuspenseList component)
23092309
// previously was rendered in its fallback state. One of the promises that
23102310
// suspended it has resolved, which means at least part of the tree was
2311-
// likely unblocked. Try rendering again, at a new expiration time.
2311+
// likely unblocked. Try rendering again, at a new lanes.
23122312
if (retryLane === NoLane) {
23132313
// TODO: Assign this to `suspenseState.retryLane`? to avoid
23142314
// unnecessary entanglement?

packages/react-reconciler/src/ReactFiberWorkLoop.old.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export function requestUpdateLane(fiber: Fiber): Lane {
389389
workInProgressRootRenderLanes !== NoLanes
390390
) {
391391
// This is a render phase update. These are not officially supported. The
392-
// old behavior is to give this the same "thread" (expiration time) as
392+
// old behavior is to give this the same "thread" (lanes) as
393393
// whatever is currently rendering. So if you call `setState` on a component
394394
// that happens later in the same render, it will flush. Ideally, we want to
395395
// remove the special case and treat them as if they came from an
@@ -756,7 +756,7 @@ function performConcurrentWorkOnRoot(root, didTimeout) {
756756
}
757757
}
758758

759-
// Determine the next expiration time to work on, using the fields stored
759+
// Determine the next lanes to work on, using the fields stored
760760
// on the root.
761761
let lanes = getNextLanes(
762762
root,
@@ -1629,7 +1629,7 @@ function completeUnitOfWork(unitOfWork: Fiber): void {
16291629
// capture values if possible.
16301630
const next = unwindWork(completedWork, subtreeRenderLanes);
16311631

1632-
// Because this fiber did not complete, don't reset its expiration time.
1632+
// Because this fiber did not complete, don't reset its lanes.
16331633

16341634
if (next !== null) {
16351635
// If completing this work spawned new work, do that next. We'll come
@@ -2308,7 +2308,7 @@ function retryTimedOutBoundary(boundaryFiber: Fiber, retryLane: Lane) {
23082308
// The boundary fiber (a Suspense component or SuspenseList component)
23092309
// previously was rendered in its fallback state. One of the promises that
23102310
// suspended it has resolved, which means at least part of the tree was
2311-
// likely unblocked. Try rendering again, at a new expiration time.
2311+
// likely unblocked. Try rendering again, at a new lanes.
23122312
if (retryLane === NoLane) {
23132313
// TODO: Assign this to `suspenseState.retryLane`? to avoid
23142314
// unnecessary entanglement?

0 commit comments

Comments
 (0)