Skip to content

Commit b6023de

Browse files
committed
[Flight] Serialize deduped elements by direct reference even if they suspend (#28283)
In #28123 I switched these to be lazy references. However that creates a lazy wrapper even if they're synchronously available. We try to as much as possible preserve the original data structure in these cases. E.g. here in the dev outlining I only use a lazy wrapper if it didn't complete synchronously: https://github.com/facebook/react/pull/28272/files#diff-d4c9c509922b3671d3ecce4e051df66dd5c3d38ff913c7a7fe94abc3ba2ed72eR638 Unfortunately we don't have a data structure that tracks the status of each emitted row. We could store the task in the map but then they couldn't be GC:ed as they complete. We could maybe store the status of each element but seems so heavy. For now I just went back to direct reference which might be an issue since it can suspend something higher up when deduped. DiffTrain build for commit ba5e6a8.
1 parent f47b316 commit b6023de

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25670,7 +25670,7 @@ if (__DEV__) {
2567025670
return root;
2567125671
}
2567225672

25673-
var ReactVersion = "18.3.0-canary-e41ee9ea7-20240208";
25673+
var ReactVersion = "18.3.0-canary-ba5e6a832-20240208";
2567425674

2567525675
// Might add PROFILE later.
2567625676

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9152,7 +9152,7 @@ var devToolsConfig$jscomp$inline_1011 = {
91529152
throw Error("TestRenderer does not support findFiberByHostInstance()");
91539153
},
91549154
bundleType: 0,
9155-
version: "18.3.0-canary-e41ee9ea7-20240208",
9155+
version: "18.3.0-canary-ba5e6a832-20240208",
91569156
rendererPackageName: "react-test-renderer"
91579157
};
91589158
var internals$jscomp$inline_1189 = {
@@ -9183,7 +9183,7 @@ var internals$jscomp$inline_1189 = {
91839183
scheduleRoot: null,
91849184
setRefreshHandler: null,
91859185
getCurrentFiber: null,
9186-
reconcilerVersion: "18.3.0-canary-e41ee9ea7-20240208"
9186+
reconcilerVersion: "18.3.0-canary-ba5e6a832-20240208"
91879187
};
91889188
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91899189
var hook$jscomp$inline_1190 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9580,7 +9580,7 @@ var devToolsConfig$jscomp$inline_1053 = {
95809580
throw Error("TestRenderer does not support findFiberByHostInstance()");
95819581
},
95829582
bundleType: 0,
9583-
version: "18.3.0-canary-e41ee9ea7-20240208",
9583+
version: "18.3.0-canary-ba5e6a832-20240208",
95849584
rendererPackageName: "react-test-renderer"
95859585
};
95869586
var internals$jscomp$inline_1230 = {
@@ -9611,7 +9611,7 @@ var internals$jscomp$inline_1230 = {
96119611
scheduleRoot: null,
96129612
setRefreshHandler: null,
96139613
getCurrentFiber: null,
9614-
reconcilerVersion: "18.3.0-canary-e41ee9ea7-20240208"
9614+
reconcilerVersion: "18.3.0-canary-ba5e6a832-20240208"
96159615
};
96169616
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96179617
var hook$jscomp$inline_1231 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-e41ee9ea7-20240208";
27+
var ReactVersion = "18.3.0-canary-ba5e6a832-20240208";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,4 +551,4 @@ exports.useSyncExternalStore = function (
551551
exports.useTransition = function () {
552552
return ReactCurrentDispatcher.current.useTransition();
553553
};
554-
exports.version = "18.3.0-canary-e41ee9ea7-20240208";
554+
exports.version = "18.3.0-canary-ba5e6a832-20240208";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ exports.useSyncExternalStore = function (
547547
exports.useTransition = function () {
548548
return ReactCurrentDispatcher.current.useTransition();
549549
};
550-
exports.version = "18.3.0-canary-e41ee9ea7-20240208";
550+
exports.version = "18.3.0-canary-ba5e6a832-20240208";
551551
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
552552
"function" ===
553553
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e41ee9ea70f8998144fdd959ac11fd7a40e4ee20
1+
ba5e6a8329c7194a2c573c037a37f24ce45ee58f

0 commit comments

Comments
 (0)