You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Flight] Serialize deduped elements by direct reference even if they suspend (#28283)
In #28123 I switched these to be lazy references. However that creates a
lazy wrapper even if they're synchronously available. We try to as much
as possible preserve the original data structure in these cases.
E.g. here in the dev outlining I only use a lazy wrapper if it didn't
complete synchronously:
https://github.com/facebook/react/pull/28272/files#diff-d4c9c509922b3671d3ecce4e051df66dd5c3d38ff913c7a7fe94abc3ba2ed72eR638
Unfortunately we don't have a data structure that tracks the status of
each emitted row. We could store the task in the map but then they
couldn't be GC:ed as they complete. We could maybe store the status of
each element but seems so heavy.
For now I just went back to direct reference which might be an issue
since it can suspend something higher up when deduped.
DiffTrain build for commit ba5e6a8.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -25670,7 +25670,7 @@ if (__DEV__) {
25670
25670
return root;
25671
25671
}
25672
25672
25673
-
var ReactVersion = "18.3.0-canary-e41ee9ea7-20240208";
25673
+
var ReactVersion = "18.3.0-canary-ba5e6a832-20240208";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9152,7 +9152,7 @@ var devToolsConfig$jscomp$inline_1011 = {
9152
9152
throwError("TestRenderer does not support findFiberByHostInstance()");
9153
9153
},
9154
9154
bundleType: 0,
9155
-
version: "18.3.0-canary-e41ee9ea7-20240208",
9155
+
version: "18.3.0-canary-ba5e6a832-20240208",
9156
9156
rendererPackageName: "react-test-renderer"
9157
9157
};
9158
9158
varinternals$jscomp$inline_1189={
@@ -9183,7 +9183,7 @@ var internals$jscomp$inline_1189 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9580,7 +9580,7 @@ var devToolsConfig$jscomp$inline_1053 = {
9580
9580
throwError("TestRenderer does not support findFiberByHostInstance()");
9581
9581
},
9582
9582
bundleType: 0,
9583
-
version: "18.3.0-canary-e41ee9ea7-20240208",
9583
+
version: "18.3.0-canary-ba5e6a832-20240208",
9584
9584
rendererPackageName: "react-test-renderer"
9585
9585
};
9586
9586
varinternals$jscomp$inline_1230={
@@ -9611,7 +9611,7 @@ var internals$jscomp$inline_1230 = {
0 commit comments