Skip to content

Commit b52e425

Browse files
tyao1tyao1
committed
Fix disableStrictPassiveEffect not working under Suspense (#26989)
In #26914 I added an extra logic to turn off double useEffect if there is an `Offscreen` tag. But `Suspense` uses `Offscreen` tag internally and that turns off `disableStrictPassiveEffect` for everything. DiffTrain build for [70e998a](70e998a)
1 parent ec1a045 commit b52e425

10 files changed

+10
-50
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
254cbdbd6d851a30bf3b649a6cb7c52786766fa4
1+
70e998a1064cc1e8e8f9103e0c00d37fbbcf71c1

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
);
642642
};
643643
exports.useTransition = useTransition;
644-
exports.version = "18.3.0-www-modern-f829eef9";
644+
exports.version = "18.3.0-www-modern-f3a022db";

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-786512bb";
72+
var ReactVersion = "18.3.0-www-classic-218ac23d";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -28292,11 +28292,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2829228292
return fiber;
2829328293
}
2829428294
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
28295-
{
28296-
// StrictMode in Offscreen should always run double passive effects
28297-
mode &= ~NoStrictPassiveEffectsMode;
28298-
}
28299-
2830028295
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2830128296
fiber.elementType = REACT_OFFSCREEN_TYPE;
2830228297
fiber.lanes = lanes;

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-34b19309";
72+
var ReactVersion = "18.3.0-www-modern-a0074376";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -27952,11 +27952,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2795227952
return fiber;
2795327953
}
2795427954
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
27955-
{
27956-
// StrictMode in Offscreen should always run double passive effects
27957-
mode &= ~NoStrictPassiveEffectsMode;
27958-
}
27959-
2796027955
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2796127956
fiber.elementType = REACT_OFFSCREEN_TYPE;
2796227957
fiber.lanes = lanes;

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33919,11 +33919,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
3391933919
return fiber;
3392033920
}
3392133921
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
33922-
{
33923-
// StrictMode in Offscreen should always run double passive effects
33924-
mode &= ~NoStrictPassiveEffectsMode;
33925-
}
33926-
3392733922
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
3392833923
fiber.elementType = REACT_OFFSCREEN_TYPE;
3392933924
fiber.lanes = lanes;
@@ -34214,7 +34209,7 @@ function createFiberRoot(
3421434209
return root;
3421534210
}
3421634211

34217-
var ReactVersion = "18.3.0-www-classic-0b2d04c1";
34212+
var ReactVersion = "18.3.0-www-classic-ea62c16d";
3421834213

3421934214
function createPortal$1(
3422034215
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33764,11 +33764,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
3376433764
return fiber;
3376533765
}
3376633766
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
33767-
{
33768-
// StrictMode in Offscreen should always run double passive effects
33769-
mode &= ~NoStrictPassiveEffectsMode;
33770-
}
33771-
3377233767
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
3377333768
fiber.elementType = REACT_OFFSCREEN_TYPE;
3377433769
fiber.lanes = lanes;
@@ -34059,7 +34054,7 @@ function createFiberRoot(
3405934054
return root;
3406034055
}
3406134056

34062-
var ReactVersion = "18.3.0-www-modern-34b19309";
34057+
var ReactVersion = "18.3.0-www-modern-a0074376";
3406334058

3406434059
function createPortal$1(
3406534060
children,

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34536,11 +34536,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
3453634536
return fiber;
3453734537
}
3453834538
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
34539-
{
34540-
// StrictMode in Offscreen should always run double passive effects
34541-
mode &= ~NoStrictPassiveEffectsMode;
34542-
}
34543-
3454434539
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
3454534540
fiber.elementType = REACT_OFFSCREEN_TYPE;
3454634541
fiber.lanes = lanes;
@@ -34831,7 +34826,7 @@ function createFiberRoot(
3483134826
return root;
3483234827
}
3483334828

34834-
var ReactVersion = "18.3.0-www-classic-0b64f941";
34829+
var ReactVersion = "18.3.0-www-classic-3f09ab7a";
3483534830

3483634831
function createPortal$1(
3483734832
children,

‎compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34381,11 +34381,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
3438134381
return fiber;
3438234382
}
3438334383
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
34384-
{
34385-
// StrictMode in Offscreen should always run double passive effects
34386-
mode &= ~NoStrictPassiveEffectsMode;
34387-
}
34388-
3438934384
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
3439034385
fiber.elementType = REACT_OFFSCREEN_TYPE;
3439134386
fiber.lanes = lanes;
@@ -34676,7 +34671,7 @@ function createFiberRoot(
3467634671
return root;
3467734672
}
3467834673

34679-
var ReactVersion = "18.3.0-www-modern-60605377";
34674+
var ReactVersion = "18.3.0-www-modern-f6368a4e";
3468034675

3468134676
function createPortal$1(
3468234677
children,

‎compiled/facebook-www/ReactTestRenderer-dev.classic.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24392,11 +24392,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2439224392
return fiber;
2439324393
}
2439424394
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
24395-
{
24396-
// StrictMode in Offscreen should always run double passive effects
24397-
mode &= ~NoStrictPassiveEffectsMode;
24398-
}
24399-
2440024395
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2440124396
fiber.elementType = REACT_OFFSCREEN_TYPE;
2440224397
fiber.lanes = lanes;
@@ -24565,7 +24560,7 @@ function createFiberRoot(
2456524560
return root;
2456624561
}
2456724562

24568-
var ReactVersion = "18.3.0-www-classic-0b64f941";
24563+
var ReactVersion = "18.3.0-www-classic-3f09ab7a";
2456924564

2457024565
// Might add PROFILE later.
2457124566

‎compiled/facebook-www/ReactTestRenderer-dev.modern.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24392,11 +24392,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
2439224392
return fiber;
2439324393
}
2439424394
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
24395-
{
24396-
// StrictMode in Offscreen should always run double passive effects
24397-
mode &= ~NoStrictPassiveEffectsMode;
24398-
}
24399-
2440024395
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
2440124396
fiber.elementType = REACT_OFFSCREEN_TYPE;
2440224397
fiber.lanes = lanes;
@@ -24565,7 +24560,7 @@ function createFiberRoot(
2456524560
return root;
2456624561
}
2456724562

24568-
var ReactVersion = "18.3.0-www-modern-f829eef9";
24563+
var ReactVersion = "18.3.0-www-modern-f3a022db";
2456924564

2457024565
// Might add PROFILE later.
2457124566

0 commit comments

Comments
 (0)