createRoot API is no longer strict by default

Brian Vaughn · Brian Vaughn · commit b408df575207 · 2021-05-03T15:55:57.000-04:00
Support was left in place for defaulting a root into "strict effects mode" if the 'createRootStrictEffectsByDefault' feature flag is enabled, but this feature flag is only enabled within Facebook behind a GK.
diff --git a/packages/react-reconciler/src/ReactFiber.new.js b/packages/react-reconciler/src/ReactFiber.new.js
@@ -440,8 +440,6 @@ export function createHostRootFiber(
     } else {
       if (enableStrictEffects && createRootStrictEffectsByDefault) {
         mode |= StrictLegacyMode | StrictEffectsMode;
-      } else {
-        mode |= StrictLegacyMode;
       }
     }
     if (
diff --git a/packages/react-reconciler/src/ReactFiber.old.js b/packages/react-reconciler/src/ReactFiber.old.js
@@ -440,8 +440,6 @@ export function createHostRootFiber(
     } else {
       if (enableStrictEffects && createRootStrictEffectsByDefault) {
         mode |= StrictLegacyMode | StrictEffectsMode;
-      } else {
-        mode |= StrictLegacyMode;
       }
     }
     if (

Original file line number	Diff line number	Diff line change
`@@ -440,8 +440,6 @@ export function createHostRootFiber(`
`440`	`440`	`} else {`
`441`	`441`	`if (enableStrictEffects && createRootStrictEffectsByDefault) {`
`442`	`442`	`mode \|= StrictLegacyMode \| StrictEffectsMode;`
`443`		`- } else {`
`444`		`- mode \|= StrictLegacyMode;`
`445`	`443`	`}`
`446`	`444`	`}`
`447`	`445`	`if (`