Update

[ghstack-poisoned]

Author: mofeiZ

.github/dependabot.yml

@@ -1,107 +1,10 @@
 version: 2
 updates:
   - package-ecosystem: "npm"
-    directory: "/fixtures/art"
+    directories:
+      - "/fixtures/*"
     schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/attribute-behavior"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/concurrent"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/devtools"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/dom"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/eslint"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/expiration"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fiber-debugger"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fiber-triangle"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fizz"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/fizz-ssr-browser"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight-browser"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/flight-esm"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/legacy-jsx-runtimes"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/nesting"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/packaging"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/scheduler"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/ssr"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/ssr-2"
-    schedule:
-      interval: "weekly"
-    open-pull-requests-limit: 0
-  - package-ecosystem: "npm"
-    directory: "/fixtures/stacks"
-    schedule:
-      interval: "weekly"
+      interval: "monthly"
     open-pull-requests-limit: 0
+    ignore:
+      - dependency-name: "*"

.github/workflows/compiler_playground.yml

@@ -15,7 +15,7 @@ env:
 
 defaults:
   run:
-    working-directory: compiler
+    working-directory: compiler/apps/playground
 
 jobs:
   playground:
@@ -27,13 +27,17 @@ jobs:
         with:
           node-version-file: '.nvmrc'
           cache: yarn
-          cache-dependency-path: compiler/yarn.lock
+          cache-dependency-path: compiler/**/yarn.lock
       - name: Restore cached node_modules
         uses: actions/cache@v4
         id: node_modules
         with:
           path: "**/node_modules"
           key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
-      - run: yarn install --frozen-lockfile
+      - name: yarn install compiler
+        run: yarn install --frozen-lockfile
+        working-directory: compiler
+      - name: yarn install playground
+        run: yarn install --frozen-lockfile
       - run: npx playwright install --with-deps chromium
-      - run: yarn workspace playground test
+      - run: yarn test

.github/workflows/runtime_commit_artifacts.yml

@@ -82,7 +82,7 @@ jobs:
         working-directory: scripts/release
       - name: Download artifacts for base revision
         run: |
-          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ inputs.commit_sha || github.event.workflow_run.head_sha }}
+          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ inputs.commit_sha || github.event.workflow_run.head_sha || github.sha }}
       - name: Display structure of build
         run: ls -R build
       - name: Strip @license from eslint plugin and react-refresh
@@ -145,9 +145,9 @@ jobs:
           ls -R ./compiled-rn
       - name: Add REVISION files
         run: |
-          echo ${{ github.event.workflow_run.head_sha }} >> ./compiled/facebook-www/REVISION
+          echo ${{ github.sha }} >> ./compiled/facebook-www/REVISION
           cp ./compiled/facebook-www/REVISION ./compiled/facebook-www/REVISION_TRANSFORMS
-          echo ${{ github.event.workflow_run.head_sha}} >> ./compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
+          echo ${{ github.sha}} >> ./compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
       - name: "Get current version string"
         id: get_current_version
         run: |
@@ -171,7 +171,7 @@ jobs:
 
   commit_www_artifacts:
     needs: download_artifacts
-    if: ${{ (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.www_branch_count == '0') || github.ref == 'refs/heads/meta-www' }}
+    if: inputs.force == true || (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.www_branch_count == '0')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -201,7 +201,7 @@ jobs:
           grep -rl "$CURRENT_VERSION_MODERN" ./compiled | xargs -r sed -i -e "s/$CURRENT_VERSION_MODERN/$LAST_VERSION_MODERN/g"
           grep -rl "$CURRENT_VERSION_MODERN" ./compiled || echo "Modern version reverted"
       - name: Check for changes
-        if: !inputs.force
+        if: inputs.force != true
         id: check_should_commit
         run: |
           echo "Full git status"
@@ -219,7 +219,7 @@ jobs:
             echo "should_commit=false" >> "$GITHUB_OUTPUT"
           fi
       - name: Re-apply version changes
-        if: inputs.force || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_classic != '' && needs.download_artifacts.outputs.last_version_modern != '')
+        if: inputs.force == true || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_classic != '' && needs.download_artifacts.outputs.last_version_modern != '')
         env:
           CURRENT_VERSION_CLASSIC: ${{ needs.download_artifacts.outputs.current_version_classic }}
           CURRENT_VERSION_MODERN: ${{ needs.download_artifacts.outputs.current_version_modern }}
@@ -236,26 +236,26 @@ jobs:
           grep -rl "$LAST_VERSION_MODERN" ./compiled | xargs -r sed -i -e "s/$LAST_VERSION_MODERN/$CURRENT_VERSION_MODERN/g"
           grep -rl "$LAST_VERSION_MODERN" ./compiled || echo "Classic version re-applied"
       - name: Will commit these changes
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           echo ":"
           git status -u
       - name: Commit changes to branch
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
-        uses: stefanzweifel/git-auto-commit-action@v4
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
+        uses: stefanzweifel/git-auto-commit-action@v5
         with:
           commit_message: |
-            ${{ github.event.workflow_run.head_commit.message }}
+            ${{ github.event.workflow_run.head_commit.message || format('Manual build of {0}', github.event.workflow_run.head_sha || github.sha) }}
 
-            DiffTrain build for [${{ github.event.workflow_run.head_sha }}](https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }})
+            DiffTrain build for [${{ github.event.workflow_run.head_sha || github.sha }}](https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha || github.sha }})
           branch: builds/facebook-www
-          commit_user_name: ${{ github.event.workflow_run.triggering_actor.login }}
-          commit_user_email: ${{ github.event.workflow_run.triggering_actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.triggering_actor.login) }}
+          commit_user_name: ${{ github.triggering_actor }}
+          commit_user_email: ${{ format('{0}@users.noreply.github.com', github.triggering_actor) }}
           create_branch: true
 
   commit_fbsource_artifacts:
     needs: download_artifacts
-    if: ${{ (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.fbsource_branch_count == '0') || github.ref == 'refs/heads/meta-fbsource' }}
+    if: inputs.force == true || (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.fbsource_branch_count == '0')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -278,7 +278,7 @@ jobs:
           grep -rl "$CURRENT_VERSION" ./compiled-rn | xargs -r sed -i -e "s/$CURRENT_VERSION/$LAST_VERSION/g"
           grep -rl "$CURRENT_VERSION" ./compiled-rn || echo "Version reverted"
       - name: Check for changes
-        if: !inputs.force
+        if: inputs.force != 'true'
         id: check_should_commit
         run: |
           echo "Full git status"
@@ -297,7 +297,7 @@ jobs:
             echo "should_commit=false" >> "$GITHUB_OUTPUT"
           fi
       - name: Re-apply version changes
-        if: inputs.force || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_rn != '')
+        if: inputs.force == true || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_rn != '')
         env:
           CURRENT_VERSION: ${{ needs.download_artifacts.outputs.current_version_rn }}
           LAST_VERSION: ${{ needs.download_artifacts.outputs.last_version_rn }}
@@ -307,12 +307,12 @@ jobs:
           grep -rl "$LAST_VERSION" ./compiled-rn | xargs -r sed -i -e "s/$LAST_VERSION/$CURRENT_VERSION/g"
           grep -rl "$LAST_VERSION" ./compiled-rn || echo "Version re-applied"
       - name: Add files for signing
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           echo ":"
           git add .
       - name: Signing files
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         uses: actions/github-script@v7
         with:
           script: |
@@ -366,8 +366,9 @@ jobs:
             console.log('Signing files in directory:', directory);
             try {
               const result = execSync(`git status --porcelain ${directory}`, {encoding: 'utf8'});
+              console.log(result);
 
-              // Parse the git status output to get file paths
+              // Parse the git status output to get file paths!
               const files = result.split('\n').filter(file => file.endsWith('.js'));
 
               if (files.length === 0) {
@@ -376,7 +377,14 @@ jobs:
                 );
               } else {
                 files.forEach(line => {
-                  const file = line.slice(3).trim();
+                  let file = null;
+                  if (line.startsWith('D ')) {
+                    return;
+                  } else if (line.startsWith('R ')) {
+                    file = line.slice(line.indexOf('->') + 3);
+                  } else {
+                    file = line.slice(3).trim();
+                  }
                   if (file) {
                     console.log('  Signing file:', file);
                     const originalContents = fs.readFileSync(file, 'utf8');
@@ -395,19 +403,19 @@ jobs:
               console.error('Error signing files:', e);
             }
       - name: Will commit these changes
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           git add .
           git status
       - name: Commit changes to branch
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
-        uses: stefanzweifel/git-auto-commit-action@v4
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
+        uses: stefanzweifel/git-auto-commit-action@v5
         with:
           commit_message: |
-            ${{ github.event.workflow_run.head_commit.message }}
+            ${{ github.event.workflow_run.head_commit.message || format('Manual build of {0}', github.event.workflow_run.head_sha || github.sha) }}
 
-            DiffTrain build for commit https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }}.
+            DiffTrain build for [${{ github.event.workflow_run.head_sha || github.sha }}](https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha || github.sha }})
           branch: builds/facebook-fbsource
-          commit_user_name: ${{ github.event.workflow_run.triggering_actor.login }}
-          commit_user_email: ${{ github.event.workflow_run.triggering_actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.triggering_actor.login) }}
+          commit_user_name: ${{ github.triggering_actor }}
+          commit_user_email: ${{ format('{0}@users.noreply.github.com', github.triggering_actor) }}
           create_branch: true

compiler/apps/playground/app/layout.tsx

@@ -7,7 +7,11 @@
 
 import '../styles/globals.css';
 
-export default function RootLayout({children}: {children: React.ReactNode}) {
+export default function RootLayout({
+  children,
+}: {
+  children: React.ReactNode;
+}): JSX.Element {
   'use no memo';
   return (
     <html lang="en">

compiler/apps/playground/app/page.tsx

@@ -11,7 +11,7 @@ import {SnackbarProvider} from 'notistack';
 import {Editor, Header, StoreProvider} from '../components';
 import MessageSnackbar from '../components/Message';
 
-export default function Hoot() {
+export default function Page(): JSX.Element {
   return (
     <StoreProvider>
       <SnackbarProvider

compiler/apps/playground/components/Editor/EditorImpl.tsx

@@ -43,7 +43,7 @@ import {
 import {printFunctionWithOutlined} from 'babel-plugin-react-compiler/src/HIR/PrintHIR';
 import {printReactiveFunctionWithOutlined} from 'babel-plugin-react-compiler/src/ReactiveScopes/PrintReactiveFunction';
 
-function parseInput(input: string, language: 'flow' | 'typescript') {
+function parseInput(input: string, language: 'flow' | 'typescript'): any {
   // Extract the first line to quickly check for custom test directives
   if (language === 'flow') {
     return HermesParser.parse(input, {
@@ -181,9 +181,9 @@ function getFunctionIdentifier(
 }
 
 function compile(source: string): [CompilerOutput, 'flow' | 'typescript'] {
-  const results = new Map<string, PrintedCompilerPipelineValue[]>();
+  const results = new Map<string, Array<PrintedCompilerPipelineValue>>();
   const error = new CompilerError();
-  const upsert = (result: PrintedCompilerPipelineValue) => {
+  const upsert: (result: PrintedCompilerPipelineValue) => void = result => {
     const entry = results.get(result.name);
     if (Array.isArray(entry)) {
       entry.push(result);
@@ -273,13 +273,17 @@ function compile(source: string): [CompilerOutput, 'flow' | 'typescript'] {
       }
     }
   } catch (err) {
-    // error might be an invariant violation or other runtime error
-    // (i.e. object shape that is not CompilerError)
+    /**
+     * error might be an invariant violation or other runtime error
+     * (i.e. object shape that is not CompilerError)
+     */
     if (err instanceof CompilerError && err.details.length > 0) {
       error.details.push(...err.details);
     } else {
-      // Handle unexpected failures by logging (to get a stack trace)
-      // and reporting
+      /**
+       * Handle unexpected failures by logging (to get a stack trace)
+       * and reporting
+       */
       console.error(err);
       error.details.push(
         new CompilerErrorDetail({
@@ -297,7 +301,7 @@ function compile(source: string): [CompilerOutput, 'flow' | 'typescript'] {
   return [{kind: 'ok', results}, language];
 }
 
-export default function Editor() {
+export default function Editor(): JSX.Element {
   const store = useStore();
   const deferredStore = useDeferredValue(store);
   const dispatchStore = useStoreDispatch();