Skip to content

Commit aa80a30

Browse files
authored
[react devtools][easy] Rename LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY to LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY (#25154)
* This more accurately describes what this constant does
1 parent 9ff738f commit aa80a30

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/react-devtools-shared/src/constants.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const SESSION_STORAGE_RELOAD_AND_PROFILE_KEY =
5151
export const LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS =
5252
'React::DevTools::breakOnConsoleErrors';
5353

54-
export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY =
54+
export const LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY =
5555
'React::DevTools::appendComponentStack';
5656

5757
export const LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY =

packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
COMPACT_LINE_HEIGHT,
2121
LOCAL_STORAGE_PARSE_HOOK_NAMES_KEY,
2222
LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
23-
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
23+
LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
2424
LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY,
2525
LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
2626
LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
@@ -117,7 +117,7 @@ function SettingsContextController({
117117
appendComponentStack,
118118
setAppendComponentStack,
119119
] = useLocalStorageWithLog<boolean>(
120-
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
120+
LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
121121
true,
122122
);
123123
const [

packages/react-devtools-shared/src/utils.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import {
4040
LOCAL_STORAGE_FILTER_PREFERENCES_KEY,
4141
LOCAL_STORAGE_OPEN_IN_EDITOR_URL,
4242
LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
43-
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
43+
LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
4444
LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
4545
LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
4646
} from './constants';
@@ -343,7 +343,7 @@ export function saveComponentFilters(
343343

344344
export function getAppendComponentStack(): boolean {
345345
try {
346-
const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY);
346+
const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY);
347347
if (raw != null) {
348348
return JSON.parse(raw);
349349
}
@@ -353,7 +353,7 @@ export function getAppendComponentStack(): boolean {
353353

354354
export function setAppendComponentStack(value: boolean): void {
355355
localStorageSetItem(
356-
LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
356+
LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
357357
JSON.stringify(value),
358358
);
359359
}

0 commit comments

Comments
 (0)