Skip to content

Commit a47f447

Browse files
josephsavonajosephsavona
committed
[compiler] Add missing source locations to statements, expressions (#34406)
Adds missing locations to all the statement kinds that we produce in codegenInstruction(), and adds generic handling of source locations for the nodes produced by codegenInstructionValue(). There are definitely some places where we are still missing a location, but this should address some of the known issues we've seen such as missing location on `throw`. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34406). * #34394 * __->__ #34406 * #34346 DiffTrain build for [f5e96b9](f5e96b9)
1 parent 118621b commit a47f447

26 files changed

+203
-169
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-80d7aa17-20250906
1+
19.2.0-native-fb-f5e96b97-20250906

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a2075f3fc08b2c3db99a2bbdd1f61466>>
10+
* @generated SignedSource<<f989317f28992e9316d994eaae7f639c>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
407+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e4d1174a9346c045f9edc39ff8e56375>>
10+
* @generated SignedSource<<aa76f61a3266a3ad9cf4403cb0545071>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
206+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e4d1174a9346c045f9edc39ff8e56375>>
10+
* @generated SignedSource<<aa76f61a3266a3ad9cf4403cb0545071>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
206+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<437fb0a423909face43d9957d4d410c2>>
10+
* @generated SignedSource<<f126fd491fb22365b8f3830d292da7f1>>
1111
*/
1212

1313
/*
@@ -29580,11 +29580,11 @@ __DEV__ &&
2958029580
};
2958129581
(function () {
2958229582
var isomorphicReactPackageVersion = React.version;
29583-
if ("19.2.0-native-fb-80d7aa17-20250906" !== isomorphicReactPackageVersion)
29583+
if ("19.2.0-native-fb-f5e96b97-20250906" !== isomorphicReactPackageVersion)
2958429584
throw Error(
2958529585
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2958629586
(isomorphicReactPackageVersion +
29587-
"\n - react-dom: 19.2.0-native-fb-80d7aa17-20250906\nLearn more: https://react.dev/warnings/version-mismatch")
29587+
"\n - react-dom: 19.2.0-native-fb-f5e96b97-20250906\nLearn more: https://react.dev/warnings/version-mismatch")
2958829588
);
2958929589
})();
2959029590
("function" === typeof Map &&
@@ -29621,10 +29621,10 @@ __DEV__ &&
2962129621
!(function () {
2962229622
var internals = {
2962329623
bundleType: 1,
29624-
version: "19.2.0-native-fb-80d7aa17-20250906",
29624+
version: "19.2.0-native-fb-f5e96b97-20250906",
2962529625
rendererPackageName: "react-dom",
2962629626
currentDispatcherRef: ReactSharedInternals,
29627-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906"
29627+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906"
2962829628
};
2962929629
internals.overrideHookState = overrideHookState;
2963029630
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29773,5 +29773,5 @@ __DEV__ &&
2977329773
listenToAllSupportedEvents(container);
2977429774
return new ReactDOMHydrationRoot(initialChildren);
2977529775
};
29776-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
29776+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";
2977729777
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c4651ac986e1fca8e7286bc1329b0abd>>
10+
* @generated SignedSource<<f55d74d0c818148ddd65fd64928379d3>>
1111
*/
1212

1313
/*
@@ -17388,14 +17388,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1738817388
};
1738917389
var isomorphicReactPackageVersion$jscomp$inline_2057 = React.version;
1739017390
if (
17391-
"19.2.0-native-fb-80d7aa17-20250906" !==
17391+
"19.2.0-native-fb-f5e96b97-20250906" !==
1739217392
isomorphicReactPackageVersion$jscomp$inline_2057
1739317393
)
1739417394
throw Error(
1739517395
formatProdErrorMessage(
1739617396
527,
1739717397
isomorphicReactPackageVersion$jscomp$inline_2057,
17398-
"19.2.0-native-fb-80d7aa17-20250906"
17398+
"19.2.0-native-fb-f5e96b97-20250906"
1739917399
)
1740017400
);
1740117401
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17417,10 +17417,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1741717417
};
1741817418
var internals$jscomp$inline_2630 = {
1741917419
bundleType: 0,
17420-
version: "19.2.0-native-fb-80d7aa17-20250906",
17420+
version: "19.2.0-native-fb-f5e96b97-20250906",
1742117421
rendererPackageName: "react-dom",
1742217422
currentDispatcherRef: ReactSharedInternals,
17423-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906"
17423+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906"
1742417424
};
1742517425
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1742617426
var hook$jscomp$inline_2631 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17527,4 +17527,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1752717527
listenToAllSupportedEvents(container);
1752817528
return new ReactDOMHydrationRoot(initialChildren);
1752917529
};
17530-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
17530+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<07b5f62960f532f1e7fb76091f63c92d>>
10+
* @generated SignedSource<<9a63bc3e8950c77f2023e9b6d90e6716>>
1111
*/
1212

1313
/*
@@ -19398,14 +19398,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1939819398
};
1939919399
var isomorphicReactPackageVersion$jscomp$inline_2308 = React.version;
1940019400
if (
19401-
"19.2.0-native-fb-80d7aa17-20250906" !==
19401+
"19.2.0-native-fb-f5e96b97-20250906" !==
1940219402
isomorphicReactPackageVersion$jscomp$inline_2308
1940319403
)
1940419404
throw Error(
1940519405
formatProdErrorMessage(
1940619406
527,
1940719407
isomorphicReactPackageVersion$jscomp$inline_2308,
19408-
"19.2.0-native-fb-80d7aa17-20250906"
19408+
"19.2.0-native-fb-f5e96b97-20250906"
1940919409
)
1941019410
);
1941119411
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19427,10 +19427,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1942719427
};
1942819428
var internals$jscomp$inline_2315 = {
1942919429
bundleType: 0,
19430-
version: "19.2.0-native-fb-80d7aa17-20250906",
19430+
version: "19.2.0-native-fb-f5e96b97-20250906",
1943119431
rendererPackageName: "react-dom",
1943219432
currentDispatcherRef: ReactSharedInternals,
19433-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906",
19433+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906",
1943419434
getLaneLabelMap: function () {
1943519435
for (
1943619436
var map = new Map(), lane = 1, index$324 = 0;
@@ -19553,4 +19553,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1955319553
listenToAllSupportedEvents(container);
1955419554
return new ReactDOMHydrationRoot(initialChildren);
1955519555
};
19556-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
19556+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e7691386264f90268ff32f56fb94c3e7>>
10+
* @generated SignedSource<<a189c862c6bffcac150aa209c02cdc85>>
1111
*/
1212

1313
/*
@@ -29636,11 +29636,11 @@ __DEV__ &&
2963629636
};
2963729637
(function () {
2963829638
var isomorphicReactPackageVersion = React.version;
29639-
if ("19.2.0-native-fb-80d7aa17-20250906" !== isomorphicReactPackageVersion)
29639+
if ("19.2.0-native-fb-f5e96b97-20250906" !== isomorphicReactPackageVersion)
2964029640
throw Error(
2964129641
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2964229642
(isomorphicReactPackageVersion +
29643-
"\n - react-dom: 19.2.0-native-fb-80d7aa17-20250906\nLearn more: https://react.dev/warnings/version-mismatch")
29643+
"\n - react-dom: 19.2.0-native-fb-f5e96b97-20250906\nLearn more: https://react.dev/warnings/version-mismatch")
2964429644
);
2964529645
})();
2964629646
("function" === typeof Map &&
@@ -29677,10 +29677,10 @@ __DEV__ &&
2967729677
!(function () {
2967829678
var internals = {
2967929679
bundleType: 1,
29680-
version: "19.2.0-native-fb-80d7aa17-20250906",
29680+
version: "19.2.0-native-fb-f5e96b97-20250906",
2968129681
rendererPackageName: "react-dom",
2968229682
currentDispatcherRef: ReactSharedInternals,
29683-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906"
29683+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906"
2968429684
};
2968529685
internals.overrideHookState = overrideHookState;
2968629686
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30145,7 +30145,7 @@ __DEV__ &&
3014530145
exports.useFormStatus = function () {
3014630146
return resolveDispatcher().useHostTransitionStatus();
3014730147
};
30148-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
30148+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";
3014930149
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3015030150
"function" ===
3015130151
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<85fed4a761e2b5ff14b1f0db3ca331a9>>
10+
* @generated SignedSource<<fea4374328591af0ca62bc2b27abb574>>
1111
*/
1212

1313
/*
@@ -17399,14 +17399,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1739917399
};
1740017400
var isomorphicReactPackageVersion$jscomp$inline_2058 = React.version;
1740117401
if (
17402-
"19.2.0-native-fb-80d7aa17-20250906" !==
17402+
"19.2.0-native-fb-f5e96b97-20250906" !==
1740317403
isomorphicReactPackageVersion$jscomp$inline_2058
1740417404
)
1740517405
throw Error(
1740617406
formatProdErrorMessage(
1740717407
527,
1740817408
isomorphicReactPackageVersion$jscomp$inline_2058,
17409-
"19.2.0-native-fb-80d7aa17-20250906"
17409+
"19.2.0-native-fb-f5e96b97-20250906"
1741017410
)
1741117411
);
1741217412
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17428,10 +17428,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1742817428
};
1742917429
var internals$jscomp$inline_2633 = {
1743017430
bundleType: 0,
17431-
version: "19.2.0-native-fb-80d7aa17-20250906",
17431+
version: "19.2.0-native-fb-f5e96b97-20250906",
1743217432
rendererPackageName: "react-dom",
1743317433
currentDispatcherRef: ReactSharedInternals,
17434-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906"
17434+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906"
1743517435
};
1743617436
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1743717437
var hook$jscomp$inline_2634 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17691,4 +17691,4 @@ exports.useFormState = function (action, initialState, permalink) {
1769117691
exports.useFormStatus = function () {
1769217692
return ReactSharedInternals.H.useHostTransitionStatus();
1769317693
};
17694-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
17694+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a06934a4297bc2ef35e808b1a5e4aa82>>
10+
* @generated SignedSource<<0ed698b3ddf5f97f3b66abf5666c4cac>>
1111
*/
1212

1313
/*
@@ -19413,14 +19413,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1941319413
};
1941419414
var isomorphicReactPackageVersion$jscomp$inline_2309 = React.version;
1941519415
if (
19416-
"19.2.0-native-fb-80d7aa17-20250906" !==
19416+
"19.2.0-native-fb-f5e96b97-20250906" !==
1941719417
isomorphicReactPackageVersion$jscomp$inline_2309
1941819418
)
1941919419
throw Error(
1942019420
formatProdErrorMessage(
1942119421
527,
1942219422
isomorphicReactPackageVersion$jscomp$inline_2309,
19423-
"19.2.0-native-fb-80d7aa17-20250906"
19423+
"19.2.0-native-fb-f5e96b97-20250906"
1942419424
)
1942519425
);
1942619426
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19442,10 +19442,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1944219442
};
1944319443
var internals$jscomp$inline_2316 = {
1944419444
bundleType: 0,
19445-
version: "19.2.0-native-fb-80d7aa17-20250906",
19445+
version: "19.2.0-native-fb-f5e96b97-20250906",
1944619446
rendererPackageName: "react-dom",
1944719447
currentDispatcherRef: ReactSharedInternals,
19448-
reconcilerVersion: "19.2.0-native-fb-80d7aa17-20250906",
19448+
reconcilerVersion: "19.2.0-native-fb-f5e96b97-20250906",
1944919449
getLaneLabelMap: function () {
1945019450
for (
1945119451
var map = new Map(), lane = 1, index$324 = 0;
@@ -19721,7 +19721,7 @@ exports.useFormState = function (action, initialState, permalink) {
1972119721
exports.useFormStatus = function () {
1972219722
return ReactSharedInternals.H.useHostTransitionStatus();
1972319723
};
19724-
exports.version = "19.2.0-native-fb-80d7aa17-20250906";
19724+
exports.version = "19.2.0-native-fb-f5e96b97-20250906";
1972519725
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1972619726
"function" ===
1972719727
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)