Skip to content

Commit 9fe5ee0

Browse files
committed
ReactDOM: remove unstable-native-dependencies bundle
This is only used by react-native-web and will be replaced by a user-space implementation. See: necolas/react-native-web#1568
1 parent 7785a52 commit 9fe5ee0

File tree

9 files changed

+6
-68
lines changed

9 files changed

+6
-68
lines changed

packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,11 +404,10 @@ describe('ResponderEventPlugin', () => {
404404
beforeEach(() => {
405405
jest.resetModules();
406406

407-
const ReactDOMUnstableNativeDependencies = require('react-dom/unstable-native-dependencies');
408407
EventBatching = require('legacy-events/EventBatching');
409408
EventPluginUtils = require('legacy-events/EventPluginUtils');
410-
ResponderEventPlugin =
411-
ReactDOMUnstableNativeDependencies.ResponderEventPlugin;
409+
ResponderEventPlugin = require('legacy-events/ResponderEventPlugin')
410+
.default;
412411

413412
deleteAllListeners(GRANDPARENT_INST);
414413
deleteAllListeners(PARENT_INST);

packages/react-dom/npm/unstable-native-dependencies.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/react-dom/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"unstable-fizz.js",
3939
"unstable-fizz.browser.js",
4040
"unstable-fizz.node.js",
41-
"unstable-native-dependencies.js",
4241
"cjs/",
4342
"umd/"
4443
],

packages/react-dom/src/client/ReactDOM.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@ function unstable_createPortal(
172172
}
173173

174174
const Internals = {
175-
// Keep in sync with ReactDOMUnstableNativeDependencies.js
176-
// ReactTestUtils.js, and ReactTestUtilsAct.js. This is an array for better minification.
175+
// Keep in sync with ReactTestUtils.js, and ReactTestUtilsAct.js.
176+
// This is an array for better minification.
177177
Events: [
178178
getInstanceFromNode,
179179
getNodeFromInstance,

packages/react-dom/src/test-utils/ReactTestUtils.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ import accumulateInto from 'legacy-events/accumulateInto';
2525
import {enableModernEventSystem} from 'shared/ReactFeatureFlags';
2626

2727
const {findDOMNode} = ReactDOM;
28-
// Keep in sync with ReactDOMUnstableNativeDependencies.js
29-
// ReactDOM.js, and ReactTestUtilsAct.js:
28+
// Keep in sync with ReactDOM.js, and ReactTestUtilsAct.js:
3029
const [
3130
getInstanceFromNode,
3231
/* eslint-disable no-unused-vars */

packages/react-dom/src/test-utils/ReactTestUtilsAct.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ import ReactSharedInternals from 'shared/ReactSharedInternals';
1414
import enqueueTask from 'shared/enqueueTask';
1515
import * as Scheduler from 'scheduler';
1616

17-
// Keep in sync with ReactDOMUnstableNativeDependencies.js
18-
// ReactDOM.js, and ReactTestUtils.js:
17+
// Keep in sync with ReactDOM.js, and ReactTestUtils.js:
1918
const [
2019
/* eslint-disable no-unused-vars */
2120
getInstanceFromNode,

packages/react-dom/src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies.js

Lines changed: 0 additions & 32 deletions
This file was deleted.

packages/react-dom/unstable-native-dependencies.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

scripts/rollup/bundles.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,6 @@ const bundles = [
155155
externals: ['react'],
156156
},
157157

158-
/* React DOM internals required for react-native-web (e.g., to shim native events from react-dom) */
159-
{
160-
bundleTypes: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD],
161-
moduleType: RENDERER_UTILS,
162-
entry: 'react-dom/unstable-native-dependencies',
163-
global: 'ReactDOMUnstableNativeDependencies',
164-
externals: ['react', 'react-dom'],
165-
},
166-
167158
/******* React DOM Server *******/
168159
{
169160
bundleTypes: [

0 commit comments

Comments
 (0)