Skip to content

Commit 9f4627f

Browse files
author
Brian Vaughn
committed
Prevent Jest from configuring Error source-maps
1 parent 3599ead commit 9f4627f

File tree

12 files changed

+29
-30
lines changed

12 files changed

+29
-30
lines changed

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ComponentWithExternalCustomHooks.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/Example.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/InlineRequire.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/ToDoList.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/external/useTheme.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/ComponentWithExternalCustomHooks.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/Example.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/InlineRequire.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/ToDoList.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/__source__/__compiled__/inline/useTheme.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ describe('parseHookNames', () => {
2727
.inspectHooks;
2828
parseHookNames = require('../parseHookNames').default;
2929

30+
// Jest (jest-runner?) configures Errors to automatically account for source maps.
31+
// This changes behavior between our tests and the browser.
32+
// To "fix" this, clear the prepareStackTrace() method on the Error object.
33+
delete Error.prepareStackTrace;
34+
3035
fetchMock.mockIf(/.+$/, request => {
3136
const {resolve} = require('path');
3237
const url = request.url;

packages/react-devtools-extensions/src/__tests__/updateMockSourceMaps.js

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,9 @@ function compile(fileName) {
4444
// Generate compiled output with external source maps
4545
writeFileSync(
4646
resolve(externalDir, fileName),
47-
// This comment format (//##) isn't valid;
48-
// but it prevents Node from auto-applying source maps to stack traces
49-
// which lets unit tests more accurately simulate browser behavior.
5047
transformed.code +
51-
`\n//## sourceMappingURL=${fileName}.map` +
52-
`\n//## sourceURL=${fileName}`,
48+
`\n//# sourceMappingURL=${fileName}.map` +
49+
`\n//# sourceURL=${fileName}`,
5350
'utf8',
5451
);
5552
writeFileSync(
@@ -61,13 +58,10 @@ function compile(fileName) {
6158
// Generate compiled output with external inline base64 source maps
6259
writeFileSync(
6360
resolve(inlineDir, fileName),
64-
// This comment format (//##) isn't valid;
65-
// but it prevents Node from auto-applying source maps to stack traces
66-
// which lets unit tests more accurately simulate browser behavior.
6761
transformed.code +
68-
'\n//## sourceMappingURL=data:application/json;charset=utf-8;base64,' +
62+
'\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,' +
6963
btoa(JSON.stringify(sourceMap)) +
70-
`\n//## sourceURL=${fileName}`,
64+
`\n//# sourceURL=${fileName}`,
7165
'utf8',
7266
);
7367
}

0 commit comments

Comments
 (0)