Don't treat "retries" as a regular update

A "retry" is not a regular kind of update. It cannot unblock a suspended
tree because it contains no additional data on its own. All it does is
tell a Suspense boundary to attempt to switch back to its regular state.

This distinction will be important in a new feature I'm working on, so
instead of calling `markRootUpdated` during a retry, I refactored it to
call a different function instead.

Author: acdlite

packages/react-reconciler/src/ReactFiberLane.new.js

@@ -584,7 +584,7 @@ export function createLaneMap<T>(initial: T): LaneMap<T> {
   return laneMap;
 }
 
-export function markRootUpdated(
+export function markRootHasPendingWork(
   root: FiberRoot,
   updateLane: Lane,
   eventTime: number,

packages/react-reconciler/src/ReactFiberLane.old.js

@@ -584,7 +584,7 @@ export function createLaneMap<T>(initial: T): LaneMap<T> {
   return laneMap;
 }
 
-export function markRootUpdated(
+export function markRootHasPendingWork(
   root: FiberRoot,
   updateLane: Lane,
   eventTime: number,

packages/react-reconciler/src/ReactFiberWorkLoop.new.js

@@ -153,7 +153,7 @@ import {
   markStarvedLanesAsExpired,
   getLanesToRetrySynchronouslyOnError,
   getMostRecentEventTime,
-  markRootUpdated,
+  markRootHasPendingWork,
   markRootSuspended as markRootSuspended_dontCallThisOneDirectly,
   markRootPinged,
   markRootEntangled,
@@ -813,6 +813,16 @@ export function scheduleUpdateOnFiber(
   }
 }
 
+function markRootUpdated(root: FiberRoot, lanes: Lanes, eventTime: number) {
+  // This function should be called whenever a root receives an update that
+  // contains new information.
+  //
+  // Notably, this excludes "retries" — when a promise resolves and we schedule
+  // work to flip a Suspense boundary from a fallback back to its regular state.
+  // A retry cannot unblock existing work,
+  markRootHasPendingWork(root, lanes, eventTime);
+}
+
 export function scheduleInitialHydrationOnRoot(
   root: FiberRoot,
   lane: Lane,
@@ -3187,7 +3197,12 @@ function retryTimedOutBoundary(boundaryFiber: Fiber, retryLane: Lane) {
   const eventTime = requestEventTime();
   const root = enqueueConcurrentRenderForLane(boundaryFiber, retryLane);
   if (root !== null) {
-    markRootUpdated(root, retryLane, eventTime);
+    // A "retry" is not a regular kind of update. It cannot unblock a suspended
+    // tree because it contains no additional data on its own. All it does is
+    // tell a Suspense boundary to attempt to switch back to its regular state.
+    //
+    // So we call markRootHasPendingWork here instead of markRootUpdated.
+    markRootHasPendingWork(root, retryLane, eventTime);
     ensureRootIsScheduled(root, eventTime);
   }
 }

packages/react-reconciler/src/ReactFiberWorkLoop.old.js

@@ -153,7 +153,7 @@ import {
   markStarvedLanesAsExpired,
   getLanesToRetrySynchronouslyOnError,
   getMostRecentEventTime,
-  markRootUpdated,
+  markRootHasPendingWork,
   markRootSuspended as markRootSuspended_dontCallThisOneDirectly,
   markRootPinged,
   markRootEntangled,
@@ -813,6 +813,16 @@ export function scheduleUpdateOnFiber(
   }
 }
 
+function markRootUpdated(root: FiberRoot, lanes: Lanes, eventTime: number) {
+  // This function should be called whenever a root receives an update that
+  // contains new information.
+  //
+  // Notably, this excludes "retries" — when a promise resolves and we schedule
+  // work to flip a Suspense boundary from a fallback back to its regular state.
+  // A retry cannot unblock existing work,
+  markRootHasPendingWork(root, lanes, eventTime);
+}
+
 export function scheduleInitialHydrationOnRoot(
   root: FiberRoot,
   lane: Lane,
@@ -3187,7 +3197,12 @@ function retryTimedOutBoundary(boundaryFiber: Fiber, retryLane: Lane) {
   const eventTime = requestEventTime();
   const root = enqueueConcurrentRenderForLane(boundaryFiber, retryLane);
   if (root !== null) {
-    markRootUpdated(root, retryLane, eventTime);
+    // A "retry" is not a regular kind of update. It cannot unblock a suspended
+    // tree because it contains no additional data on its own. All it does is
+    // tell a Suspense boundary to attempt to switch back to its regular state.
+    //
+    // So we call markRootHasPendingWork here instead of markRootUpdated.
+    markRootHasPendingWork(root, retryLane, eventTime);
     ensureRootIsScheduled(root, eventTime);
   }
 }