Skip to content

Commit 9b5e051

Browse files
authored
Remove deprecated wildcard folder mapping (#23256)
* Remove deprecated folder mapping Node v16 deprecated the use of trailing "/" to define subpath folder mappings in the "exports" field of package.json. The recommendation is to explicitly list all our exports. We already do that for all our public modules. I believe the only reason we have a wildcard pattern is because our package.json files are also used at build time (by Rollup) to resolve internal source modules that don't appear in the final npm artifact. Changing trailing "/" to "/*" fixes the warnings. See https://nodejs.org/api/packages.html#subpath-patterns for more info. Since the wildcard pattern only exists so our build script has access to internal at build time, I've scoped the wildcard to "/src/*". Because our public modules are located outside the "src" directory, this means deep imports of our modules will no longer work: only packages that are listed in the "exports" field. The only two affected packages are react-dom and react. We need to be sure that all our public modules are still reachable. I audited the exports by comparing the entries to the "files" field in package.json, which represents a complete list of the files that are included in the final release artifact. At some point, we should add an e2e packaging test to prevent regressions; for now, we should have decent coverage because in CI we run our Jest test suite against the release artifacts. * Remove umd from exports Our expectation is that if you're using the UMD builds, you're not loading them through a normal module system like require or import. Instead you're probably copying the files directly or loading them from a CDN like unpkg.
1 parent 274b9fb commit 9b5e051

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

packages/react-dom/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
"./profiling": "./profiling.js",
5151
"./test-utils": "./test-utils.js",
5252
"./unstable_testing": "./unstable_testing.js",
53-
"./package.json": "./package.json",
54-
"./": "./"
53+
"./src/*": "./src/*",
54+
"./package.json": "./package.json"
5555
},
5656
"browser": {
5757
"./server.js": "./server.browser.js"

packages/react/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
"./package.json": "./package.json",
2828
"./jsx-runtime": "./jsx-runtime.js",
2929
"./jsx-dev-runtime": "./jsx-dev-runtime.js",
30-
"./": "./"
30+
"./unstable-shared-subset": "./unstable-shared-subset.js"
31+
3132
},
3233
"repository": {
3334
"type": "git",

scripts/rollup/bundles.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ const bundles = [
269269
FB_WWW_PROD,
270270
],
271271
moduleType: RENDERER,
272-
entry: 'react-dom/src/server/ReactDOMLegacyServerBrowser',
272+
entry: 'react-dom/src/server/ReactDOMLegacyServerBrowser.js',
273273
name: 'react-dom-server-legacy.browser',
274274
global: 'ReactDOMServer',
275275
minifyWithProdErrorCodes: true,
@@ -285,7 +285,7 @@ const bundles = [
285285
{
286286
bundleTypes: [NODE_DEV, NODE_PROD],
287287
moduleType: RENDERER,
288-
entry: 'react-dom/src/server/ReactDOMLegacyServerNode',
288+
entry: 'react-dom/src/server/ReactDOMLegacyServerNode.js',
289289
name: 'react-dom-server-legacy.node',
290290
externals: ['react', 'stream'],
291291
minifyWithProdErrorCodes: false,
@@ -302,7 +302,7 @@ const bundles = [
302302
{
303303
bundleTypes: [NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
304304
moduleType: RENDERER,
305-
entry: 'react-dom/src/server/ReactDOMFizzServerBrowser',
305+
entry: 'react-dom/src/server/ReactDOMFizzServerBrowser.js',
306306
name: 'react-dom-server.browser',
307307
global: 'ReactDOMServer',
308308
minifyWithProdErrorCodes: true,
@@ -312,7 +312,7 @@ const bundles = [
312312
{
313313
bundleTypes: [NODE_DEV, NODE_PROD],
314314
moduleType: RENDERER,
315-
entry: 'react-dom/src/server/ReactDOMFizzServerNode',
315+
entry: 'react-dom/src/server/ReactDOMFizzServerNode.js',
316316
name: 'react-dom-server.node',
317317
global: 'ReactDOMServer',
318318
minifyWithProdErrorCodes: false,
@@ -322,7 +322,7 @@ const bundles = [
322322
{
323323
bundleTypes: __EXPERIMENTAL__ ? [FB_WWW_DEV, FB_WWW_PROD] : [],
324324
moduleType: RENDERER,
325-
entry: 'react-server-dom-relay/src/ReactDOMServerFB',
325+
entry: 'react-server-dom-relay/src/ReactDOMServerFB.js',
326326
global: 'ReactDOMServerStreaming',
327327
minifyWithProdErrorCodes: false,
328328
wrapWithModuleBoundaries: false,

scripts/shared/inlinedHostConfigs.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = [
1212
entryPoints: [
1313
'react-dom',
1414
'react-dom/unstable_testing',
15-
'react-dom/src/server/ReactDOMFizzServerNode',
15+
'react-dom/src/server/ReactDOMFizzServerNode.js',
1616
'react-server-dom-webpack/writer.node.server',
1717
'react-server-dom-webpack',
1818
],
@@ -34,7 +34,7 @@ module.exports = [
3434
entryPoints: [
3535
'react-dom',
3636
'react-dom/unstable_testing',
37-
'react-dom/src/server/ReactDOMFizzServerBrowser',
37+
'react-dom/src/server/ReactDOMFizzServerBrowser.js',
3838
'react-server-dom-webpack/writer.browser.server',
3939
'react-server-dom-webpack',
4040
],
@@ -53,8 +53,8 @@ module.exports = [
5353
{
5454
shortName: 'dom-legacy',
5555
entryPoints: [
56-
'react-dom/src/server/ReactDOMLegacyServerBrowser', // react-dom/server.browser
57-
'react-dom/src/server/ReactDOMLegacyServerNode', // react-dom/server.node
56+
'react-dom/src/server/ReactDOMLegacyServerBrowser.js', // react-dom/server.browser
57+
'react-dom/src/server/ReactDOMLegacyServerNode.js', // react-dom/server.node
5858
],
5959
paths: [
6060
'react-dom',
@@ -99,7 +99,7 @@ module.exports = [
9999
entryPoints: [
100100
'react-server-dom-relay',
101101
'react-server-dom-relay/server',
102-
'react-server-dom-relay/src/ReactDOMServerFB',
102+
'react-server-dom-relay/src/ReactDOMServerFB.js',
103103
],
104104
paths: ['react-dom', 'react-server-dom-relay'],
105105
isFlowTyped: true,

0 commit comments

Comments
 (0)