Flow upgrade to 0.188

ghstack-source-id: 5c359b9
Pull Request resolved: #25423

Author: kassens

package.json

@@ -63,7 +63,7 @@
     "eslint-plugin-react-internal": "link:./scripts/eslint-rules",
     "fbjs-scripts": "1.2.0",
     "filesize": "^6.0.1",
-    "flow-bin": "^0.185.0",
+    "flow-bin": "^0.188.0",
     "glob": "^7.1.6",
     "glob-stream": "^6.1.0",
     "google-closure-compiler": "^20200517.0.0",

packages/react-devtools-core/src/editor.js

@@ -173,6 +173,7 @@ export function launchEditor(
     // There's an existing editor process already and it's attached
     // to the terminal, so go kill it. Otherwise two separate editor
     // instances attach to the stdin/stdout which gets confusing.
+    // $FlowFixMe[incompatible-use] found when upgrading Flow
     childProcess.kill('SIGKILL');
   }
 

packages/react-devtools-shared/src/backend/DevToolsComponentStackFrame.js

@@ -121,6 +121,7 @@ export function describeNativeComponentFrame(
         } catch (x) {
           control = x;
         }
+        // $FlowFixMe[prop-missing] found when upgrading Flow
         fn.call(Fake.prototype);
       }
     } else {

packages/react-devtools-shell/src/app/DeeplyNestedComponents/index.js

@@ -18,6 +18,7 @@ function wrapWithHoc(Component, index) {
   // $FlowFixMe
   const displayName = Component.displayName || Component.name;
 
+  // $FlowFixMe[incompatible-type] found when upgrading Flow
   HOC.displayName = `withHoc${index}(${displayName})`;
   return HOC;
 }

packages/react-devtools-shell/src/app/InspectableElements/CustomHooks.js

@@ -109,6 +109,7 @@ function wrapWithHoc(Component) {
   }
   // $FlowFixMe
   const displayName = Component.displayName || Component.name;
+  // $FlowFixMe[incompatible-type] found when upgrading Flow
   Hoc.displayName = `withHoc(${displayName})`;
   return Hoc;
 }

packages/react-dom-bindings/src/events/SyntheticEvent.js

@@ -81,6 +81,7 @@ function createSyntheticEvent(Interface: EventInterfaceType) {
     return this;
   }
 
+  // $FlowFixMe[prop-missing] found when upgrading Flow
   assign(SyntheticBaseEvent.prototype, {
     preventDefault: function() {
       this.defaultPrevented = true;

packages/react-dom/src/client/ReactDOMRoot.js

@@ -94,6 +94,7 @@ function ReactDOMRoot(internalRoot: FiberRoot) {
   this._internalRoot = internalRoot;
 }
 
+// $FlowFixMe[prop-missing] found when upgrading Flow
 ReactDOMHydrationRoot.prototype.render = ReactDOMRoot.prototype.render = function(
   children: ReactNodeList,
 ): void {
@@ -139,6 +140,7 @@ ReactDOMHydrationRoot.prototype.render = ReactDOMRoot.prototype.render = functio
   updateContainer(children, root, null, null);
 };
 
+// $FlowFixMe[prop-missing] found when upgrading Flow
 ReactDOMHydrationRoot.prototype.unmount = ReactDOMRoot.prototype.unmount = function(): void {
   if (__DEV__) {
     if (typeof arguments[0] === 'function') {
@@ -260,6 +262,7 @@ function scheduleHydration(target: Node) {
     queueExplicitHydrationTarget(target);
   }
 }
+// $FlowFixMe[prop-missing] found when upgrading Flow
 ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = scheduleHydration;
 
 export function hydrateRoot(

packages/react-pg/src/ReactPostgres.js

@@ -77,6 +77,7 @@ export function Pool(options: mixed) {
 
 type NestedMap = Map<any, Record | NestedMap>;
 
+// $FlowFixMe[prop-missing] found when upgrading Flow
 Pool.prototype.query = function(query: string, values?: Array<mixed>) {
   const pool = this.pool;
   const outerMap = unstable_getCacheForType(this.createRecordMap);

packages/react-reconciler/src/ReactFiberCommitWork.new.js

@@ -1237,6 +1237,7 @@ function abortRootTransitions(
             transitionInstance.pendingBoundaries !== null &&
             transitionInstance.pendingBoundaries.has(deletedOffscreenInstance)
           ) {
+            // $FlowFixMe[incompatible-use] found when upgrading Flow
             transitionInstance.pendingBoundaries.delete(
               deletedOffscreenInstance,
             );

packages/react-reconciler/src/ReactFiberCommitWork.old.js

@@ -1237,6 +1237,7 @@ function abortRootTransitions(
             transitionInstance.pendingBoundaries !== null &&
             transitionInstance.pendingBoundaries.has(deletedOffscreenInstance)
           ) {
+            // $FlowFixMe[incompatible-use] found when upgrading Flow
             transitionInstance.pendingBoundaries.delete(
               deletedOffscreenInstance,
             );